* [PATCH] gpio: sloppy-logic-analyzer: Fully open-code compatible for grepping
@ 2025-06-13 7:16 Krzysztof Kozlowski
2025-06-13 7:22 ` Wolfram Sang
2025-06-16 7:45 ` Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-13 7:16 UTC (permalink / raw)
To: Wolfram Sang, Linus Walleij, Bartosz Golaszewski, linux-gpio,
linux-kernel
Cc: Krzysztof Kozlowski
It is very useful to find driver implementing compatibles with `git grep
compatible`, so driver should not use defines for that string, even if
this means string will be effectively duplicated.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/gpio/gpio-sloppy-logic-analyzer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-sloppy-logic-analyzer.c b/drivers/gpio/gpio-sloppy-logic-analyzer.c
index 8cf3b171c599..969dddd3d6fa 100644
--- a/drivers/gpio/gpio-sloppy-logic-analyzer.c
+++ b/drivers/gpio/gpio-sloppy-logic-analyzer.c
@@ -306,7 +306,7 @@ static void gpio_la_poll_remove(struct platform_device *pdev)
}
static const struct of_device_id gpio_la_poll_of_match[] = {
- { .compatible = GPIO_LA_NAME },
+ { .compatible = "gpio-sloppy-logic-analyzer" },
{ }
};
MODULE_DEVICE_TABLE(of, gpio_la_poll_of_match);
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: sloppy-logic-analyzer: Fully open-code compatible for grepping
2025-06-13 7:16 [PATCH] gpio: sloppy-logic-analyzer: Fully open-code compatible for grepping Krzysztof Kozlowski
@ 2025-06-13 7:22 ` Wolfram Sang
2025-06-16 7:45 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2025-06-13 7:22 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Linus Walleij, Bartosz Golaszewski, linux-gpio, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 414 bytes --]
On Fri, Jun 13, 2025 at 09:16:28AM +0200, Krzysztof Kozlowski wrote:
> It is very useful to find driver implementing compatibles with `git grep
> compatible`, so driver should not use defines for that string, even if
> this means string will be effectively duplicated.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: sloppy-logic-analyzer: Fully open-code compatible for grepping
2025-06-13 7:16 [PATCH] gpio: sloppy-logic-analyzer: Fully open-code compatible for grepping Krzysztof Kozlowski
2025-06-13 7:22 ` Wolfram Sang
@ 2025-06-16 7:45 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2025-06-16 7:45 UTC (permalink / raw)
To: Wolfram Sang, Linus Walleij, Bartosz Golaszewski, linux-gpio,
linux-kernel, Krzysztof Kozlowski
Cc: Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
On Fri, 13 Jun 2025 09:16:28 +0200, Krzysztof Kozlowski wrote:
> It is very useful to find driver implementing compatibles with `git grep
> compatible`, so driver should not use defines for that string, even if
> this means string will be effectively duplicated.
>
>
Applied, thanks!
[1/1] gpio: sloppy-logic-analyzer: Fully open-code compatible for grepping
https://git.kernel.org/brgl/linux/c/bddfad9f7ef3fc73f0a6fb05996719adcb5082fc
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-16 7:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-13 7:16 [PATCH] gpio: sloppy-logic-analyzer: Fully open-code compatible for grepping Krzysztof Kozlowski
2025-06-13 7:22 ` Wolfram Sang
2025-06-16 7:45 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox