[PATCH 1/5] gpio: gpio-menz127: drop unneeded MODULE_ALIAS

[PATCH 1/5] gpio: gpio-menz127: drop unneeded MODULE_ALIAS

[Javier Rodriguez]

From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>

The MODULE_ALIAS() is redundant since the module alias is now
automatically generated from the MODULE_DEVICE_TABLE().

Remove the explicit alias.

No functional change intended.

Fixes: 1f4ea4838b13 ("mcb: Add missing modpost build support")
Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>
Cc: Linus Walleij <linusw@kernel.org>
Cc: Bartosz Golaszewski <brgl@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
---
 drivers/gpio/gpio-menz127.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/gpio-menz127.c b/drivers/gpio/gpio-menz127.c
index 52b13c6ae496..f51e7517f551 100644
--- a/drivers/gpio/gpio-menz127.c
+++ b/drivers/gpio/gpio-menz127.c
@@ -223,5 +223,4 @@ module_mcb_driver(men_z127_driver);
 MODULE_AUTHOR("Andreas Werner <andreas.werner@men.de>");
 MODULE_DESCRIPTION("MEN GPIO Controller");
 MODULE_LICENSE("GPL v2");
-MODULE_ALIAS("mcb:16z127");
 MODULE_IMPORT_NS("MCB");
-- 
2.52.0

Re: [PATCH 1/5] gpio: gpio-menz127: drop unneeded MODULE_ALIAS

[Andy Shevchenko]

On Tue, Dec 30, 2025 at 10:59:24PM +0100, Javier Rodriguez wrote:
>    From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
> 
>    The MODULE_ALIAS() is redundant since the module alias is now
>    automatically generated from the MODULE_DEVICE_TABLE().
> 
>    Remove the explicit alias.
> 
>    No functional change intended.

The patch is mangled.

>    Fixes: 1f4ea4838b13 ("mcb: Add missing modpost build support")
>    Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>

>    Cc: Linus Walleij <linusw@kernel.org>
>    Cc: Bartosz Golaszewski <brgl@kernel.org>
>    Cc: Andy Shevchenko <andriy.shevchenko@intel.com>
>    Cc: linux-gpio@vger.kernel.org

Please, move the Cc: list after the '---' line...

>    Signed-off-by: Jose Javier Rodriguez Barbarin
>    <dev-josejavier.rodriguez@duagon.com>
>    ---

...here. It will have the same effect on email, but will reduce a noise in the
Git history.

...

>    The information contained in this message is private and confidential, as
>    well as any enclosed document/file attached to it and is addressed
>    exclusively to its recipient. Please if you are not the intended recipient
>    and have received this message by mistake, notify us of this fact and
>    delete the message from your system. The copying, dissemination or
>    disclosure of its content to third parties without the prior written
>    consent of DUAGON IBERIA S.L. is forbidden. Otherwise, it will violate
>    current legislation. In accordance with Spanish Data Protection Law 3/2018
>    and the European Data Protection Regulation 2016/679, we remind you that
>    your data is processed by DUAGON IBERIA S.L.. You can freely exercise the
>    rights of access, opposition, rectification, cancellation or suppression,
>    revocation of consent, portability and limitation of data processing, by
>    contacting DUAGON IBERIA S.L., Ronda de Europa, 5. Tres Cantos. Madrid,
>    C.P. 28760. Spain.

This is not compatible with the Open Source workflow. Please, make sure there
is no footer in the next version.

...

Also, you missed a cover letter. Or send the patches separately as I don't see
now any evidence of the cross patch dependency.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 1/5] gpio: gpio-menz127: drop unneeded MODULE_ALIAS

[Jose Javier Rodriguez Barbarin]

On Fri, Jan 02, 2026 at 02:10:47PM +0200, Andy Shevchenko wrote:
> On Tue, Dec 30, 2025 at 10:59:24PM +0100, Javier Rodriguez wrote:
> >    From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
> > 
> >    The MODULE_ALIAS() is redundant since the module alias is now
> >    automatically generated from the MODULE_DEVICE_TABLE().
> > 
> >    Remove the explicit alias.
> > 
> >    No functional change intended.
> 
> The patch is mangled.
> 
> >    Fixes: 1f4ea4838b13 ("mcb: Add missing modpost build support")
> >    Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>
> 
> >    Cc: Linus Walleij <linusw@kernel.org>
> >    Cc: Bartosz Golaszewski <brgl@kernel.org>
> >    Cc: Andy Shevchenko <andriy.shevchenko@intel.com>
> >    Cc: linux-gpio@vger.kernel.org
> 
> Please, move the Cc: list after the '---' line...
> 
> >    Signed-off-by: Jose Javier Rodriguez Barbarin
> >    <dev-josejavier.rodriguez@duagon.com>
> >    ---
> 
> ...here. It will have the same effect on email, but will reduce a noise in the
> Git history.
> 
> ...
> 
> >    The information contained in this message is private and confidential, as
> >    well as any enclosed document/file attached to it and is addressed
> >    exclusively to its recipient. Please if you are not the intended recipient
> >    and have received this message by mistake, notify us of this fact and
> >    delete the message from your system. The copying, dissemination or
> >    disclosure of its content to third parties without the prior written
> >    consent of DUAGON IBERIA S.L. is forbidden. Otherwise, it will violate
> >    current legislation. In accordance with Spanish Data Protection Law 3/2018
> >    and the European Data Protection Regulation 2016/679, we remind you that
> >    your data is processed by DUAGON IBERIA S.L.. You can freely exercise the
> >    rights of access, opposition, rectification, cancellation or suppression,
> >    revocation of consent, portability and limitation of data processing, by
> >    contacting DUAGON IBERIA S.L., Ronda de Europa, 5. Tres Cantos. Madrid,
> >    C.P. 28760. Spain.
> 
> This is not compatible with the Open Source workflow. Please, make sure there
> is no footer in the next version.
> 

This is a bit embarrasing. I forgot to configure git to use tu proper email account.

> ...
> 
> Also, you missed a cover letter. Or send the patches separately as I don't see
> now any evidence of the cross patch dependency.

Yes, I decided to send the patches in a way that was not the best. So I'm going to
send the patches separately for each subsystem.

> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

Thank you so much for your review.

Regards,

Javier R.