[PATCH v1 1/1] pinctrl: cy8c95x0: Avoid returning positive values to user space

[PATCH v1 1/1] pinctrl: cy8c95x0: Avoid returning positive values to user space

[Andy Shevchenko]

When probe fails due to unclear interrupt status register, it returns
a positive number instead of the proper error code. Fix this accordingly.

Fixes: e6cbbe42944d ("pinctrl: Add Cypress cy8c95x0 support")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202602271847.vVWkqLBD-lkp@intel.com/
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/pinctrl/pinctrl-cy8c95x0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-cy8c95x0.c
index 0d295ebc33d1..ace0be5ec679 100644
--- a/drivers/pinctrl/pinctrl-cy8c95x0.c
+++ b/drivers/pinctrl/pinctrl-cy8c95x0.c
@@ -1300,7 +1300,7 @@ static int cy8c95x0_irq_setup(struct cy8c95x0_pinctrl *chip, int irq)
 	/* Read IRQ status register to clear all pending interrupts */
 	ret = cy8c95x0_irq_pending(chip, pending_irqs);
 	if (ret)
-		return dev_err_probe(dev, ret, "failed to clear irq status register\n");
+		return dev_err_probe(dev, -EBUSY, "failed to clear irq status register\n");
 
 	/* Mask all interrupts */
 	bitmap_fill(chip->irq_mask, MAX_LINE);
-- 
2.50.1

Re: [PATCH v1 1/1] pinctrl: cy8c95x0: Avoid returning positive values to user space

[Andy Shevchenko]

On Fri, Feb 27, 2026 at 05:43:35PM +0100, Andy Shevchenko wrote:
> When probe fails due to unclear interrupt status register, it returns
> a positive number instead of the proper error code. Fix this accordingly.

Note, for backporting this should be transformed to

-		return ret;
+		return -EBUSY;

in the respective lines.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] pinctrl: cy8c95x0: Avoid returning positive values to user space

[Linus Walleij]

On Fri, Feb 27, 2026 at 5:43 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> When probe fails due to unclear interrupt status register, it returns
> a positive number instead of the proper error code. Fix this accordingly.
>
> Fixes: e6cbbe42944d ("pinctrl: Add Cypress cy8c95x0 support")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/202602271847.vVWkqLBD-lkp@intel.com/
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Patch applied for fixes!

Yours,
Linus Walleij

Re: [PATCH v1 1/1] pinctrl: cy8c95x0: Avoid returning positive values to user space

[Linus Walleij]

On Tue, Mar 10, 2026 at 11:54 AM Linus Walleij <linusw@kernel.org> wrote:
> On Fri, Feb 27, 2026 at 5:43 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>
> > When probe fails due to unclear interrupt status register, it returns
> > a positive number instead of the proper error code. Fix this accordingly.
> >
> > Fixes: e6cbbe42944d ("pinctrl: Add Cypress cy8c95x0 support")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> > Closes: https://lore.kernel.org/r/202602271847.vVWkqLBD-lkp@intel.com/
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Patch applied for fixes!

Or no, for next actually, it doesn't apply to fixes... noticed
after applying to next.

Yours,
Linus Walleij

Re: [PATCH v1 1/1] pinctrl: cy8c95x0: Avoid returning positive values to user space

[Andy Shevchenko]

On Tue, Mar 10, 2026 at 11:55:37AM +0100, Linus Walleij wrote:
> On Tue, Mar 10, 2026 at 11:54 AM Linus Walleij <linusw@kernel.org> wrote:
> > On Fri, Feb 27, 2026 at 5:43 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> >
> > > When probe fails due to unclear interrupt status register, it returns
> > > a positive number instead of the proper error code. Fix this accordingly.
> > >
> > > Fixes: e6cbbe42944d ("pinctrl: Add Cypress cy8c95x0 support")
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> > > Closes: https://lore.kernel.org/r/202602271847.vVWkqLBD-lkp@intel.com/
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > Patch applied for fixes!
> 
> Or no, for next actually, it doesn't apply to fixes... noticed
> after applying to next.

Thanks!

Yes, I replied to it with explanation that for backporting the patch should be
modified.

-- 
With Best Regards,
Andy Shevchenko