From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: westeri@kernel.org, linusw@kernel.org, brgl@kernel.org,
bentiss@kernel.org, hansg@kernel.org,
Francesco Lauritano <francesco.lauritano1@protonmail.com>,
Marco Scardovi <mscardovi95@gmail.com>,
Armin Wolf <W_Armin@gmx.de>,
mika.westerberg@linux.intel.com, linux-gpio@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH] gpiolib: acpi: Only trigger ActiveBoth interrupts on boot
Date: Wed, 29 Apr 2026 10:19:09 +0300 [thread overview]
Message-ID: <afGw7aC4HVXWoygi@ashevche-desk.local> (raw)
In-Reply-To: <afGuw9VbvnGTQW0F@ashevche-desk.local>
On Wed, Apr 29, 2026 at 10:10:00AM +0300, Andy Shevchenko wrote:
> On Tue, Apr 28, 2026 at 09:52:39PM -0500, Mario Limonciello wrote:
...
> > - (event->irqflags & (IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING))) {
> > + ((event->irqflags & (IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING)) ==
> > + (IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING))) {
>
> Use _MASK in both cases.
>
> ((event->irqflags & IRQF_TRIGGER_MASK) == IRQF_TRIGGER_MASK)) {
Ah, I thought it was only for edge ones, seems we can't use it in the second part.
The other definitions are for TYPE, there we have IRQ_TYPE_EDGE_BOTH.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-29 7:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 2:52 [PATCH] gpiolib: acpi: Only trigger ActiveBoth interrupts on boot Mario Limonciello
2026-04-29 5:32 ` Mika Westerberg
2026-04-29 7:19 ` Andy Shevchenko
2026-04-29 7:09 ` Andy Shevchenko
2026-04-29 7:19 ` Andy Shevchenko [this message]
2026-04-29 9:48 ` Hans de Goede
2026-04-29 10:24 ` Andy Shevchenko
2026-04-29 11:01 ` Hans de Goede
2026-05-03 14:18 ` Marco Scardovi
2026-05-04 6:33 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afGw7aC4HVXWoygi@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=W_Armin@gmx.de \
--cc=bentiss@kernel.org \
--cc=brgl@kernel.org \
--cc=francesco.lauritano1@protonmail.com \
--cc=hansg@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mika.westerberg@linux.intel.com \
--cc=mscardovi95@gmail.com \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox