Re: [PATCH] gpiolib: acpi: Only trigger ActiveBoth interrupts on boot

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Wed, Apr 29, 2026 at 07:32:11AM +0200, Mika Westerberg wrote:
> On Tue, Apr 28, 2026 at 09:52:39PM -0500, Mario Limonciello wrote:
> > Commit ca876c7483b6 ("gpiolib-acpi: make sure we trigger edge events at
> > least once on boot") introduced logic to trigger edge-based GPIO
> > interrupts during initialization to ensure proper initial state setup
> > when firmware doesn't initialize it.
> > 
> > However, according to the Microsoft GPIO documentation, triggering GPIO
> > interrupts during initialization should only happen for interrupts
> > marked as ActiveBoth (both IRQF_TRIGGER_RISING and IRQF_TRIGGER_FALLING)
> > and only when the associated GPIO line is already asserted (logic level
> > low).
> > 
> > The current implementation incorrectly triggers:
> > 1. Any edge-triggered interrupt (RISING-only or FALLING-only)
> > 2. RISING interrupts when value is high and FALLING when value is low
> > 
> > This causes problems at bootup for single-edge interrupts that
> > don't follow the ActiveBoth pattern.
> > 
> > Fix this by:
> > - Only triggering when BOTH rising and falling edges are configured
> > - Only triggering when the GPIO line is asserted (value == 0)
> > 
> > Reported-by: Francesco Lauritano <francesco.lauritano1@protonmail.com>
> > Closes: https://lore.kernel.org/all/6iFCwGH2vssb7NRUTWGpkubGMNbgIlBHSz40z8ZsezjxngXpoiiRiJaijviNvhiDAGIr43bfUmdxLmxYoHDjyft4DgwFc3Pnu5hzPguTa0s=@protonmail.com/
> > Tested-by: Marco Scardovi <mscardovi95@gmail.com>
> > Fixes: ca876c7483b69 ("gpiolib-acpi: make sure we trigger edge events at least once on boot")
> > Link: https://learn.microsoft.com/en-us/windows-hardware/drivers/bringup/general-purpose-i-o--gpio-
> > Suggested-by: Armin Wolf <W_Armin@gmx.de>
> > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> 
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko