[PATCH] pinctrl: Export pinctrl_get_group_selector()

[PATCH] pinctrl: Export pinctrl_get_group_selector()

[Linus Walleij]

The recently added UltraRISC DP1000 is using this symbol, and in
a reasonable way as well, so export it.

Reported-by: Nathan Chancellor <nathan@kernel.org>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202606130210.ytVPxHlm-lkp@intel.com/
Fixes: cb7037924836 ("pinctrl: ultrarisc: Add UltraRISC DP1000 pinctrl driver")
Signed-off-by: Linus Walleij <linusw@kernel.org>
---
 drivers/pinctrl/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 3fcb7e584a93..1675dd36bd5c 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -772,6 +772,7 @@ int pinctrl_get_group_selector(struct pinctrl_dev *pctldev,
 
 	return -EINVAL;
 }
+EXPORT_SYMBOL_GPL(pinctrl_get_group_selector);
 
 bool pinctrl_gpio_can_use_line(struct gpio_chip *gc, unsigned int offset)
 {

---
base-commit: e3d967e6ef2f9605b132eabac64e984d884c81cf
change-id: 20260613-export-get-group-selector-d41bc33539c8

Best regards,
--  
Linus Walleij <linusw@kernel.org>

Re: [PATCH] pinctrl: Export pinctrl_get_group_selector()

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]

Hello,

On Sat, Jun 13, 2026 at 10:02:30PM +0200, Linus Walleij wrote:
> The recently added UltraRISC DP1000 is using this symbol, and in
> a reasonable way as well, so export it.
> 
> Reported-by: Nathan Chancellor <nathan@kernel.org> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202606130210.ytVPxHlm-lkp@intel.com/
> Fixes: cb7037924836 ("pinctrl: ultrarisc: Add UltraRISC DP1000 pinctrl driver")
> Signed-off-by: Linus Walleij <linusw@kernel.org>

I stumbled over this one, too, and see that

https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git for-next

already has that patch. Checkpatch criticises:

	WARNING: Reported-by: should be immediately followed by Closes: or Link: with a URL to the report
	#9:
	Reported-by: Nathan Chancellor <nathan@kernel.org>
	Reported-by: kernel test robot <lkp@intel.com>

. Not sure if you consider this relevant to fix (i.e. add:

	Link: https://lore.kernel.org/linux-gpio/20260613164847.GA3152104@ax162/

), but if you do, feel free to also add:

Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] pinctrl: Export pinctrl_get_group_selector()

[Linus Walleij]

On Mon, Jun 15, 2026 at 12:16 PM Uwe Kleine-König
<u.kleine-koenig@baylibre.com> wrote:

> On Sat, Jun 13, 2026 at 10:02:30PM +0200, Linus Walleij wrote:
> > The recently added UltraRISC DP1000 is using this symbol, and in
> > a reasonable way as well, so export it.
> >
> > Reported-by: Nathan Chancellor <nathan@kernel.org>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202606130210.ytVPxHlm-lkp@intel.com/
> > Fixes: cb7037924836 ("pinctrl: ultrarisc: Add UltraRISC DP1000 pinctrl driver")
> > Signed-off-by: Linus Walleij <linusw@kernel.org>
>
> I stumbled over this one, too, and see that
>
> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git for-next
>
> already has that patch. Checkpatch criticises:
>
>         WARNING: Reported-by: should be immediately followed by Closes: or Link: with a URL to the report
>         #9:
>         Reported-by: Nathan Chancellor <nathan@kernel.org>
>         Reported-by: kernel test robot <lkp@intel.com>

Now that is just checkpatch being silly, because what in in next looks
like this:

    Reported-by: Nathan Chancellor <nathan@kernel.org>
    Reported-by: kernel test robot <lkp@intel.com>
    Closes: https://lore.kernel.org/oe-kbuild-all/202606130210.ytVPxHlm-lkp@intel.com/
    Fixes: cb7037924836 ("pinctrl: ultrarisc: Add UltraRISC DP1000
pinctrl driver")
    Signed-off-by: Linus Walleij <linusw@kernel.org>

Certainly it doesn't matter which order the tags are in.
(And if it does, I don't feel it's important...)

> . Not sure if you consider this relevant to fix (i.e. add:
>
>         Link: https://lore.kernel.org/linux-gpio/20260613164847.GA3152104@ax162/
>
> ), but if you do, feel free to also add:
>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

I added it, the more the merrier!

Yours,
Linus Walleij

Re: [PATCH] pinctrl: Export pinctrl_get_group_selector()

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 989 bytes --]

On Mon, Jun 15, 2026 at 02:27:59PM +0200, Linus Walleij wrote:
> On Mon, Jun 15, 2026 at 12:16 PM Uwe Kleine-König
> <u.kleine-koenig@baylibre.com> wrote:
> > Checkpatch criticises:
> >
> >         WARNING: Reported-by: should be immediately followed by Closes: or Link: with a URL to the report
> >         #9:
> >         Reported-by: Nathan Chancellor <nathan@kernel.org>
> >         Reported-by: kernel test robot <lkp@intel.com>
> 
> Now that is just checkpatch being silly, because what in in next looks
> like this:
> 
>     Reported-by: Nathan Chancellor <nathan@kernel.org>
>     Reported-by: kernel test robot <lkp@intel.com>
>     Closes: https://lore.kernel.org/oe-kbuild-all/202606130210.ytVPxHlm-lkp@intel.com/
>     Fixes: cb7037924836 ("pinctrl: ultrarisc: Add UltraRISC DP1000
> pinctrl driver")
>     Signed-off-by: Linus Walleij <linusw@kernel.org>

Yeah, so the kernel test robot report has a Closes, but Nathan's
doesn't.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] pinctrl: Export pinctrl_get_group_selector()

[Linus Walleij]

On Mon, Jun 15, 2026 at 2:49 PM Uwe Kleine-König
<u.kleine-koenig@baylibre.com> wrote:
> On Mon, Jun 15, 2026 at 02:27:59PM +0200, Linus Walleij wrote:
> > On Mon, Jun 15, 2026 at 12:16 PM Uwe Kleine-König
> > <u.kleine-koenig@baylibre.com> wrote:
> > > Checkpatch criticises:
> > >
> > >         WARNING: Reported-by: should be immediately followed by Closes: or Link: with a URL to the report
> > >         #9:
> > >         Reported-by: Nathan Chancellor <nathan@kernel.org>
> > >         Reported-by: kernel test robot <lkp@intel.com>
> >
> > Now that is just checkpatch being silly, because what in in next looks
> > like this:
> >
> >     Reported-by: Nathan Chancellor <nathan@kernel.org>
> >     Reported-by: kernel test robot <lkp@intel.com>
> >     Closes: https://lore.kernel.org/oe-kbuild-all/202606130210.ytVPxHlm-lkp@intel.com/
> >     Fixes: cb7037924836 ("pinctrl: ultrarisc: Add UltraRISC DP1000
> > pinctrl driver")
> >     Signed-off-by: Linus Walleij <linusw@kernel.org>
>
> Yeah, so the kernel test robot report has a Closes, but Nathan's
> doesn't.

Ah OK I'll put the Link: to Nathans report as a Closes: instead.

Thanks!
Linus Walleij