* [PATCH v2 1/2] pinctrl: tigerlake: add some pin groups and functions for INTC1055
2026-06-12 10:13 [PATCH v2 0/2] upboard pinctrl support for device id INTC1055 GaryWang
@ 2026-06-12 10:13 ` GaryWang
2026-06-12 10:13 ` [PATCH v2 2/2] pinctrl: upboard: add device id INTC1055 based UP boards support GaryWang
` (2 subsequent siblings)
3 siblings, 0 replies; 14+ messages in thread
From: GaryWang @ 2026-06-12 10:13 UTC (permalink / raw)
To: Mika Westerberg, Andy Shevchenko, Linus Walleij, Thomas Richard
Cc: Daniele Cleri, JunYingLai, Louis Chen, linux-gpio, linux-kernel,
GaryWang
Add i2c0, i2c1, pwm0, uart1, ssp2 pin groups & functions in tgllp_soc_data
for device id INTC1055.
The pinctrl-upboard driver set the correct pin function corresponding to
these data.
Signed-off-by: GaryWang <is0124@gmail.com>
---
drivers/pinctrl/intel/pinctrl-tigerlake.c | 32 +++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/drivers/pinctrl/intel/pinctrl-tigerlake.c b/drivers/pinctrl/intel/pinctrl-tigerlake.c
index ae231f7fba49..aeb031570536 100644
--- a/drivers/pinctrl/intel/pinctrl-tigerlake.c
+++ b/drivers/pinctrl/intel/pinctrl-tigerlake.c
@@ -330,6 +330,34 @@ static const struct pinctrl_pin_desc tgllp_pins[] = {
PINCTRL_PIN(276, "SPI0_CLK_LOOPBK"),
};
+static const unsigned int tgllp_i2c0_pins[] = { 5, 6 };
+static const unsigned int tgllp_i2c1_pins[] = { 7, 8 };
+static const unsigned int tgllp_pwm0_pins[] = { 99 };
+static const unsigned int tgllp_uart1_pins[] = { 85, 86, 87, 88 };
+static const unsigned int tgllp_ssp2_pins[] = { 108, 109, 110, 111 };
+
+static const struct intel_pingroup tgllp_groups[] = {
+ PIN_GROUP("i2c0_grp", tgllp_i2c0_pins, 2),
+ PIN_GROUP("i2c1_grp", tgllp_i2c1_pins, 2),
+ PIN_GROUP("pwm0_grp", tgllp_pwm0_pins, 1),
+ PIN_GROUP("uart1_grp", tgllp_uart1_pins, 1),
+ PIN_GROUP("ssp2_grp", tgllp_ssp2_pins, 7),
+};
+
+static const char * const tgllp_i2c0_groups[] = { "i2c0_grp" };
+static const char * const tgllp_i2c1_groups[] = { "i2c1_grp" };
+static const char * const tgllp_pwm0_groups[] = { "pwm0_grp" };
+static const char * const tgllp_uart1_groups[] = { "uart1_grp" };
+static const char * const tgllp_ssp2_groups[] = { "ssp2_grp" };
+
+static const struct intel_function tgllp_functions[] = {
+ FUNCTION("i2c0", tgllp_i2c0_groups),
+ FUNCTION("i2c1", tgllp_i2c1_groups),
+ FUNCTION("pwm0", tgllp_pwm0_groups),
+ FUNCTION("uart1", tgllp_uart1_groups),
+ FUNCTION("ssp2", tgllp_ssp2_groups),
+};
+
static const struct intel_padgroup tgllp_community0_gpps[] = {
INTEL_GPP(0, 0, 25, 0), /* GPP_B */
INTEL_GPP(1, 26, 41, 32), /* GPP_T */
@@ -367,6 +395,10 @@ static const struct intel_community tgllp_communities[] = {
static const struct intel_pinctrl_soc_data tgllp_soc_data = {
.pins = tgllp_pins,
.npins = ARRAY_SIZE(tgllp_pins),
+ .groups = tgllp_groups,
+ .ngroups = ARRAY_SIZE(tgllp_groups),
+ .functions = tgllp_functions,
+ .nfunctions = ARRAY_SIZE(tgllp_functions),
.communities = tgllp_communities,
.ncommunities = ARRAY_SIZE(tgllp_communities),
};
--
2.43.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 2/2] pinctrl: upboard: add device id INTC1055 based UP boards support
2026-06-12 10:13 [PATCH v2 0/2] upboard pinctrl support for device id INTC1055 GaryWang
2026-06-12 10:13 ` [PATCH v2 1/2] pinctrl: tigerlake: add some pin groups and functions for INTC1055 GaryWang
@ 2026-06-12 10:13 ` GaryWang
2026-06-15 8:01 ` Thomas Richard
2026-06-15 4:35 ` [PATCH v2 0/2] upboard pinctrl support for device id INTC1055 Mika Westerberg
2026-06-15 12:32 ` Linus Walleij
3 siblings, 1 reply; 14+ messages in thread
From: GaryWang @ 2026-06-12 10:13 UTC (permalink / raw)
To: Mika Westerberg, Andy Shevchenko, Linus Walleij, Thomas Richard
Cc: Daniele Cleri, JunYingLai, Louis Chen, linux-gpio, linux-kernel,
GaryWang
Add support "UP Xtreme i12", "UP Squared Pro 7000", "UP Squared i12",
"UP 7000" boards and I2C/PWM/UART/SPI pins mapping data.
Signed-off-by: GaryWang <is0124@gmail.com>
---
drivers/pinctrl/pinctrl-upboard.c | 45 +++++++++++++++++++++++++++++++++++++++
1 file changed, 45 insertions(+)
diff --git a/drivers/pinctrl/pinctrl-upboard.c b/drivers/pinctrl/pinctrl-upboard.c
index f8c8b9d84990..09018b665ee3 100644
--- a/drivers/pinctrl/pinctrl-upboard.c
+++ b/drivers/pinctrl/pinctrl-upboard.c
@@ -912,6 +912,19 @@ static const struct upboard_pinctrl_map upboard_pinctrl_map_apl01 = {
.nmaps = ARRAY_SIZE(pinctrl_map_apl01),
};
+static const struct pinctrl_map pinctrl_map_adl[] = {
+ PIN_MAP_MUX_GROUP_DEFAULT("upboard-pinctrl", "INTC1055:00", "i2c0_grp", "i2c0"),
+ PIN_MAP_MUX_GROUP_DEFAULT("upboard-pinctrl", "INTC1055:00", "i2c1_grp", "i2c1"),
+ PIN_MAP_MUX_GROUP_DEFAULT("upboard-pinctrl", "INTC1055:00", "pwm0_grp", "pwm0"),
+ PIN_MAP_MUX_GROUP_DEFAULT("upboard-pinctrl", "INTC1055:00", "uart1_grp", "uart1"),
+ PIN_MAP_MUX_GROUP_DEFAULT("upboard-pinctrl", "INTC1055:00", "ssp2_grp", "ssp2"),
+};
+
+static const struct upboard_pinctrl_map upboard_pinctrl_map_adl = {
+ .maps = &pinctrl_map_adl[0],
+ .nmaps = ARRAY_SIZE(pinctrl_map_adl),
+};
+
static const struct dmi_system_id dmi_platform_info[] = {
{
/* UP Squared */
@@ -921,6 +934,38 @@ static const struct dmi_system_id dmi_platform_info[] = {
},
.driver_data = (void *)&upboard_pinctrl_map_apl01,
},
+ {
+ /* UP Xtreme i12 */
+ .matches = {
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AAEON"),
+ DMI_EXACT_MATCH(DMI_BOARD_NAME, "UPX-ADLP01"),
+ },
+ .driver_data = (void *)&upboard_pinctrl_map_adl,
+ },
+ {
+ /* UP Squared Pro 7000 */
+ .matches = {
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AAEON"),
+ DMI_EXACT_MATCH(DMI_BOARD_NAME, "UPN-ADLN01"),
+ },
+ .driver_data = (void *)&upboard_pinctrl_map_adl,
+ },
+ {
+ /* UP Squared i12 */
+ .matches = {
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AAEON"),
+ DMI_EXACT_MATCH(DMI_BOARD_NAME, "UPS-ADLP01"),
+ },
+ .driver_data = (void *)&upboard_pinctrl_map_adl,
+ },
+ {
+ /* UP 7000 */
+ .matches = {
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AAEON"),
+ DMI_EXACT_MATCH(DMI_BOARD_NAME, "UP-ADLN01"),
+ },
+ .driver_data = (void *)&upboard_pinctrl_map_adl,
+ },
{ }
};
--
2.43.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 2/2] pinctrl: upboard: add device id INTC1055 based UP boards support
2026-06-12 10:13 ` [PATCH v2 2/2] pinctrl: upboard: add device id INTC1055 based UP boards support GaryWang
@ 2026-06-15 8:01 ` Thomas Richard
2026-06-15 9:37 ` Thomas Richard
0 siblings, 1 reply; 14+ messages in thread
From: Thomas Richard @ 2026-06-15 8:01 UTC (permalink / raw)
To: GaryWang, Mika Westerberg, Andy Shevchenko, Linus Walleij
Cc: Daniele Cleri, JunYingLai, Louis Chen, linux-gpio, linux-kernel
Hello Gary,
On 6/12/26 12:13 PM, GaryWang wrote:
> Add support "UP Xtreme i12", "UP Squared Pro 7000", "UP Squared i12",
> "UP 7000" boards and I2C/PWM/UART/SPI pins mapping data.
>
Reviewed-by: Thomas Richard <thomas.richard@bootlin.com>
Best Regards,
Thomas
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] pinctrl: upboard: add device id INTC1055 based UP boards support
2026-06-15 8:01 ` Thomas Richard
@ 2026-06-15 9:37 ` Thomas Richard
2026-06-15 11:23 ` GaryWang
0 siblings, 1 reply; 14+ messages in thread
From: Thomas Richard @ 2026-06-15 9:37 UTC (permalink / raw)
To: GaryWang, Mika Westerberg, Andy Shevchenko, Linus Walleij
Cc: Daniele Cleri, JunYingLai, Louis Chen, linux-gpio, linux-kernel
Gary,
On 6/15/26 10:01 AM, Thomas Richard wrote:
> Hello Gary,
>
> On 6/12/26 12:13 PM, GaryWang wrote:
>> Add support "UP Xtreme i12", "UP Squared Pro 7000", "UP Squared i12",
>> "UP 7000" boards and I2C/PWM/UART/SPI pins mapping data.
>>
> Reviewed-by: Thomas Richard <thomas.richard@bootlin.com>
>
> Best Regards,
> Thomas
I did test your series on UP Squared Pro 7000 and pinctrl driver does
not probe. Pinctrl device INTC1055:00 does not exist on this board.
[ 12.818773] upboard-pinctrl upboard-pinctrl: unknown pinctrl device
INTC1055:00 in map entry, deferring probe
[ 12.818795] upboard-pinctrl upboard-pinctrl: error -EPROBE_DEFER:
Failed to select pinctrl
[ 12.818801] upboard-pinctrl upboard-pinctrl: Driver upboard-pinctrl
requests probe deferral
[ 12.818834] platform upboard-pinctrl: Added to deferred list
[ 12.818894] platform upboard-pinctrl: deferred probe pending:
upboard-pinctrl: Failed to select pinctrl
Did you test your series on all boards?
Best Regards,
Thomas
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] pinctrl: upboard: add device id INTC1055 based UP boards support
2026-06-15 9:37 ` Thomas Richard
@ 2026-06-15 11:23 ` GaryWang
2026-06-15 12:13 ` Thomas Richard
0 siblings, 1 reply; 14+ messages in thread
From: GaryWang @ 2026-06-15 11:23 UTC (permalink / raw)
To: Thomas Richard
Cc: Mika Westerberg, Andy Shevchenko, Linus Walleij, Daniele Cleri,
JunYingLai, Louis Chen, linux-gpio, linux-kernel
On Mon, 15 Jun 2026 at 17:37, Thomas Richard <thomas.richard@bootlin.com> wrote:
>
> Gary,
>
> On 6/15/26 10:01 AM, Thomas Richard wrote:
> > Hello Gary,
> >
> > On 6/12/26 12:13 PM, GaryWang wrote:
> >> Add support "UP Xtreme i12", "UP Squared Pro 7000", "UP Squared i12",
> >> "UP 7000" boards and I2C/PWM/UART/SPI pins mapping data.
> >>
> > Reviewed-by: Thomas Richard <thomas.richard@bootlin.com>
> >
> > Best Regards,
> > Thomas
>
> I did test your series on UP Squared Pro 7000 and pinctrl driver does
> not probe. Pinctrl device INTC1055:00 does not exist on this board.
>
> [ 12.818773] upboard-pinctrl upboard-pinctrl: unknown pinctrl device
> INTC1055:00 in map entry, deferring probe
> [ 12.818795] upboard-pinctrl upboard-pinctrl: error -EPROBE_DEFER:
> Failed to select pinctrl
> [ 12.818801] upboard-pinctrl upboard-pinctrl: Driver upboard-pinctrl
> requests probe deferral
> [ 12.818834] platform upboard-pinctrl: Added to deferred list
> [ 12.818894] platform upboard-pinctrl: deferred probe pending:
> upboard-pinctrl: Failed to select pinctrl
>
> Did you test your series on all boards?
>
Let me know your BIOS version, we;ll check internally, thanks.
> Best Regards,
> Thomas
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] pinctrl: upboard: add device id INTC1055 based UP boards support
2026-06-15 11:23 ` GaryWang
@ 2026-06-15 12:13 ` Thomas Richard
0 siblings, 0 replies; 14+ messages in thread
From: Thomas Richard @ 2026-06-15 12:13 UTC (permalink / raw)
To: GaryWang
Cc: Mika Westerberg, Andy Shevchenko, Linus Walleij, Daniele Cleri,
JunYingLai, Louis Chen, linux-gpio, linux-kernel
On 6/15/26 1:23 PM, GaryWang wrote:
> On Mon, 15 Jun 2026 at 17:37, Thomas Richard <thomas.richard@bootlin.com> wrote:
>>
>> Gary,
>>
>> On 6/15/26 10:01 AM, Thomas Richard wrote:
>>> Hello Gary,
>>>
>>> On 6/12/26 12:13 PM, GaryWang wrote:
>>>> Add support "UP Xtreme i12", "UP Squared Pro 7000", "UP Squared i12",
>>>> "UP 7000" boards and I2C/PWM/UART/SPI pins mapping data.
>>>>
>>> Reviewed-by: Thomas Richard <thomas.richard@bootlin.com>
>>>
>>> Best Regards,
>>> Thomas
>>
>> I did test your series on UP Squared Pro 7000 and pinctrl driver does
>> not probe. Pinctrl device INTC1055:00 does not exist on this board.
>>
>> [ 12.818773] upboard-pinctrl upboard-pinctrl: unknown pinctrl device
>> INTC1055:00 in map entry, deferring probe
>> [ 12.818795] upboard-pinctrl upboard-pinctrl: error -EPROBE_DEFER:
>> Failed to select pinctrl
>> [ 12.818801] upboard-pinctrl upboard-pinctrl: Driver upboard-pinctrl
>> requests probe deferral
>> [ 12.818834] platform upboard-pinctrl: Added to deferred list
>> [ 12.818894] platform upboard-pinctrl: deferred probe pending:
>> upboard-pinctrl: Failed to select pinctrl
>>
>> Did you test your series on all boards?
>>
> Let me know your BIOS version, we;ll check internally, thanks.
So I tested all boards of the series. It is okay for "UP Xtreme i12" and
"UP Squared i12".
For "UP 7000" and "UP Squared Pro 7000" I have the same error,
INTC1055:00 does not exist. Pinctrl device is INTC1057:00.
Please find BIOS version for both boards below.
UP 7000:
# cat /sys/devices/virtual/dmi/id/bios_version
UPASAM10
# cat /sys/devices/virtual/dmi/id/bios_release
5.26
# cat /sys/devices/virtual/dmi/id/bios_date
04/23/2024
UP Squared Pro 7000:
# cat /sys/devices/virtual/dmi/id/bios_version
UNADAM21
# cat /sys/devices/virtual/dmi/id/bios_release
5.26
# cat /sys/devices/virtual/dmi/id/bios_date
04/18/2023
Best Regards,
Thomas
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/2] upboard pinctrl support for device id INTC1055
2026-06-12 10:13 [PATCH v2 0/2] upboard pinctrl support for device id INTC1055 GaryWang
2026-06-12 10:13 ` [PATCH v2 1/2] pinctrl: tigerlake: add some pin groups and functions for INTC1055 GaryWang
2026-06-12 10:13 ` [PATCH v2 2/2] pinctrl: upboard: add device id INTC1055 based UP boards support GaryWang
@ 2026-06-15 4:35 ` Mika Westerberg
2026-06-15 7:01 ` GaryWang
2026-06-15 12:32 ` Linus Walleij
3 siblings, 1 reply; 14+ messages in thread
From: Mika Westerberg @ 2026-06-15 4:35 UTC (permalink / raw)
To: GaryWang
Cc: Andy Shevchenko, Linus Walleij, Thomas Richard, Daniele Cleri,
JunYingLai, Louis Chen, linux-gpio, linux-kernel
Hi,
On Fri, Jun 12, 2026 at 06:13:31PM +0800, GaryWang wrote:
> Add missing groups and functions in Tigerlake's pinctrl driver for INTC1055.
> Add support "UP Xtreme i12", "UP Squared Pro 7000", "UP Squared i12", "UP 7000" boards.
>
> The pinctrl-upboard is provide additional driving power & pin mux function
> through native SOC pins -> FPGA/CPLD -> hat pins for flexable board level
> applications. it's probe from ACPI device id AANT0F01 & AANT0F04.
>
> Signed-off-by: GaryWang <is0124@gmail.com>
> ---
> Changes in v2:
> - Add brief introduction pinctrl-upboard architecture in cover content.
> - Add more detail explaining for pinctrl-tigerlake commit message.
> - Link to v1: https://lore.kernel.org/r/20260610-upboard-pinctrl-add-upboard-intc1055-support-v1-0-8185d2abbfb1@gmail.com
>
> ---
> GaryWang (2):
> pinctrl: tigerlake: add some pin groups and functions for INTC1055
> pinctrl: upboard: add device id INTC1055 based UP boards support
Both,
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/2] upboard pinctrl support for device id INTC1055
2026-06-15 4:35 ` [PATCH v2 0/2] upboard pinctrl support for device id INTC1055 Mika Westerberg
@ 2026-06-15 7:01 ` GaryWang
2026-06-15 9:47 ` Mika Westerberg
0 siblings, 1 reply; 14+ messages in thread
From: GaryWang @ 2026-06-15 7:01 UTC (permalink / raw)
To: Mika Westerberg
Cc: Andy Shevchenko, Linus Walleij, Thomas Richard, Daniele Cleri,
JunYingLai, Louis Chen, linux-gpio, linux-kernel
On Mon, 15 Jun 2026 at 12:35, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
>
> Hi,
>
> On Fri, Jun 12, 2026 at 06:13:31PM +0800, GaryWang wrote:
> > Add missing groups and functions in Tigerlake's pinctrl driver for INTC1055.
> > Add support "UP Xtreme i12", "UP Squared Pro 7000", "UP Squared i12", "UP 7000" boards.
> >
> > The pinctrl-upboard is provide additional driving power & pin mux function
> > through native SOC pins -> FPGA/CPLD -> hat pins for flexable board level
> > applications. it's probe from ACPI device id AANT0F01 & AANT0F04.
> >
> > Signed-off-by: GaryWang <is0124@gmail.com>
> > ---
> > Changes in v2:
> > - Add brief introduction pinctrl-upboard architecture in cover content.
> > - Add more detail explaining for pinctrl-tigerlake commit message.
> > - Link to v1: https://lore.kernel.org/r/20260610-upboard-pinctrl-add-upboard-intc1055-support-v1-0-8185d2abbfb1@gmail.com
> >
> > ---
> > GaryWang (2):
> > pinctrl: tigerlake: add some pin groups and functions for INTC1055
> > pinctrl: upboard: add device id INTC1055 based UP boards support
>
> Both,
Sorry, I am unclear what Both?
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/2] upboard pinctrl support for device id INTC1055
2026-06-15 7:01 ` GaryWang
@ 2026-06-15 9:47 ` Mika Westerberg
0 siblings, 0 replies; 14+ messages in thread
From: Mika Westerberg @ 2026-06-15 9:47 UTC (permalink / raw)
To: GaryWang
Cc: Andy Shevchenko, Linus Walleij, Thomas Richard, Daniele Cleri,
JunYingLai, Louis Chen, linux-gpio, linux-kernel
On Mon, Jun 15, 2026 at 03:01:23PM +0800, GaryWang wrote:
> On Mon, 15 Jun 2026 at 12:35, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> >
> > Hi,
> >
> > On Fri, Jun 12, 2026 at 06:13:31PM +0800, GaryWang wrote:
> > > Add missing groups and functions in Tigerlake's pinctrl driver for INTC1055.
> > > Add support "UP Xtreme i12", "UP Squared Pro 7000", "UP Squared i12", "UP 7000" boards.
> > >
> > > The pinctrl-upboard is provide additional driving power & pin mux function
> > > through native SOC pins -> FPGA/CPLD -> hat pins for flexable board level
> > > applications. it's probe from ACPI device id AANT0F01 & AANT0F04.
> > >
> > > Signed-off-by: GaryWang <is0124@gmail.com>
> > > ---
> > > Changes in v2:
> > > - Add brief introduction pinctrl-upboard architecture in cover content.
> > > - Add more detail explaining for pinctrl-tigerlake commit message.
> > > - Link to v1: https://lore.kernel.org/r/20260610-upboard-pinctrl-add-upboard-intc1055-support-v1-0-8185d2abbfb1@gmail.com
> > >
> > > ---
> > > GaryWang (2):
> > > pinctrl: tigerlake: add some pin groups and functions for INTC1055
> > > pinctrl: upboard: add device id INTC1055 based UP boards support
> >
> > Both,
> Sorry, I am unclear what Both?
Both patches :)
> >
> > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/2] upboard pinctrl support for device id INTC1055
2026-06-12 10:13 [PATCH v2 0/2] upboard pinctrl support for device id INTC1055 GaryWang
` (2 preceding siblings ...)
2026-06-15 4:35 ` [PATCH v2 0/2] upboard pinctrl support for device id INTC1055 Mika Westerberg
@ 2026-06-15 12:32 ` Linus Walleij
2026-06-15 14:07 ` Andy Shevchenko
3 siblings, 1 reply; 14+ messages in thread
From: Linus Walleij @ 2026-06-15 12:32 UTC (permalink / raw)
To: GaryWang
Cc: Mika Westerberg, Andy Shevchenko, Thomas Richard, Daniele Cleri,
JunYingLai, Louis Chen, linux-gpio, linux-kernel
On Fri, Jun 12, 2026 at 12:13 PM GaryWang <is0124@gmail.com> wrote:
> Add missing groups and functions in Tigerlake's pinctrl driver for INTC1055.
> Add support "UP Xtreme i12", "UP Squared Pro 7000", "UP Squared i12", "UP 7000" boards.
>
> The pinctrl-upboard is provide additional driving power & pin mux function
> through native SOC pins -> FPGA/CPLD -> hat pins for flexable board level
> applications. it's probe from ACPI device id AANT0F01 & AANT0F04.
>
> Signed-off-by: GaryWang <is0124@gmail.com>
LGTM
Acked-by: Linus Walleij <linusw@kernel.org>
Since these touch Tigerlake, I expect Andy to queue and send me
the patches from his tree.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2 0/2] upboard pinctrl support for device id INTC1055
2026-06-15 12:32 ` Linus Walleij
@ 2026-06-15 14:07 ` Andy Shevchenko
2026-06-15 14:25 ` GaryWang
0 siblings, 1 reply; 14+ messages in thread
From: Andy Shevchenko @ 2026-06-15 14:07 UTC (permalink / raw)
To: Linus Walleij
Cc: GaryWang, Mika Westerberg, Andy Shevchenko, Thomas Richard,
Daniele Cleri, JunYingLai, Louis Chen, linux-gpio, linux-kernel
On Mon, Jun 15, 2026 at 02:32:51PM +0200, Linus Walleij wrote:
> On Fri, Jun 12, 2026 at 12:13 PM GaryWang <is0124@gmail.com> wrote:
>
> > Add missing groups and functions in Tigerlake's pinctrl driver for INTC1055.
> > Add support "UP Xtreme i12", "UP Squared Pro 7000", "UP Squared i12", "UP 7000" boards.
> >
> > The pinctrl-upboard is provide additional driving power & pin mux function
> > through native SOC pins -> FPGA/CPLD -> hat pins for flexable board level
> > applications. it's probe from ACPI device id AANT0F01 & AANT0F04.
> >
> > Signed-off-by: GaryWang <is0124@gmail.com>
>
> LGTM
> Acked-by: Linus Walleij <linusw@kernel.org>
>
> Since these touch Tigerlake, I expect Andy to queue and send me
> the patches from his tree.
Yes, this is the idea, but first I want to hear form Gary about Up 7000, which
seems doesn't work with this.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/2] upboard pinctrl support for device id INTC1055
2026-06-15 14:07 ` Andy Shevchenko
@ 2026-06-15 14:25 ` GaryWang
2026-06-15 15:00 ` Andy Shevchenko
0 siblings, 1 reply; 14+ messages in thread
From: GaryWang @ 2026-06-15 14:25 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Linus Walleij, Mika Westerberg, Andy Shevchenko, Thomas Richard,
Daniele Cleri, JunYingLai, Louis Chen, linux-gpio, linux-kernel
On Mon, 15 Jun 2026 at 22:07, Andy Shevchenko
<andriy.shevchenko@intel.com> wrote:
>
> On Mon, Jun 15, 2026 at 02:32:51PM +0200, Linus Walleij wrote:
> > On Fri, Jun 12, 2026 at 12:13 PM GaryWang <is0124@gmail.com> wrote:
> >
> > > Add missing groups and functions in Tigerlake's pinctrl driver for INTC1055.
> > > Add support "UP Xtreme i12", "UP Squared Pro 7000", "UP Squared i12", "UP 7000" boards.
> > >
> > > The pinctrl-upboard is provide additional driving power & pin mux function
> > > through native SOC pins -> FPGA/CPLD -> hat pins for flexable board level
> > > applications. it's probe from ACPI device id AANT0F01 & AANT0F04.
> > >
> > > Signed-off-by: GaryWang <is0124@gmail.com>
> >
> > LGTM
> > Acked-by: Linus Walleij <linusw@kernel.org>
> >
> > Since these touch Tigerlake, I expect Andy to queue and send me
> > the patches from his tree.
>
> Yes, this is the idea, but first I want to hear form Gary about Up 7000, which
> seems doesn't work with this.
>
It's my bad, the up squared pro has p & n series processor, I only checked the
p series.
The p series is used INTC1055 and n series is using INTC1057 has confirmed.
I need remove n series boards, until we finished testing, thanks.
> --
> With Best Regards,
> Andy Shevchenko
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/2] upboard pinctrl support for device id INTC1055
2026-06-15 14:25 ` GaryWang
@ 2026-06-15 15:00 ` Andy Shevchenko
0 siblings, 0 replies; 14+ messages in thread
From: Andy Shevchenko @ 2026-06-15 15:00 UTC (permalink / raw)
To: GaryWang
Cc: Linus Walleij, Mika Westerberg, Andy Shevchenko, Thomas Richard,
Daniele Cleri, JunYingLai, Louis Chen, linux-gpio, linux-kernel
On Mon, Jun 15, 2026 at 10:25:32PM +0800, GaryWang wrote:
> On Mon, 15 Jun 2026 at 22:07, Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> > On Mon, Jun 15, 2026 at 02:32:51PM +0200, Linus Walleij wrote:
> > > On Fri, Jun 12, 2026 at 12:13 PM GaryWang <is0124@gmail.com> wrote:
> > >
> > > > Add missing groups and functions in Tigerlake's pinctrl driver for INTC1055.
> > > > Add support "UP Xtreme i12", "UP Squared Pro 7000", "UP Squared i12", "UP 7000" boards.
> > > >
> > > > The pinctrl-upboard is provide additional driving power & pin mux function
> > > > through native SOC pins -> FPGA/CPLD -> hat pins for flexable board level
> > > > applications. it's probe from ACPI device id AANT0F01 & AANT0F04.
> > > >
> > > > Signed-off-by: GaryWang <is0124@gmail.com>
> > >
> > > LGTM
> > > Acked-by: Linus Walleij <linusw@kernel.org>
> > >
> > > Since these touch Tigerlake, I expect Andy to queue and send me
> > > the patches from his tree.
> >
> > Yes, this is the idea, but first I want to hear form Gary about Up 7000, which
> > seems doesn't work with this.
> >
> It's my bad, the up squared pro has p & n series processor, I only checked the
> p series.
> The p series is used INTC1055 and n series is using INTC1057 has confirmed.
> I need remove n series boards, until we finished testing, thanks.
Okay, please finish testing, update commit messages (and code if necessary),
collected tags, and send a v3. Take your time as it won't be proceeded within
two weeks (merge window is ongoing).
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 14+ messages in thread