From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>, Michael Buesch <m@bues.ch>,
Andy Shevchenko <andy@kernel.org>,
William Breathitt Gray <wbg@kernel.org>,
Robert Richter <rric@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 20/21] gpio: Unify style of pci_device_id arrays
Date: Thu, 16 Jul 2026 20:42:44 +0300 [thread overview]
Message-ID: <alkYFLPlMOT-8EH1@ashevche-desk.local> (raw)
In-Reply-To: <a5c6484f2ff045068b667e3c08e8f98fd31cbbc6.1784133987.git.u.kleine-koenig@baylibre.com>
On Wed, Jul 15, 2026 at 06:55:25PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> Update the various of_device_id arrays to conform to the most used and
OF?!
I guess you messed up with the patches in this series. Two mistakes I can only
explain with some bad rebase happened or alike.
> generally recommended coding style. That is:
>
> - no comma after the list terminator;
> - a comma after an initializer if (and only if) the closing } is not
> directly following;
> - no explicit zeros in the list terminator;
> - a space after an opening { and before a closing }, a single space in
> the list terminator;
> - at most one entry per line;
>
> Adapt the few offenders accordingly.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-07-16 17:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 16:55 [PATCH v2 00/21] gpio: Improvements around device-id arrays Uwe Kleine-König (The Capable Hub)
2026-07-15 16:55 ` [PATCH v2 01/21] gpio: Remove __maybe_unused annotations from acpi_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-15 16:55 ` [PATCH v2 02/21] gpio: fxl6408: Remove __maybe_unused annotations from of_device_id array Uwe Kleine-König (The Capable Hub)
2026-07-15 16:55 ` [PATCH v2 03/21] gpio: Drop unused assignment of acpi_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-07-15 16:55 ` [PATCH v2 04/21] gpio: max7301: Drop unused assignment of spi_device_id " Uwe Kleine-König (The Capable Hub)
2026-07-15 16:55 ` [PATCH v2 05/21] gpio: mmio: Drop unused assignment of platform_device_id " Uwe Kleine-König (The Capable Hub)
2026-07-15 16:55 ` [PATCH v2 06/21] gpio: ljca: Drop unused assignment of auxiliary_device_id " Uwe Kleine-König (The Capable Hub)
2026-07-15 16:55 ` [PATCH v2 07/21] gpio: Add missing ACPI module annotations Uwe Kleine-König (The Capable Hub)
2026-07-15 16:55 ` [PATCH v2 08/21] gpio: sodaville: Add missing PCI " Uwe Kleine-König (The Capable Hub)
2026-07-15 16:55 ` [PATCH v2 09/21] gpio: Add missing OF " Uwe Kleine-König (The Capable Hub)
2026-07-15 16:55 ` [PATCH v2 10/21] gpio: pxa: Add missing platform " Uwe Kleine-König (The Capable Hub)
2026-07-15 16:55 ` [PATCH v2 11/21] gpio: pl061: Use empty initializer for amba_id terminator Uwe Kleine-König (The Capable Hub)
2026-07-15 16:55 ` [PATCH v2 12/21] gpio: Use named initializers for acpi_device_id array Uwe Kleine-König (The Capable Hub)
2026-07-15 16:55 ` [PATCH v2 13/21] gpio: Use named initializers for spi_device_id array Uwe Kleine-König (The Capable Hub)
2026-07-15 16:55 ` [PATCH v2 14/21] gpio: virtio: Use a named initializer for virtio_device_id array Uwe Kleine-König (The Capable Hub)
2026-07-15 16:55 ` [PATCH v2 15/21] gpio: pcf857x: Use named initializers for of_device_id array Uwe Kleine-König (The Capable Hub)
2026-07-15 16:55 ` [PATCH v2 16/21] gpio: Unify style of acpi_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-16 17:41 ` Andy Shevchenko
2026-07-17 8:31 ` Uwe Kleine-König (The Capable Hub)
2026-07-17 10:27 ` Andy Shevchenko
2026-07-15 16:55 ` [PATCH v2 17/21] gpio: Unify style of of_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-15 16:55 ` [PATCH v2 18/21] gpio: max77620: Unify style of platform_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-15 16:55 ` [PATCH v2 19/21] gpio: Unify style of spi_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-15 16:55 ` [PATCH v2 20/21] gpio: Unify style of pci_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-16 17:42 ` Andy Shevchenko [this message]
2026-07-16 19:59 ` Uwe Kleine-König (The Capable Hub)
2026-07-15 16:55 ` [PATCH v2 21/21] gpio: Unify style of various *_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-16 17:43 ` [PATCH v2 00/21] gpio: Improvements around device-id arrays Andy Shevchenko
2026-07-16 17:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alkYFLPlMOT-8EH1@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m@bues.ch \
--cc=rric@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
--cc=wbg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox