From: Thomas Gleixner <tglx@linutronix.de>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Brian Norris <briannorris@chromium.org>,
Heiko Stuebner <heiko@sntech.de>,
Linus Walleij <linus.walleij@linaro.org>,
linux-rockchip@lists.infradead.org,
Julia Cartwright <julia@ni.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-gpio@vger.kernel.org, John Keeping <john@metanate.com>,
linux-pm@vger.kernel.org, Doug Anderson <dianders@chromium.org>,
Peter Zijlstra <peterz@infradead.org>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH for 4.12] Revert "pinctrl: rockchip: avoid hardirq-unsafe functions in irq_chip"
Date: Sat, 24 Jun 2017 11:21:43 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1706241120360.1941@nanos> (raw)
In-Reply-To: <20170623224049.GP3721@linux.vnet.ibm.com>
On Fri, 23 Jun 2017, Paul E. McKenney wrote:
> On Sat, Jun 24, 2017 at 12:12:49AM +0200, Thomas Gleixner wrote:
> > which added that RCU locking stuff and thereby broke the long existing
> > bus_lock() facility of the interrupt core.
> >
> > irq_bus_lock/unlock was explicitely made to allow sleeping locks for
> > interrupt chips which hang behind slow busses like i2c or spi. It took us
> > quite some effort to get this done and that patch broke it permanently.
> >
> > I'm not sure what to do here. This is an ever recurring issue simply
> > because RT requires that sleeping locks can be taken inside rcu locked
> > regions. So sooner than later we need a resoilution for that problem.
>
> The usual advice would be for 4990d4fe327b ("PM / Wakeirq: Add automated
> device wake IRQ handling") to use SRCU rather than RCU. Is there some
> reason that won't work?
I can't see one. So yes, we should rather convert that stuff to SRCU
instead of playing ping pong forever.
Thanks,
tglx
next prev parent reply other threads:[~2017-06-24 9:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 22:56 [4.12 REGRESSION] pinctrl: rockchip: sleeping function called from atomic context Brian Norris
2017-05-27 2:19 ` Brian Norris
2017-06-23 20:59 ` [PATCH for 4.12] Revert "pinctrl: rockchip: avoid hardirq-unsafe functions in irq_chip" Brian Norris
2017-06-23 21:10 ` Heiko Stuebner
2017-06-23 22:12 ` Thomas Gleixner
2017-06-23 22:40 ` Paul E. McKenney
2017-06-24 9:21 ` Thomas Gleixner [this message]
2017-06-27 0:06 ` Brian Norris
2017-06-27 6:24 ` Tony Lindgren
2017-06-27 7:07 ` Brian Norris
2017-06-27 7:32 ` Tony Lindgren
2017-06-27 13:01 ` Thomas Gleixner
2017-06-27 13:06 ` Thomas Gleixner
2017-06-27 17:23 ` Brian Norris
2017-06-27 18:07 ` Thomas Gleixner
2017-06-27 13:26 ` Heiko Stübner
2017-06-27 16:35 ` Thomas Gleixner
2017-06-29 13:05 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1706241120360.1941@nanos \
--to=tglx@linutronix.de \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=john@metanate.com \
--cc=julia@ni.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox