From: Julia Lawall <julia.lawall@inria.fr>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, kbuild-all@lists.01.org
Subject: [PATCH] usb: phy: phy-gpio-vbus-usb: fix odd_ptr_err.cocci warnings
Date: Sat, 28 Dec 2019 22:39:08 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1912282237590.2578@hadrien> (raw)
From: kbuild test robot <lkp@intel.com>
Inconsistent IS_ERR and PTR_ERR on line 291.
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
Fixes: ec84cd4d1bb8 ("usb: phy: phy-gpio-vbus-usb: Convert to GPIO descriptors")
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git gpio-descriptors-usb
head: ec84cd4d1bb85874b0ed3f5e4e567fb2ccb956bd
commit: ec84cd4d1bb85874b0ed3f5e4e567fb2ccb956bd [6/6] usb: phy: phy-gpio-vbus-usb: Convert to GPIO descriptors
:::::: branch date: 6 hours ago
:::::: commit date: 6 hours ago
phy-gpio-vbus-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/usb/phy/phy-gpio-vbus-usb.c
+++ b/drivers/usb/phy/phy-gpio-vbus-usb.c
@@ -288,7 +288,7 @@ static int gpio_vbus_probe(struct platfo
gpio_vbus->pullup_gpiod = devm_gpiod_get_optional(dev, "pullup",
GPIOD_OUT_LOW);
if (IS_ERR(gpio_vbus->pullup_gpiod)) {
- err = PTR_ERR(gpio_vbus->vbus_gpiod);
+ err = PTR_ERR(gpio_vbus->pullup_gpiod);
dev_err(&pdev->dev, "can't request pullup gpio, err: %d\n",
err);
return err;
reply other threads:[~2019-12-28 21:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1912282237590.2578@hadrien \
--to=julia.lawall@inria.fr \
--cc=kbuild-all@lists.01.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox