Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: Thomas Richard <thomas.richard@bootlin.com>
To: GaryWang <is0124@gmail.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
	Andy Shevchenko <andy@kernel.org>,
	Linus Walleij <linusw@kernel.org>,
	Daniele Cleri <danielecleri@aaeon.eu>,
	JunYingLai <junyinglai@aaeon.com.tw>,
	Louis Chen <louischen@aaeon.com.tw>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] pinctrl: upboard: add device id INTC1055 based UP boards support
Date: Wed, 8 Jul 2026 09:49:04 +0200	[thread overview]
Message-ID: <b2ee8bf9-de42-441a-97fb-2e42ad882b5e@bootlin.com> (raw)
In-Reply-To: <CANYHO6qfRL-5rJevKrYySai5MoWjNm9xvVOkMVAmt8YN-cZPnQ@mail.gmail.com>

Hello Gary,

On 7/7/26 5:55 PM, GaryWang wrote:
> On Tue, Jul 7, 2026 at 7:50 PM Thomas Richard
> <thomas.richard@bootlin.com> wrote:
>>
>> Hello Gary,
>>
>> On 7/6/26 12:36 PM, Gary Wang wrote:
>>> Add support "UP Xtreme i12" and I2C/PWM/UART/SPI pins mapping data.
>>
>> Driver probes successfully on UP Xtreme i12.
>>
>> I tested the IOs:
>> - pwm0 does not work.
> you have to use our pwm kernel module for pwm test, I'll provide later.

Ack

>> - uart1 partially works: TX is okay, but loopback doesn't work. Signal
>> is bad when I add a loopback. Looks like pinctrl misconfig on SoC side.
> uart1 tested ok on our side, if you loop TX/RX do not forget to turn off
> hardware flow control. and we have executed cmd as below to make sure
> direction is set all right.
> echo "uart1_grp uart1" >
> /sys/kernel/debug/pinctrl/upboard-pinctrl/pinmux-select

I did some tests with/without flow control using linux-serial-test tool.

>> - i2c busses are okay.
>> - for SPI, MOSI and CLK are okay, but not CS.
> Do you have enabled spi in BIOS HAT configuration?
> CS0 should be ok, it's SOC defined, CS1 is optional, users can activate low by
> himself before read/write, actually all gpio can be manually used as CS pin.

I applied an ACPI overlay. I'll test it again.

>> - all GPIOs are okay.
>>
>> Could you have a look please.

Anyway these are not related to this patch series.
Thanks for the clarification.

Tested-by: Thomas Richard <thomas.richard@bootlin.com>

Best Regards,
Thomas

  reply	other threads:[~2026-07-08  7:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06 10:36 [PATCH v4 0/2] upboard pinctrl support for device id INTC1055 Gary Wang
2026-07-06 10:36 ` [PATCH v4 1/2] pinctrl: tigerlake: add some pin groups and functions for INTC1055 Gary Wang
2026-07-06 10:36 ` [PATCH v4 2/2] pinctrl: upboard: add device id INTC1055 based UP boards support Gary Wang
2026-07-07 11:50   ` Thomas Richard
2026-07-07 15:55     ` GaryWang
2026-07-08  7:49       ` Thomas Richard [this message]
2026-07-08  9:21         ` Andy Shevchenko
2026-07-08 10:39           ` GaryWang
2026-07-08 12:55           ` Thomas Richard
2026-07-08 14:29 ` [PATCH v4 0/2] upboard pinctrl support for device id INTC1055 Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2ee8bf9-de42-441a-97fb-2e42ad882b5e@bootlin.com \
    --to=thomas.richard@bootlin.com \
    --cc=andy@kernel.org \
    --cc=danielecleri@aaeon.eu \
    --cc=is0124@gmail.com \
    --cc=junyinglai@aaeon.com.tw \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=louischen@aaeon.com.tw \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox