[PATCH 0/4] Drive-by changes to axp20x drivers

[PATCH 0/4] Drive-by changes to axp20x drivers

[Uwe Kleine-König]

Hello,

while trying to help a Debian user debugging why USB doesn't work in the
installer on a bananapi, I discovered these patch opportunities. They
are only build tested.

The first patch touches a different subsystem than the other three, but
given that maintainership overlaps and the first two patches are
identical in spirit, I still created a single series only. The two
subsets are orthogonal, so can be picked up individually by their
respective subsystem maintainers (and please do so assuming you're happy
with the patches).

Best regards
Uwe

Uwe Kleine-König (4):
  pinctrl: axp209: Drop check for disabled devices
  power: supply: axp20x*: Drop check for disabled devices
  power: supply: axp20x_usb: Introduce a helper variable for &pdev->dev
  power: supply: axp20x_usb: Improve probe error reporting

 drivers/pinctrl/pinctrl-axp209.c        |  3 --
 drivers/power/supply/axp20x_ac_power.c  |  3 --
 drivers/power/supply/axp20x_battery.c   |  3 --
 drivers/power/supply/axp20x_usb_power.c | 50 ++++++++++++-------------
 4 files changed, 25 insertions(+), 34 deletions(-)


base-commit: 3f2425f5b5bbbdd991ca9cdfd5502e68d8895998
-- 
2.47.3

[PATCH 1/4] pinctrl: axp209: Drop check for disabled devices

[Uwe Kleine-König]

Since commit 6b5c350648b8 ("mfd: mfd-core: Honour Device Tree's request
to disable a child-device") the mfd core checks for disabled devices, so
there is no use in doing that again in the mfd child driver.

Drop the check.

Signed-off-by: Uwe Kleine-König <ukleinek@debian.org>
---
 drivers/pinctrl/pinctrl-axp209.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-axp209.c b/drivers/pinctrl/pinctrl-axp209.c
index 2bd8487484a8..5539ce642b39 100644
--- a/drivers/pinctrl/pinctrl-axp209.c
+++ b/drivers/pinctrl/pinctrl-axp209.c
@@ -442,9 +442,6 @@ static int axp20x_pctl_probe(struct platform_device *pdev)
 	struct pinctrl_desc *pctrl_desc;
 	int ret;
 
-	if (!of_device_is_available(pdev->dev.of_node))
-		return -ENODEV;
-
 	if (!axp20x) {
 		dev_err(&pdev->dev, "Parent drvdata not set\n");
 		return -EINVAL;
-- 
2.47.3

Re: [PATCH 0/4] Drive-by changes to axp20x drivers

[Chen-Yu Tsai]

On Mon, Sep 21, 2026 at 5:42 PM Uwe Kleine-König <ukleinek@debian.org> wrote:
>
> Hello,
>
> while trying to help a Debian user debugging why USB doesn't work in the
> installer on a bananapi, I discovered these patch opportunities. They
> are only build tested.
>
> The first patch touches a different subsystem than the other three, but
> given that maintainership overlaps and the first two patches are
> identical in spirit, I still created a single series only. The two
> subsets are orthogonal, so can be picked up individually by their
> respective subsystem maintainers (and please do so assuming you're happy
> with the patches).
>
> Best regards
> Uwe
>
> Uwe Kleine-König (4):
>   pinctrl: axp209: Drop check for disabled devices
>   power: supply: axp20x*: Drop check for disabled devices
>   power: supply: axp20x_usb: Introduce a helper variable for &pdev->dev
>   power: supply: axp20x_usb: Improve probe error reporting

Whole series is

Reviewed-by: Chen-Yu Tsai <wens@kernel.org>

Re: [PATCH 1/4] pinctrl: axp209: Drop check for disabled devices

[Linus Walleij]

On Mon, Sep 21, 2026 at 11:42 AM Uwe Kleine-König <ukleinek@debian.org> wrote:

> Since commit 6b5c350648b8 ("mfd: mfd-core: Honour Device Tree's request
> to disable a child-device") the mfd core checks for disabled devices, so
> there is no use in doing that again in the mfd child driver.
>
> Drop the check.
>
> Signed-off-by: Uwe Kleine-König <ukleinek@debian.org>

This patch 1/4 applied to the pin control tree.

Yours,
Linus Walleij

Re: (subset) [PATCH 0/4] Drive-by changes to axp20x drivers

[Sebastian Reichel]

On Mon, 21 Sep 2026 11:41:45 +0200, Uwe Kleine-König wrote:
> while trying to help a Debian user debugging why USB doesn't work in the
> installer on a bananapi, I discovered these patch opportunities. They
> are only build tested.
> 
> The first patch touches a different subsystem than the other three, but
> given that maintainership overlaps and the first two patches are
> identical in spirit, I still created a single series only. The two
> subsets are orthogonal, so can be picked up individually by their
> respective subsystem maintainers (and please do so assuming you're happy
> with the patches).
> 
> [...]

Applied, thanks!

[2/4] power: supply: axp20x*: Drop check for disabled devices
      commit: c9ed44ab230f4359cdb3a72263c65daf31bd8528
[3/4] power: supply: axp20x_usb: Introduce a helper variable for &pdev->dev
      commit: da54acbc2ff2470c49259a91a5f48c4b0cce09d7
[4/4] power: supply: axp20x_usb: Improve probe error reporting
      commit: f945606a8cb34c97d644ed487282f96641b05185

Best regards,
-- 
Sebastian Reichel <sebastian.reichel@collabora.com>