From: Michal Simek <michal.simek@amd.com>
To: Liao Chen <liaochen4@huawei.com>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: linus.walleij@linaro.org, brgl@bgdev.pl
Subject: Re: [PATCH -next] gpio: modepin: Enable module autoloading
Date: Mon, 2 Sep 2024 14:45:41 +0200 [thread overview]
Message-ID: <d58fab14-a91c-45eb-94b5-c13ec3ff7984@amd.com> (raw)
In-Reply-To: <20240902115848.904227-1-liaochen4@huawei.com>
On 9/2/24 13:58, Liao Chen wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based
> on the alias from of_device_id table.
>
> Signed-off-by: Liao Chen <liaochen4@huawei.com>
> ---
> drivers/gpio/gpio-zynqmp-modepin.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-zynqmp-modepin.c b/drivers/gpio/gpio-zynqmp-modepin.c
> index a0d69387c153..2f3c9ebfa78d 100644
> --- a/drivers/gpio/gpio-zynqmp-modepin.c
> +++ b/drivers/gpio/gpio-zynqmp-modepin.c
> @@ -146,6 +146,7 @@ static const struct of_device_id modepin_platform_id[] = {
> { .compatible = "xlnx,zynqmp-gpio-modepin", },
> { }
> };
> +MODULE_DEVICE_TABLE(of, modepin_platform_id);
>
> static struct platform_driver modepin_platform_driver = {
> .driver = {
I did the same change internally some day ago but didn't send it.
Reviewed-by: Michal Simek <michal.simek@amd.com>
Thanks,
Michal
next prev parent reply other threads:[~2024-09-02 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 11:58 [PATCH -next] gpio: modepin: Enable module autoloading Liao Chen
2024-09-02 12:45 ` Michal Simek [this message]
2024-09-02 13:01 ` Bartosz Golaszewski
2024-09-02 13:02 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d58fab14-a91c-45eb-94b5-c13ec3ff7984@amd.com \
--to=michal.simek@amd.com \
--cc=brgl@bgdev.pl \
--cc=liaochen4@huawei.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox