Linux GPIO subsystem development
 help / color / mirror / Atom feed
* [PATCH -next] gpio: modepin: Enable module autoloading
@ 2024-09-02 11:58 Liao Chen
  2024-09-02 12:45 ` Michal Simek
  2024-09-02 13:01 ` Bartosz Golaszewski
  0 siblings, 2 replies; 4+ messages in thread
From: Liao Chen @ 2024-09-02 11:58 UTC (permalink / raw)
  To: linux-gpio, linux-arm-kernel, linux-kernel
  Cc: linus.walleij, brgl, michal.simek, liaochen4

Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based
on the alias from of_device_id table.

Signed-off-by: Liao Chen <liaochen4@huawei.com>
---
 drivers/gpio/gpio-zynqmp-modepin.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-zynqmp-modepin.c b/drivers/gpio/gpio-zynqmp-modepin.c
index a0d69387c153..2f3c9ebfa78d 100644
--- a/drivers/gpio/gpio-zynqmp-modepin.c
+++ b/drivers/gpio/gpio-zynqmp-modepin.c
@@ -146,6 +146,7 @@ static const struct of_device_id modepin_platform_id[] = {
 	{ .compatible = "xlnx,zynqmp-gpio-modepin", },
 	{ }
 };
+MODULE_DEVICE_TABLE(of, modepin_platform_id);
 
 static struct platform_driver modepin_platform_driver = {
 	.driver = {
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH -next] gpio: modepin: Enable module autoloading
  2024-09-02 11:58 [PATCH -next] gpio: modepin: Enable module autoloading Liao Chen
@ 2024-09-02 12:45 ` Michal Simek
  2024-09-02 13:01 ` Bartosz Golaszewski
  1 sibling, 0 replies; 4+ messages in thread
From: Michal Simek @ 2024-09-02 12:45 UTC (permalink / raw)
  To: Liao Chen, linux-gpio, linux-arm-kernel, linux-kernel; +Cc: linus.walleij, brgl



On 9/2/24 13:58, Liao Chen wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based
> on the alias from of_device_id table.
> 
> Signed-off-by: Liao Chen <liaochen4@huawei.com>
> ---
>   drivers/gpio/gpio-zynqmp-modepin.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpio/gpio-zynqmp-modepin.c b/drivers/gpio/gpio-zynqmp-modepin.c
> index a0d69387c153..2f3c9ebfa78d 100644
> --- a/drivers/gpio/gpio-zynqmp-modepin.c
> +++ b/drivers/gpio/gpio-zynqmp-modepin.c
> @@ -146,6 +146,7 @@ static const struct of_device_id modepin_platform_id[] = {
>   	{ .compatible = "xlnx,zynqmp-gpio-modepin", },
>   	{ }
>   };
> +MODULE_DEVICE_TABLE(of, modepin_platform_id);
>   
>   static struct platform_driver modepin_platform_driver = {
>   	.driver = {

I did the same change internally some day ago but didn't send it.

Reviewed-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -next] gpio: modepin: Enable module autoloading
  2024-09-02 11:58 [PATCH -next] gpio: modepin: Enable module autoloading Liao Chen
  2024-09-02 12:45 ` Michal Simek
@ 2024-09-02 13:01 ` Bartosz Golaszewski
  2024-09-02 13:02   ` Bartosz Golaszewski
  1 sibling, 1 reply; 4+ messages in thread
From: Bartosz Golaszewski @ 2024-09-02 13:01 UTC (permalink / raw)
  To: linux-gpio, linux-arm-kernel, linux-kernel, Liao Chen
  Cc: Bartosz Golaszewski, linus.walleij, brgl, michal.simek

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Mon, 02 Sep 2024 11:58:48 +0000, Liao Chen wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based
> on the alias from of_device_id table.
> 
> 

Applied, thanks!

[1/1] gpio: modepin: Enable module autoloading
      commit: a5135526426df5319d5f4bcd15ae57c45a97714b

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -next] gpio: modepin: Enable module autoloading
  2024-09-02 13:01 ` Bartosz Golaszewski
@ 2024-09-02 13:02   ` Bartosz Golaszewski
  0 siblings, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2024-09-02 13:02 UTC (permalink / raw)
  To: linux-gpio, linux-arm-kernel, linux-kernel, Liao Chen
  Cc: Bartosz Golaszewski, linus.walleij, michal.simek

On Mon, Sep 2, 2024 at 3:01 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
>
> On Mon, 02 Sep 2024 11:58:48 +0000, Liao Chen wrote:
> > Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based
> > on the alias from of_device_id table.
> >
> >
>
> Applied, thanks!
>
> [1/1] gpio: modepin: Enable module autoloading
>       commit: a5135526426df5319d5f4bcd15ae57c45a97714b
>
> Best regards,
> --
> Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

I also added the Fixes tag.

Bart

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-09-02 13:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-02 11:58 [PATCH -next] gpio: modepin: Enable module autoloading Liao Chen
2024-09-02 12:45 ` Michal Simek
2024-09-02 13:01 ` Bartosz Golaszewski
2024-09-02 13:02   ` Bartosz Golaszewski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox