* [PATCH next] pinctrl: bcm281xx: Add missing assignment in bcm21664_pinctrl_lock_all()
@ 2025-03-10 10:48 Dan Carpenter
2025-03-10 13:17 ` Florian Fainelli
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dan Carpenter @ 2025-03-10 10:48 UTC (permalink / raw)
To: Artur Weber
Cc: Linus Walleij, Florian Fainelli, Ray Jui, Scott Branden,
Broadcom internal kernel review list, Dan Carpenter, linux-gpio,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, kernel-janitors
The next line checks if this regmap_write() failed, but it doesn't
work because the assignment was accidentally left out. Add the
assignment.
Fixes: 60d69769c851 ("pinctrl: bcm281xx: Add support for BCM21664 pinmux")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/pinctrl/bcm/pinctrl-bcm281xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm281xx.c b/drivers/pinctrl/bcm/pinctrl-bcm281xx.c
index 7c8f8bd7da12..9ea20fde3a24 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm281xx.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm281xx.c
@@ -1498,8 +1498,8 @@ static int bcm21664_pinctrl_lock_all(struct bcm281xx_pinctrl_data *pdata)
rc);
return rc;
}
- regmap_write(pdata->regmap, BCM21664_ACCESS_LOCK_OFFSET(i),
- 0xffffffff);
+ rc = regmap_write(pdata->regmap, BCM21664_ACCESS_LOCK_OFFSET(i),
+ 0xffffffff);
if (rc) {
dev_err(pdata->dev, "Failed to write access lock: %d\n",
rc);
--
2.47.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH next] pinctrl: bcm281xx: Add missing assignment in bcm21664_pinctrl_lock_all()
2025-03-10 10:48 [PATCH next] pinctrl: bcm281xx: Add missing assignment in bcm21664_pinctrl_lock_all() Dan Carpenter
@ 2025-03-10 13:17 ` Florian Fainelli
2025-03-11 17:34 ` Artur Weber
2025-03-14 10:35 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2025-03-10 13:17 UTC (permalink / raw)
To: Dan Carpenter, Artur Weber
Cc: Linus Walleij, Ray Jui, Scott Branden,
Broadcom internal kernel review list, linux-gpio,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, kernel-janitors
On 3/10/2025 3:48 AM, Dan Carpenter wrote:
> The next line checks if this regmap_write() failed, but it doesn't
> work because the assignment was accidentally left out. Add the
> assignment.
>
> Fixes: 60d69769c851 ("pinctrl: bcm281xx: Add support for BCM21664 pinmux")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH next] pinctrl: bcm281xx: Add missing assignment in bcm21664_pinctrl_lock_all()
2025-03-10 10:48 [PATCH next] pinctrl: bcm281xx: Add missing assignment in bcm21664_pinctrl_lock_all() Dan Carpenter
2025-03-10 13:17 ` Florian Fainelli
@ 2025-03-11 17:34 ` Artur Weber
2025-03-14 10:35 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Artur Weber @ 2025-03-11 17:34 UTC (permalink / raw)
To: Dan Carpenter
Cc: Linus Walleij, Florian Fainelli, Ray Jui, Scott Branden,
Broadcom internal kernel review list, linux-gpio,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, kernel-janitors
On 10.03.2025 11:48, Dan Carpenter wrote:
> The next line checks if this regmap_write() failed, but it doesn't
> work because the assignment was accidentally left out. Add the
> assignment.
>
> Fixes: 60d69769c851 ("pinctrl: bcm281xx: Add support for BCM21664 pinmux")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Artur Weber <aweber.kernel@gmail.com>
Best regards
Artur
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH next] pinctrl: bcm281xx: Add missing assignment in bcm21664_pinctrl_lock_all()
2025-03-10 10:48 [PATCH next] pinctrl: bcm281xx: Add missing assignment in bcm21664_pinctrl_lock_all() Dan Carpenter
2025-03-10 13:17 ` Florian Fainelli
2025-03-11 17:34 ` Artur Weber
@ 2025-03-14 10:35 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2025-03-14 10:35 UTC (permalink / raw)
To: Dan Carpenter
Cc: Artur Weber, Florian Fainelli, Ray Jui, Scott Branden,
Broadcom internal kernel review list, linux-gpio,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, kernel-janitors
On Mon, Mar 10, 2025 at 11:48 AM Dan Carpenter <dan.carpenter@linaro.org> wrote:
> The next line checks if this regmap_write() failed, but it doesn't
> work because the assignment was accidentally left out. Add the
> assignment.
>
> Fixes: 60d69769c851 ("pinctrl: bcm281xx: Add support for BCM21664 pinmux")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-14 10:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-10 10:48 [PATCH next] pinctrl: bcm281xx: Add missing assignment in bcm21664_pinctrl_lock_all() Dan Carpenter
2025-03-10 13:17 ` Florian Fainelli
2025-03-11 17:34 ` Artur Weber
2025-03-14 10:35 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox