Re: [PATCH v8 3/5] gpio: shared: unwind partial failures in gpiochip_setup_shared()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] gpio: mix of scoped_guard() and goto cleanup in gpio_shared_setup_entry()
--

commit 2481d0c90c9615bb803575d8a0c1c3449eb188b0
Author: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

gpio: shared: unwind partial failures in gpiochip_setup_shared()

This patch updates gpio_shared_setup_entry() and gpiochip_setup_shared() to
unwind previously registered auxiliary devices and completed entries when a
partial failure occurs during setup.

> diff --git a/drivers/gpio/gpiolib-shared.c b/drivers/gpio/gpiolib-shared.c
> index 47b434db72f1e..043d5daba7a73 100644
> --- a/drivers/gpio/gpiolib-shared.c
> +++ b/drivers/gpio/gpiolib-shared.c
> @@ -589,13 +589,25 @@ static int gpio_shared_setup_entry(struct gpio_chip *gc,
>  			 ref->con_id ?: "(none)");
>  
>  		ret = gpio_shared_make_adev(gdev, entry, ref);
> -		if (ret) {
> -			gpiod_free_commit(desc);
> -			return ret;
> -		}
> +		if (ret)
> +			goto err_out;
>  	}
>  
>  	return 0;
> +
> +err_out:
> +	gpiod_free_commit(desc);
> +	list_for_each_entry_continue_reverse(ref, &entry->refs, list)
> +		gpio_shared_remove_adev(&ref->adev);
> +
> +	return ret;
> +}

[Severity: Low]
This isn't a bug since the scoped_guard() block has already exited before the
loop, but include/linux/cleanup.h advises against mixing goto error handling
and scope-based cleanup helpers in the same function:

drivers/gpio/gpiolib-shared.c:gpio_shared_setup_entry() {
	...
	scoped_guard(mutex, &entry->lock) {
		...
	}

	list_for_each_entry(ref, &entry->refs, list) {
		...
		ret = gpio_shared_make_adev(gdev, entry, ref);
		if (ret)
			goto err_out;
	}
}

Since err_out only has a single caller when gpio_shared_make_adev() fails,
could the cleanup be kept inline inside the if (ret) block instead of adding a
goto label?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261029-gpio-shared-fwnode-lookup-v8-0-d15d75cd560f@oss.qualcomm.com?part=3