* [PATCH v8 1/5] gpio: shared: factor out per-entry teardown helper
2026-10-29 16:22 [PATCH v8 0/5] gpio: shared: replace platform lookup with dummy software nodes Bartosz Golaszewski
@ 2026-10-29 16:22 ` Bartosz Golaszewski
2026-10-29 16:22 ` [PATCH v8 2/5] gpio: shared: factor out per-entry setup helper Bartosz Golaszewski
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Bartosz Golaszewski @ 2026-10-29 16:22 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Abel Vesa
Cc: linux-arm-msm, linux-gpio, linux-kernel, Bartosz Golaszewski
Move the body of the loop in gpio_device_teardown_shared() into
gpio_shared_teardown_entry(). This is a preparation for unwinding a
partially completed gpiochip_setup_shared(), which will need to tear
down individual entries. No functional change.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
drivers/gpio/gpiolib-shared.c | 37 ++++++++++++++++++++++---------------
1 file changed, 22 insertions(+), 15 deletions(-)
diff --git a/drivers/gpio/gpiolib-shared.c b/drivers/gpio/gpiolib-shared.c
index 8c9ac9d9330490b17fb3936b8758beb97a308a15..64bb450f0a8461d214a45aa97e2474ff0d1857ce 100644
--- a/drivers/gpio/gpiolib-shared.c
+++ b/drivers/gpio/gpiolib-shared.c
@@ -517,6 +517,27 @@ static void gpio_shared_remove_adev(struct auxiliary_device *adev)
auxiliary_device_uninit(adev);
}
+static void gpio_shared_teardown_entry(struct gpio_device *gdev,
+ struct gpio_shared_entry *entry)
+{
+ struct gpio_shared_ref *ref;
+
+ scoped_guard(mutex, &entry->lock)
+ gpiod_free_commit(&gdev->descs[entry->offset]);
+
+ list_for_each_entry(ref, &entry->refs, list) {
+ if (ref->lookup) {
+ gpiod_remove_lookup_table(ref->lookup);
+ kfree(ref->lookup->table[0].key);
+ kfree(ref->lookup->dev_id);
+ kfree(ref->lookup);
+ ref->lookup = NULL;
+ }
+
+ gpio_shared_remove_adev(&ref->adev);
+ }
+}
+
int gpiochip_setup_shared(struct gpio_chip *gc)
{
struct gpio_device *gdev = gc->gpiodev;
@@ -606,26 +627,12 @@ int gpiochip_setup_shared(struct gpio_chip *gc)
void gpio_device_teardown_shared(struct gpio_device *gdev)
{
struct gpio_shared_entry *entry;
- struct gpio_shared_ref *ref;
list_for_each_entry(entry, &gpio_shared_list, list) {
if (!device_match_fwnode(&gdev->dev, entry->fwnode))
continue;
- scoped_guard(mutex, &entry->lock)
- gpiod_free_commit(&gdev->descs[entry->offset]);
-
- list_for_each_entry(ref, &entry->refs, list) {
- if (ref->lookup) {
- gpiod_remove_lookup_table(ref->lookup);
- kfree(ref->lookup->table[0].key);
- kfree(ref->lookup->dev_id);
- kfree(ref->lookup);
- ref->lookup = NULL;
- }
-
- gpio_shared_remove_adev(&ref->adev);
- }
+ gpio_shared_teardown_entry(gdev, entry);
}
}
--
2.47.3
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v8 2/5] gpio: shared: factor out per-entry setup helper
2026-10-29 16:22 [PATCH v8 0/5] gpio: shared: replace platform lookup with dummy software nodes Bartosz Golaszewski
2026-10-29 16:22 ` [PATCH v8 1/5] gpio: shared: factor out per-entry teardown helper Bartosz Golaszewski
@ 2026-10-29 16:22 ` Bartosz Golaszewski
2026-10-29 16:22 ` [PATCH v8 3/5] gpio: shared: unwind partial failures in gpiochip_setup_shared() Bartosz Golaszewski
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Bartosz Golaszewski @ 2026-10-29 16:22 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Abel Vesa
Cc: linux-arm-msm, linux-gpio, linux-kernel, Bartosz Golaszewski
Move the per-entry part of gpiochip_setup_shared() into
gpio_shared_setup_entry(). This is a preparation for making the setup
all-or-nothing, which requires handling the failure of a single entry
in isolation. No functional change.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
drivers/gpio/gpiolib-shared.c | 112 ++++++++++++++++++++++++------------------
1 file changed, 63 insertions(+), 49 deletions(-)
diff --git a/drivers/gpio/gpiolib-shared.c b/drivers/gpio/gpiolib-shared.c
index 64bb450f0a8461d214a45aa97e2474ff0d1857ce..47b434db72f1ebd35ec36ebdb35f30809f4522f2 100644
--- a/drivers/gpio/gpiolib-shared.c
+++ b/drivers/gpio/gpiolib-shared.c
@@ -538,12 +538,71 @@ static void gpio_shared_teardown_entry(struct gpio_device *gdev,
}
}
+static int gpio_shared_setup_entry(struct gpio_chip *gc,
+ struct gpio_shared_entry *entry)
+{
+ struct gpio_device *gdev = gc->gpiodev;
+ struct gpio_shared_ref *ref;
+ struct gpio_desc *desc;
+ int ret;
+
+ scoped_guard(mutex, &entry->lock) {
+#if IS_ENABLED(CONFIG_OF)
+ if (is_of_node(entry->fwnode) && gc->of_xlate) {
+ /*
+ * This is the earliest that we can tranlate the
+ * devicetree offset to the chip offset.
+ */
+ struct of_phandle_args gpiospec = { };
+
+ gpiospec.np = to_of_node(entry->fwnode);
+ gpiospec.args_count = 2;
+ gpiospec.args[0] = entry->offset;
+
+ ret = gc->of_xlate(gc, &gpiospec, NULL);
+ if (ret < 0)
+ return ret;
+
+ entry->offset = ret;
+ }
+#endif /* CONFIG_OF */
+
+ desc = &gdev->descs[entry->offset];
+
+ __set_bit(GPIOD_FLAG_SHARED, &desc->flags);
+ /*
+ * Shared GPIOs are not requested via the normal path. Make
+ * them inaccessible to anyone even before we register the
+ * chip.
+ */
+ ret = gpiod_request_commit(desc, "shared");
+ if (ret)
+ return ret;
+
+ pr_debug("GPIO %u owned by %s is shared by multiple consumers\n",
+ entry->offset, gpio_device_get_label(gdev));
+ }
+
+ list_for_each_entry(ref, &entry->refs, list) {
+ pr_debug("Setting up a shared GPIO entry for %s (con_id: '%s')\n",
+ fwnode_get_name(ref->fwnode) ?: "(no fwnode)",
+ ref->con_id ?: "(none)");
+
+ ret = gpio_shared_make_adev(gdev, entry, ref);
+ if (ret) {
+ gpiod_free_commit(desc);
+ return ret;
+ }
+ }
+
+ return 0;
+}
+
int gpiochip_setup_shared(struct gpio_chip *gc)
{
struct gpio_device *gdev = gc->gpiodev;
struct gpio_shared_entry *entry;
struct gpio_shared_ref *ref;
- struct gpio_desc *desc;
int ret;
list_for_each_entry(entry, &gpio_shared_list, list) {
@@ -571,54 +630,9 @@ int gpiochip_setup_shared(struct gpio_chip *gc)
if (list_count_nodes(&entry->refs) <= 1)
continue;
- scoped_guard(mutex, &entry->lock) {
-#if IS_ENABLED(CONFIG_OF)
- if (is_of_node(entry->fwnode) && gc->of_xlate) {
- /*
- * This is the earliest that we can tranlate the
- * devicetree offset to the chip offset.
- */
- struct of_phandle_args gpiospec = { };
-
- gpiospec.np = to_of_node(entry->fwnode);
- gpiospec.args_count = 2;
- gpiospec.args[0] = entry->offset;
-
- ret = gc->of_xlate(gc, &gpiospec, NULL);
- if (ret < 0)
- return ret;
-
- entry->offset = ret;
- }
-#endif /* CONFIG_OF */
-
- desc = &gdev->descs[entry->offset];
-
- __set_bit(GPIOD_FLAG_SHARED, &desc->flags);
- /*
- * Shared GPIOs are not requested via the normal path. Make
- * them inaccessible to anyone even before we register the
- * chip.
- */
- ret = gpiod_request_commit(desc, "shared");
- if (ret)
- return ret;
-
- pr_debug("GPIO %u owned by %s is shared by multiple consumers\n",
- entry->offset, gpio_device_get_label(gdev));
- }
-
- list_for_each_entry(ref, &entry->refs, list) {
- pr_debug("Setting up a shared GPIO entry for %s (con_id: '%s')\n",
- fwnode_get_name(ref->fwnode) ?: "(no fwnode)",
- ref->con_id ?: "(none)");
-
- ret = gpio_shared_make_adev(gdev, entry, ref);
- if (ret) {
- gpiod_free_commit(desc);
- return ret;
- }
- }
+ ret = gpio_shared_setup_entry(gc, entry);
+ if (ret)
+ return ret;
}
return 0;
--
2.47.3
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v8 3/5] gpio: shared: unwind partial failures in gpiochip_setup_shared()
2026-10-29 16:22 [PATCH v8 0/5] gpio: shared: replace platform lookup with dummy software nodes Bartosz Golaszewski
2026-10-29 16:22 ` [PATCH v8 1/5] gpio: shared: factor out per-entry teardown helper Bartosz Golaszewski
2026-10-29 16:22 ` [PATCH v8 2/5] gpio: shared: factor out per-entry setup helper Bartosz Golaszewski
@ 2026-10-29 16:22 ` Bartosz Golaszewski
2026-10-29 16:52 ` sashiko-bot
2026-10-29 16:22 ` [PATCH v8 4/5] gpio: shared: detach the proxy device from struct gpio_shared_ref Bartosz Golaszewski
2026-10-29 16:22 ` [PATCH v8 5/5] gpio: shared: convert to using software nodes for GPIO shared proxy lookup Bartosz Golaszewski
4 siblings, 1 reply; 8+ messages in thread
From: Bartosz Golaszewski @ 2026-10-29 16:22 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Abel Vesa
Cc: linux-arm-msm, linux-gpio, linux-kernel, Bartosz Golaszewski
If gpio_shared_make_adev() fails for one of the references of a shared
GPIO entry, the auxiliary devices already registered for the preceding
references are never removed. Similarly, when setting up an entry fails,
the entries that were successfully set up before it keep their requested
descriptors and proxy devices, as the caller does not call
gpio_device_teardown_shared() when gpiochip_setup_shared() fails.
Make gpiochip_setup_shared() all-or-nothing. Have
gpio_shared_setup_entry() undo its own partial work: free the descriptor
and remove only the auxiliary devices of the references that precede the
failed one, so that no device is removed that was never registered. On
failure of an entry, tear down the previously completed entries in
reverse order using the same helper as the regular removal path.
Fixes: a060b8c511ab ("gpiolib: implement low-level, shared GPIO support")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
drivers/gpio/gpiolib-shared.c | 35 ++++++++++++++++++++++++++---------
1 file changed, 26 insertions(+), 9 deletions(-)
diff --git a/drivers/gpio/gpiolib-shared.c b/drivers/gpio/gpiolib-shared.c
index 47b434db72f1ebd35ec36ebdb35f30809f4522f2..043d5daba7a73062151a089b3ee8ccdac726f221 100644
--- a/drivers/gpio/gpiolib-shared.c
+++ b/drivers/gpio/gpiolib-shared.c
@@ -589,13 +589,25 @@ static int gpio_shared_setup_entry(struct gpio_chip *gc,
ref->con_id ?: "(none)");
ret = gpio_shared_make_adev(gdev, entry, ref);
- if (ret) {
- gpiod_free_commit(desc);
- return ret;
- }
+ if (ret)
+ goto err_out;
}
return 0;
+
+err_out:
+ gpiod_free_commit(desc);
+ list_for_each_entry_continue_reverse(ref, &entry->refs, list)
+ gpio_shared_remove_adev(&ref->adev);
+
+ return ret;
+}
+
+static bool gpio_shared_entry_needs_setup(struct gpio_device *gdev,
+ struct gpio_shared_entry *entry)
+{
+ return device_match_fwnode(&gdev->dev, entry->fwnode) &&
+ list_count_nodes(&entry->refs) > 1;
}
int gpiochip_setup_shared(struct gpio_chip *gc)
@@ -624,18 +636,23 @@ int gpiochip_setup_shared(struct gpio_chip *gc)
* exposing shared pins. Find them and create the proxy devices.
*/
list_for_each_entry(entry, &gpio_shared_list, list) {
- if (!device_match_fwnode(&gdev->dev, entry->fwnode))
- continue;
-
- if (list_count_nodes(&entry->refs) <= 1)
+ if (!gpio_shared_entry_needs_setup(gdev, entry))
continue;
ret = gpio_shared_setup_entry(gc, entry);
if (ret)
- return ret;
+ goto err_unwind;
}
return 0;
+
+err_unwind:
+ list_for_each_entry_continue_reverse(entry, &gpio_shared_list, list) {
+ if (gpio_shared_entry_needs_setup(gdev, entry))
+ gpio_shared_teardown_entry(gdev, entry);
+ }
+
+ return ret;
}
void gpio_device_teardown_shared(struct gpio_device *gdev)
--
2.47.3
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v8 3/5] gpio: shared: unwind partial failures in gpiochip_setup_shared()
2026-10-29 16:22 ` [PATCH v8 3/5] gpio: shared: unwind partial failures in gpiochip_setup_shared() Bartosz Golaszewski
@ 2026-10-29 16:52 ` sashiko-bot
0 siblings, 0 replies; 8+ messages in thread
From: sashiko-bot @ 2026-10-29 16:52 UTC (permalink / raw)
To: Bartosz Golaszewski; +Cc: linux-gpio
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] gpio: mix of scoped_guard() and goto cleanup in gpio_shared_setup_entry()
--
commit 2481d0c90c9615bb803575d8a0c1c3449eb188b0
Author: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
gpio: shared: unwind partial failures in gpiochip_setup_shared()
This patch updates gpio_shared_setup_entry() and gpiochip_setup_shared() to
unwind previously registered auxiliary devices and completed entries when a
partial failure occurs during setup.
> diff --git a/drivers/gpio/gpiolib-shared.c b/drivers/gpio/gpiolib-shared.c
> index 47b434db72f1e..043d5daba7a73 100644
> --- a/drivers/gpio/gpiolib-shared.c
> +++ b/drivers/gpio/gpiolib-shared.c
> @@ -589,13 +589,25 @@ static int gpio_shared_setup_entry(struct gpio_chip *gc,
> ref->con_id ?: "(none)");
>
> ret = gpio_shared_make_adev(gdev, entry, ref);
> - if (ret) {
> - gpiod_free_commit(desc);
> - return ret;
> - }
> + if (ret)
> + goto err_out;
> }
>
> return 0;
> +
> +err_out:
> + gpiod_free_commit(desc);
> + list_for_each_entry_continue_reverse(ref, &entry->refs, list)
> + gpio_shared_remove_adev(&ref->adev);
> +
> + return ret;
> +}
[Severity: Low]
This isn't a bug since the scoped_guard() block has already exited before the
loop, but include/linux/cleanup.h advises against mixing goto error handling
and scope-based cleanup helpers in the same function:
drivers/gpio/gpiolib-shared.c:gpio_shared_setup_entry() {
...
scoped_guard(mutex, &entry->lock) {
...
}
list_for_each_entry(ref, &entry->refs, list) {
...
ret = gpio_shared_make_adev(gdev, entry, ref);
if (ret)
goto err_out;
}
}
Since err_out only has a single caller when gpio_shared_make_adev() fails,
could the cleanup be kept inline inside the if (ret) block instead of adding a
goto label?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261029-gpio-shared-fwnode-lookup-v8-0-d15d75cd560f@oss.qualcomm.com?part=3
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v8 4/5] gpio: shared: detach the proxy device from struct gpio_shared_ref
2026-10-29 16:22 [PATCH v8 0/5] gpio: shared: replace platform lookup with dummy software nodes Bartosz Golaszewski
` (2 preceding siblings ...)
2026-10-29 16:22 ` [PATCH v8 3/5] gpio: shared: unwind partial failures in gpiochip_setup_shared() Bartosz Golaszewski
@ 2026-10-29 16:22 ` Bartosz Golaszewski
2026-10-29 16:22 ` [PATCH v8 5/5] gpio: shared: convert to using software nodes for GPIO shared proxy lookup Bartosz Golaszewski
4 siblings, 0 replies; 8+ messages in thread
From: Bartosz Golaszewski @ 2026-10-29 16:22 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Abel Vesa
Cc: linux-arm-msm, linux-gpio, linux-kernel, Bartosz Golaszewski
Sashiko reported a pre-existing issue with the reference-counted
auxiliary device being embedded in struct gpio_shared_ref. We
unconditionally memset() the struct when setting up the GPIO shared
proxy parent while there may still be references to it held by users.
While in practice this would never happen and sashiko seems to have
confused the parent auxiliary device and the separately allocated struct
device embedded in struct gpio_device, it's still a bad pattern and
could lead to memory corruption if a user deliberately took reference to
the auxiliary device via one of the lookup functions and kept it over
the GPIO parent's teardown.
Move the auxiliary device struct out of the shared reference structure
and allocate its memory separately on proxy setup.
Since we're already touching that field: change the name to something
more meaningful: it's more important to point out this is the proxy
device instead of indicating its type in the name.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
drivers/gpio/gpiolib-shared.c | 69 +++++++++++++++++++++++++++----------------
1 file changed, 43 insertions(+), 26 deletions(-)
diff --git a/drivers/gpio/gpiolib-shared.c b/drivers/gpio/gpiolib-shared.c
index 043d5daba7a73062151a089b3ee8ccdac726f221..c0e2a1207cccf16fe9fcf998eaf6ef744fe93eae 100644
--- a/drivers/gpio/gpiolib-shared.c
+++ b/drivers/gpio/gpiolib-shared.c
@@ -35,11 +35,10 @@ struct gpio_shared_ref {
/* GPIO flags this consumer uses for the request. */
enum gpiod_flags flags;
char *con_id;
- int dev_id;
/* Protects the auxiliary device struct and the lookup table. */
struct mutex lock;
struct lock_class_key lock_key;
- struct auxiliary_device adev;
+ struct auxiliary_device *proxy_dev;
struct gpiod_lookup_table *lookup;
bool is_reset_gpio;
};
@@ -94,10 +93,6 @@ static struct gpio_shared_ref *gpio_shared_make_ref(struct fwnode_handle *fwnode
return NULL;
}
- ref->dev_id = ida_alloc(&gpio_shared_ida, GFP_KERNEL);
- if (ref->dev_id < 0)
- return NULL;
-
ref->flags = flags;
ref->con_id = no_free_ptr(con_id_cpy);
ref->fwnode = fwnode;
@@ -306,31 +301,43 @@ static int gpio_shared_of_scan(void)
}
#endif /* CONFIG_OF */
-static void gpio_shared_adev_release(struct device *dev)
+static void gpio_shared_proxy_dev_release(struct device *dev)
{
+ struct auxiliary_device *adev = to_auxiliary_dev(dev);
+ ida_free(&gpio_shared_ida, adev->id);
+ kfree(adev);
}
-static int gpio_shared_make_adev(struct gpio_device *gdev,
- struct gpio_shared_entry *entry,
- struct gpio_shared_ref *ref)
+static int gpio_shared_make_proxy_dev(struct gpio_device *gdev,
+ struct gpio_shared_entry *entry,
+ struct gpio_shared_ref *ref)
{
- struct auxiliary_device *adev = &ref->adev;
- int ret;
+ struct auxiliary_device *adev;
+ int ret, id;
- guard(mutex)(&ref->lock);
+ adev = kzalloc_obj(*adev);
+ if (!adev)
+ return -ENOMEM;
- memset(adev, 0, sizeof(*adev));
+ id = ida_alloc(&gpio_shared_ida, GFP_KERNEL);
+ if (id < 0) {
+ kfree(adev);
+ return id;
+ }
- adev->id = ref->dev_id;
+ adev->id = id;
adev->name = "proxy";
adev->dev.parent = gdev->dev.parent;
adev->dev.platform_data = entry;
- adev->dev.release = gpio_shared_adev_release;
+ adev->dev.release = gpio_shared_proxy_dev_release;
ret = auxiliary_device_init(adev);
- if (ret)
+ if (ret) {
+ ida_free(&gpio_shared_ida, id);
+ kfree(adev);
return ret;
+ }
ret = auxiliary_device_add(adev);
if (ret) {
@@ -341,6 +348,10 @@ static int gpio_shared_make_adev(struct gpio_device *gdev,
pr_debug("Created an auxiliary GPIO proxy %s for GPIO device %s\n",
dev_name(&adev->dev), gpio_device_get_label(gdev));
+ scoped_guard(mutex, &ref->lock) {
+ ref->proxy_dev = adev;
+ }
+
return 0;
}
@@ -480,7 +491,7 @@ int gpio_shared_add_proxy_lookup(struct device *consumer, struct fwnode_handle *
char *key __free(kfree) =
kasprintf(GFP_KERNEL,
KBUILD_MODNAME ".proxy.%u",
- ref->adev.id);
+ ref->proxy_dev->id);
if (!key)
return -ENOMEM;
@@ -511,10 +522,17 @@ int gpio_shared_add_proxy_lookup(struct device *consumer, struct fwnode_handle *
return -ENOENT;
}
-static void gpio_shared_remove_adev(struct auxiliary_device *adev)
+static void gpio_shared_remove_proxy_dev(struct gpio_shared_ref *ref)
{
- auxiliary_device_delete(adev);
- auxiliary_device_uninit(adev);
+ struct auxiliary_device *proxy;
+
+ scoped_guard(mutex, &ref->lock) {
+ proxy = ref->proxy_dev;
+ ref->proxy_dev = NULL;
+ }
+
+ auxiliary_device_delete(proxy);
+ auxiliary_device_uninit(proxy);
}
static void gpio_shared_teardown_entry(struct gpio_device *gdev,
@@ -534,7 +552,7 @@ static void gpio_shared_teardown_entry(struct gpio_device *gdev,
ref->lookup = NULL;
}
- gpio_shared_remove_adev(&ref->adev);
+ gpio_shared_remove_proxy_dev(ref);
}
}
@@ -588,7 +606,7 @@ static int gpio_shared_setup_entry(struct gpio_chip *gc,
fwnode_get_name(ref->fwnode) ?: "(no fwnode)",
ref->con_id ?: "(none)");
- ret = gpio_shared_make_adev(gdev, entry, ref);
+ ret = gpio_shared_make_proxy_dev(gdev, entry, ref);
if (ret)
goto err_out;
}
@@ -598,7 +616,7 @@ static int gpio_shared_setup_entry(struct gpio_chip *gc,
err_out:
gpiod_free_commit(desc);
list_for_each_entry_continue_reverse(ref, &entry->refs, list)
- gpio_shared_remove_adev(&ref->adev);
+ gpio_shared_remove_proxy_dev(ref);
return ret;
}
@@ -619,7 +637,7 @@ int gpiochip_setup_shared(struct gpio_chip *gc)
list_for_each_entry(entry, &gpio_shared_list, list) {
list_for_each_entry(ref, &entry->refs, list) {
- if (gdev->dev.parent == &ref->adev.dev) {
+ if (ref->proxy_dev && gdev->dev.parent == &ref->proxy_dev->dev) {
/*
* This is a shared GPIO proxy. Mark its
* descriptor as such and return here.
@@ -756,7 +774,6 @@ static void gpio_shared_drop_ref(struct gpio_shared_ref *ref)
mutex_destroy(&ref->lock);
lockdep_unregister_key(&ref->lock_key);
kfree(ref->con_id);
- ida_free(&gpio_shared_ida, ref->dev_id);
fwnode_handle_put(ref->fwnode);
kfree(ref);
}
--
2.47.3
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v8 5/5] gpio: shared: convert to using software nodes for GPIO shared proxy lookup
2026-10-29 16:22 [PATCH v8 0/5] gpio: shared: replace platform lookup with dummy software nodes Bartosz Golaszewski
` (3 preceding siblings ...)
2026-10-29 16:22 ` [PATCH v8 4/5] gpio: shared: detach the proxy device from struct gpio_shared_ref Bartosz Golaszewski
@ 2026-10-29 16:22 ` Bartosz Golaszewski
2026-10-29 17:12 ` sashiko-bot
4 siblings, 1 reply; 8+ messages in thread
From: Bartosz Golaszewski @ 2026-10-29 16:22 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Abel Vesa
Cc: linux-arm-msm, linux-gpio, linux-kernel, Bartosz Golaszewski
Automated management of shared GPIOs only allows to request shared pins
when they're assigned to a real struct device. Firmware node, no-device
lookup currently isn't supported and can't be because we're using
platform lookup tables to point the callers to the shared proxy GPIO
controllers.
Rework the GPIO sharing by using dummy software nodes assigned to the
proxy devices and stored in the reference structures which allow us -
once the correct struct gpio_shared_ref is found - to find the correct
target GPIO device by its firmware node.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
drivers/gpio/gpiolib-shared.c | 152 ++++++++++++++++++++++--------------------
drivers/gpio/gpiolib-shared.h | 15 ++---
drivers/gpio/gpiolib.c | 20 +-----
3 files changed, 90 insertions(+), 97 deletions(-)
diff --git a/drivers/gpio/gpiolib-shared.c b/drivers/gpio/gpiolib-shared.c
index c0e2a1207cccf16fe9fcf998eaf6ef744fe93eae..75529336c6cd9c97210d6afed9180f686014da8c 100644
--- a/drivers/gpio/gpiolib-shared.c
+++ b/drivers/gpio/gpiolib-shared.c
@@ -27,6 +27,12 @@
#include "gpiolib.h"
#include "gpiolib-shared.h"
+struct gpio_shared_proxy {
+ struct auxiliary_device aux;
+ struct software_node swnode;
+ struct fwnode_handle *fwnode;
+};
+
/* Represents a single reference to a GPIO pin. */
struct gpio_shared_ref {
struct list_head list;
@@ -35,11 +41,10 @@ struct gpio_shared_ref {
/* GPIO flags this consumer uses for the request. */
enum gpiod_flags flags;
char *con_id;
- /* Protects the auxiliary device struct and the lookup table. */
+ /* Protects the auxiliary device struct and fwnode. */
struct mutex lock;
+ struct gpio_shared_proxy *proxy;
struct lock_class_key lock_key;
- struct auxiliary_device *proxy_dev;
- struct gpiod_lookup_table *lookup;
bool is_reset_gpio;
};
@@ -304,43 +309,62 @@ static int gpio_shared_of_scan(void)
static void gpio_shared_proxy_dev_release(struct device *dev)
{
struct auxiliary_device *adev = to_auxiliary_dev(dev);
+ struct gpio_shared_proxy *proxy = container_of(adev,
+ struct gpio_shared_proxy, aux);
ida_free(&gpio_shared_ida, adev->id);
- kfree(adev);
+ kfree(proxy);
}
static int gpio_shared_make_proxy_dev(struct gpio_device *gdev,
struct gpio_shared_entry *entry,
struct gpio_shared_ref *ref)
{
+ struct gpio_shared_proxy *proxy;
struct auxiliary_device *adev;
+ struct software_node *swnode;
+ struct device *dev;
int ret, id;
- adev = kzalloc_obj(*adev);
- if (!adev)
+ proxy = kzalloc_obj(*proxy);
+ if (!proxy)
return -ENOMEM;
+ adev = &proxy->aux;
+ swnode = &proxy->swnode;
+
id = ida_alloc(&gpio_shared_ida, GFP_KERNEL);
if (id < 0) {
- kfree(adev);
- return id;
+ ret = id;
+ goto err_free_proxy;
}
+ ret = software_node_register(swnode);
+ if (ret)
+ goto err_free_ida;
+
+ proxy->fwnode = software_node_fwnode(swnode);
+ if (!proxy->fwnode) {
+ ret = -ENODEV;
+ goto err_swnode_unreg;
+ }
+
+ dev = &adev->dev;
adev->id = id;
adev->name = "proxy";
- adev->dev.parent = gdev->dev.parent;
- adev->dev.platform_data = entry;
- adev->dev.release = gpio_shared_proxy_dev_release;
+ dev->parent = gdev->dev.parent;
+ dev->platform_data = entry;
+ dev->release = gpio_shared_proxy_dev_release;
+
+ device_set_node(dev, proxy->fwnode);
ret = auxiliary_device_init(adev);
- if (ret) {
- ida_free(&gpio_shared_ida, id);
- kfree(adev);
- return ret;
- }
+ if (ret)
+ goto err_swnode_unreg;
ret = auxiliary_device_add(adev);
if (ret) {
+ software_node_unregister(swnode);
auxiliary_device_uninit(adev);
return ret;
}
@@ -349,10 +373,19 @@ static int gpio_shared_make_proxy_dev(struct gpio_device *gdev,
dev_name(&adev->dev), gpio_device_get_label(gdev));
scoped_guard(mutex, &ref->lock) {
- ref->proxy_dev = adev;
+ ref->proxy = proxy;
}
return 0;
+
+err_swnode_unreg:
+ software_node_unregister(swnode);
+err_free_ida:
+ ida_free(&gpio_shared_ida, id);
+err_free_proxy:
+ kfree(proxy);
+
+ return ret;
}
#if IS_ENABLED(CONFIG_RESET_GPIO)
@@ -457,23 +490,19 @@ static bool gpio_shared_dev_is_reset_gpio(struct device *consumer,
}
#endif /* CONFIG_RESET_GPIO */
-int gpio_shared_add_proxy_lookup(struct device *consumer, struct fwnode_handle *fwnode,
- const char *con_id, unsigned long lflags)
+struct gpio_desc *
+gpio_shared_get_proxy(struct device *consumer, struct fwnode_handle *fwnode,
+ const char *con_id)
{
struct gpio_shared_entry *entry;
struct gpio_shared_ref *ref;
- const char *dev_id;
-
- if (!consumer)
- return -EOPNOTSUPP;
-
- dev_id = dev_name(consumer);
list_for_each_entry(entry, &gpio_shared_list, list) {
list_for_each_entry(ref, &entry->refs, list) {
guard(mutex)(&ref->lock);
- if (!ref->fwnode && device_is_compatible(consumer, "reset-gpio")) {
+ if (!ref->fwnode && consumer &&
+ device_is_compatible(consumer, "reset-gpio")) {
if (!gpio_shared_dev_is_reset_gpio(consumer, entry, ref))
continue;
} else if (fwnode != ref->fwnode) {
@@ -484,55 +513,45 @@ int gpio_shared_add_proxy_lookup(struct device *consumer, struct fwnode_handle *
(con_id && ref->con_id && strcmp(con_id, ref->con_id) != 0))
continue;
- /* We've already done that on a previous request. */
- if (ref->lookup)
- return 0;
-
- char *key __free(kfree) =
- kasprintf(GFP_KERNEL,
- KBUILD_MODNAME ".proxy.%u",
- ref->proxy_dev->id);
- if (!key)
- return -ENOMEM;
-
- struct gpiod_lookup_table *lookup __free(kfree) =
- kzalloc_flex(*lookup, table, 2);
- if (!lookup)
- return -ENOMEM;
-
- pr_debug("Adding machine lookup entry for a shared GPIO for consumer %s, with key '%s' and con_id '%s'\n",
- dev_id, key, ref->con_id ?: "none");
-
- lookup->dev_id = kstrdup(dev_id, GFP_KERNEL);
- if (!lookup->dev_id)
- return -ENOMEM;
-
- lookup->table[0] = GPIO_LOOKUP(no_free_ptr(key), 0,
- ref->con_id, lflags);
+ if (!ref->proxy || !ref->proxy->fwnode)
+ /*
+ * There's a matching shared reference but the
+ * associated auxiliary device has not been
+ * created yet.
+ */
+ return ERR_PTR(-EPROBE_DEFER);
- ref->lookup = no_free_ptr(lookup);
- gpiod_add_lookup_table(ref->lookup);
+ struct gpio_device *gdev __free(gpio_device_put) =
+ gpio_device_find_by_fwnode(ref->proxy->fwnode);
+ if (!gdev)
+ /*
+ * There's a matching shared reference but the
+ * associated GPIO controller has not been
+ * registered yet.
+ */
+ return ERR_PTR(-EPROBE_DEFER);
- return 0;
+ return gpio_device_get_desc(gdev, 0);
}
}
/* We warn here because this can only happen if the programmer borked. */
WARN_ON(1);
- return -ENOENT;
+ return ERR_PTR(-ENOENT);
}
static void gpio_shared_remove_proxy_dev(struct gpio_shared_ref *ref)
{
- struct auxiliary_device *proxy;
+ struct gpio_shared_proxy *proxy;
scoped_guard(mutex, &ref->lock) {
- proxy = ref->proxy_dev;
- ref->proxy_dev = NULL;
+ proxy = ref->proxy;
+ ref->proxy = NULL;
+ software_node_unregister(&proxy->swnode);
}
- auxiliary_device_delete(proxy);
- auxiliary_device_uninit(proxy);
+ auxiliary_device_delete(&proxy->aux);
+ auxiliary_device_uninit(&proxy->aux);
}
static void gpio_shared_teardown_entry(struct gpio_device *gdev,
@@ -543,17 +562,8 @@ static void gpio_shared_teardown_entry(struct gpio_device *gdev,
scoped_guard(mutex, &entry->lock)
gpiod_free_commit(&gdev->descs[entry->offset]);
- list_for_each_entry(ref, &entry->refs, list) {
- if (ref->lookup) {
- gpiod_remove_lookup_table(ref->lookup);
- kfree(ref->lookup->table[0].key);
- kfree(ref->lookup->dev_id);
- kfree(ref->lookup);
- ref->lookup = NULL;
- }
-
+ list_for_each_entry(ref, &entry->refs, list)
gpio_shared_remove_proxy_dev(ref);
- }
}
static int gpio_shared_setup_entry(struct gpio_chip *gc,
@@ -637,7 +647,7 @@ int gpiochip_setup_shared(struct gpio_chip *gc)
list_for_each_entry(entry, &gpio_shared_list, list) {
list_for_each_entry(ref, &entry->refs, list) {
- if (ref->proxy_dev && gdev->dev.parent == &ref->proxy_dev->dev) {
+ if (ref->proxy && gdev->dev.parent == &ref->proxy->aux.dev) {
/*
* This is a shared GPIO proxy. Mark its
* descriptor as such and return here.
diff --git a/drivers/gpio/gpiolib-shared.h b/drivers/gpio/gpiolib-shared.h
index 618756f6c6aafd087df267a4a32732ccc03af38e..27fd2a40c5cb77a19c258e3fbf429d3f6e7d4b32 100644
--- a/drivers/gpio/gpiolib-shared.h
+++ b/drivers/gpio/gpiolib-shared.h
@@ -14,9 +14,9 @@ struct fwnode_handle;
int gpiochip_setup_shared(struct gpio_chip *gc);
void gpio_device_teardown_shared(struct gpio_device *gdev);
-int gpio_shared_add_proxy_lookup(struct device *consumer,
- struct fwnode_handle *fwnode,
- const char *con_id, unsigned long lflags);
+struct gpio_desc *
+gpio_shared_get_proxy(struct device *consumer, struct fwnode_handle *fwnode,
+ const char *con_id);
#else
@@ -27,12 +27,11 @@ static inline int gpiochip_setup_shared(struct gpio_chip *gc)
static inline void gpio_device_teardown_shared(struct gpio_device *gdev) { }
-static inline int gpio_shared_add_proxy_lookup(struct device *consumer,
- struct fwnode_handle *fwnode,
- const char *con_id,
- unsigned long lflags)
+static inline struct gpio_desc *
+gpio_shared_get_proxy(struct device *consumer, struct fwnode_handle *fwnode,
+ const char *con_id)
{
- return 0;
+ return NULL;
}
#endif /* CONFIG_GPIO_SHARED */
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index fbdeda2f278713a47c2e3d2a6640f387f6d92227..402de2e106f19fd110d67eeecd3c07794b7a5cdd 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -4841,24 +4841,8 @@ struct gpio_desc *gpiod_find_and_request(struct device *consumer,
scoped_guard(srcu, &gpio_devices_srcu) {
desc = gpiod_fwnode_lookup(fwnode, consumer, con_id, idx,
&flags, &lookupflags);
- if (!IS_ERR_OR_NULL(desc) &&
- test_bit(GPIOD_FLAG_SHARED, &desc->flags)) {
- /*
- * We're dealing with a GPIO shared by multiple
- * consumers. This is the moment to add the machine
- * lookup table for the proxy device as previously
- * we only knew the consumer's fwnode.
- */
- ret = gpio_shared_add_proxy_lookup(consumer, fwnode,
- con_id, lookupflags);
- if (ret)
- return ERR_PTR(ret);
-
- /* Trigger platform lookup for shared GPIO proxy. */
- desc = ERR_PTR(-ENOENT);
- /* Trigger it even for fwnode-only gpiod_get(). */
- platform_lookup_allowed = true;
- }
+ if (!IS_ERR_OR_NULL(desc) && test_bit(GPIOD_FLAG_SHARED, &desc->flags))
+ desc = gpio_shared_get_proxy(consumer, fwnode, con_id);
if (gpiod_not_found(desc) && platform_lookup_allowed) {
/*
--
2.47.3
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v8 5/5] gpio: shared: convert to using software nodes for GPIO shared proxy lookup
2026-10-29 16:22 ` [PATCH v8 5/5] gpio: shared: convert to using software nodes for GPIO shared proxy lookup Bartosz Golaszewski
@ 2026-10-29 17:12 ` sashiko-bot
0 siblings, 0 replies; 8+ messages in thread
From: sashiko-bot @ 2026-10-29 17:12 UTC (permalink / raw)
To: Bartosz Golaszewski; +Cc: linux-gpio
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Critical] gpio: shared: use-after-free from embedding software_node in gpio_shared_proxy
- [Critical] gpio: shared: use-after-free from premature software_node_unregister()
--
commit 0a2fa40980d92969568b8b100eb268910f6d88f6
Author: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
gpio: shared: convert to using software nodes for GPIO shared proxy lookup
This commit replaces platform GPIO lookup tables with dummy software nodes
assigned to shared proxy auxiliary devices so that shared GPIO descriptors
can be looked up by firmware node even when no consumer device is present.
> diff --git a/drivers/gpio/gpiolib-shared.c b/drivers/gpio/gpiolib-shared.c
> index c0e2a1207cccf..75529336c6cd9 100644
> --- a/drivers/gpio/gpiolib-shared.c
> +++ b/drivers/gpio/gpiolib-shared.c
> @@ -27,6 +27,12 @@
> #include "gpiolib.h"
> #include "gpiolib-shared.h"
>
> +struct gpio_shared_proxy {
> + struct auxiliary_device aux;
> + struct software_node swnode;
> + struct fwnode_handle *fwnode;
> +};
[ ... ]
> @@ -304,43 +309,62 @@ static int gpio_shared_of_scan(void)
> static void gpio_shared_proxy_dev_release(struct device *dev)
> {
> struct auxiliary_device *adev = to_auxiliary_dev(dev);
> + struct gpio_shared_proxy *proxy = container_of(adev,
> + struct gpio_shared_proxy, aux);
>
> ida_free(&gpio_shared_ida, adev->id);
> - kfree(adev);
> + kfree(proxy);
> }
>
> static int gpio_shared_make_proxy_dev(struct gpio_device *gdev,
> struct gpio_shared_entry *entry,
> struct gpio_shared_ref *ref)
> {
> + struct gpio_shared_proxy *proxy;
> struct auxiliary_device *adev;
> + struct software_node *swnode;
> + struct device *dev;
> int ret, id;
>
> - adev = kzalloc_obj(*adev);
> - if (!adev)
> + proxy = kzalloc_obj(*proxy);
> + if (!proxy)
> return -ENOMEM;
>
> + adev = &proxy->aux;
> + swnode = &proxy->swnode;
> +
> id = ida_alloc(&gpio_shared_ida, GFP_KERNEL);
> if (id < 0) {
> - kfree(adev);
> - return id;
> + ret = id;
> + goto err_free_proxy;
> }
>
> + ret = software_node_register(swnode);
> + if (ret)
> + goto err_free_ida;
[Severity: Critical]
Does embedding struct software_node inside struct gpio_shared_proxy and
registering it with software_node_register() introduce a use-after-free
regression when the proxy device is released?
In drivers/base/swnode.c, software_node_register() -> swnode_register()
creates a separately reference-counted struct swnode kobject on
swnode_kset->list with swnode->allocated = 0 and stores the raw pointer
swnode->node = &proxy->swnode:
drivers/base/swnode.c:swnode_register() {
...
swnode->node = node;
swnode->parent = parent;
swnode->allocated = allocated;
swnode->kobj.kset = swnode_kset;
...
}
Because struct swnode does not hold a reference to proxy->aux.dev, when
gpio_shared_remove_proxy_dev() or the auxiliary_device_add() error path in
gpio_shared_make_proxy_dev() calls auxiliary_device_uninit(&proxy->aux),
put_device(&proxy->aux.dev) triggers gpio_shared_proxy_dev_release() and
immediately executes kfree(proxy).
If swnode->kobj outlives proxy->aux.dev (for example, due to an active
fwnode_handle_get() reference, an open sysfs attribute under
/sys/kernel/software_nodes/, or delayed kobject release), swnode->node
becomes a dangling pointer into the freed proxy slab while swnode remains
linked in swnode_kset->list. Subsequent calls to
software_node_to_swnode(), software_node_find_by_name(),
software_node_register(), to_software_node(), or fwnode property accessors
will then dereference freed memory, and a new struct gpio_shared_proxy
allocated at the same address can fail software_node_register() with
-EEXIST.
Would using fwnode_create_software_node(NULL, NULL) and
fwnode_remove_software_node() (which sets swnode->allocated = 1 so the
software_node is freed in software_node_release() when swnode->kobj reaches
zero references), or matching the proxy gpio_device directly via
gdev->dev.parent == &ref->proxy->aux.dev, avoid tying the software_node
backing memory to the auxiliary_device release callback?
[ ... ]
> @@ -515,18 +534,27 @@ int gpio_shared_add_proxy_lookup(struct device *consumer, struct fwnode_handle *
> static void gpio_shared_remove_proxy_dev(struct gpio_shared_ref *ref)
> {
> - struct auxiliary_device *proxy;
> + struct gpio_shared_proxy *proxy;
>
> scoped_guard(mutex, &ref->lock) {
> - proxy = ref->proxy_dev;
> - ref->proxy_dev = NULL;
> + proxy = ref->proxy;
> + ref->proxy = NULL;
> + software_node_unregister(&proxy->swnode);
> }
>
> - auxiliary_device_delete(proxy);
> - auxiliary_device_uninit(proxy);
> + auxiliary_device_delete(&proxy->aux);
> + auxiliary_device_uninit(&proxy->aux);
> }
[Severity: Critical]
Can calling software_node_unregister(&proxy->swnode) before
auxiliary_device_delete(&proxy->aux) cause a use-after-free in
software_node_notify_remove()?
In gpio_shared_make_proxy_dev(), software_node_register() creates the
struct swnode with an initial kref of 1 and attaches &swnode->fwnode as the
primary fwnode of proxy->aux.dev via device_set_node(). When
auxiliary_device_add() calls device_add(&adev->dev), software_node_notify()
increments the swnode kref to 2, and when the gpio-shared-proxy driver binds
and registers its child gpio_device (which inherits gc->parent->fwnode in
gpiochip_add_data_with_key()), software_node_notify(&gdev->dev) increments
the swnode kref to 3.
In gpio_shared_remove_proxy_dev(), software_node_unregister(&proxy->swnode)
is called while both devices are still registered, dropping the initial
creation reference first (from 3 to 2, or from 2 to 1 if the driver was not
bound).
When auxiliary_device_delete(&proxy->aux) then calls
device_del(&proxy->aux.dev):
1. bus_remove_device() unbinds gpio-shared-proxy and deletes gdev->dev,
where software_node_notify_remove(&gdev->dev) drops the swnode kref from
2 to 1.
2. device_platform_notify_remove(&proxy->aux.dev) calls
software_node_notify_remove(&proxy->aux.dev), which drops the final
reference from 1 to 0 in swnode_put(swnode), freeing struct swnode via
software_node_release(), and then immediately reads swnode->managed from
the freed struct swnode:
drivers/base/swnode.c:software_node_notify_remove() {
...
swnode_put(swnode);
if (swnode->managed) {
set_secondary_fwnode(dev, NULL);
swnode_put(swnode);
}
}
In addition, because device_del() does not clear dev->fwnode, both
proxy->aux.dev.fwnode and gdev->dev.fwnode remain dangling pointers to the
freed struct swnode for any remaining lifetime of those struct device
instances (such as when a consumer still holds a gpio_desc or /dev/gpiochipN
is open).
Should the software node only be unregistered after the devices using it
have been deleted or released?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261029-gpio-shared-fwnode-lookup-v8-0-d15d75cd560f@oss.qualcomm.com?part=5
^ permalink raw reply [flat|nested] 8+ messages in thread