[PATCH] ax25 Locking fix

[PATCH] ax25 Locking fix

[Jeroen Vreeken]

[-- Attachment #1: Type: text/plain, Size: 125 bytes --]

Hi,

This is a oneliner for 2.6 changing an unlock into a lock.
This prevents an oops on removal of the ax25 module.

Jeroen

[-- Attachment #2: ax25.2.6.1.rxq3.diff --]
[-- Type: application/octet-stream, Size: 371 bytes --]

--- linux-2.6.1.org/net/ax25/ax25_route.c	2004-01-09 07:59:46.000000000 +0100
+++ linux-2.6.1-rxq3/net/ax25/ax25_route.c	2004-02-12 20:14:31.000000000 +0100
@@ -535,7 +535,7 @@
 {
 	ax25_route *s, *ax25_rt = ax25_route_list;
 
-	write_unlock(&ax25_route_lock);
+	write_lock(&ax25_route_lock);
 	while (ax25_rt != NULL) {
 		s       = ax25_rt;
 		ax25_rt = ax25_rt->next;

Re: [PATCH] ax25 Locking fix

[Bernard Pidoux]

Hi,

Is there any chance that you could have a look at rose.o module code in 
order to fix a kernel panic problem.
If rose module is just installed it can be removed and reinstalled 
without problem.
But as soon as I do "ifconfig rose0 2080175502" I have a kernel panic.
Also if I perform a rsattach and try to remove the module then I have a 
kernel oops.

Once I had the chance to catch this message from syslog@f6bvp
   (f6bvp is the actual name of my Linux machine):

f6bvp kernel : unregister_net_device : wainting for rose0 to become 
free. Usage count  =1
repeats x times ...

and then I observed a catastrophic PC reboot.

73 de Bernard, f6bvp

----------------------------

Jeroen Vreeken wrote:
> Hi,
> 
> This is a oneliner for 2.6 changing an unlock into a lock.
> This prevents an oops on removal of the ax25 module.
> 
> Jeroen


de Bernard, f6bvp

Re: [PATCH] ax25 Locking fix

[Ralf Baechle DO1GRB]

On Sat, Feb 14, 2004 at 12:18:22AM +0000, Bernard Pidoux wrote:

> Is there any chance that you could have a look at rose.o module code in 
> order to fix a kernel panic problem.
> If rose module is just installed it can be removed and reinstalled 
> without problem.
> But as soon as I do "ifconfig rose0 2080175502" I have a kernel panic.
> Also if I perform a rsattach and try to remove the module then I have a 
> kernel oops.

I assume you meant "ifconfig rose0 hw rose 2080175502"?  Without the
"hw rose" it's just an obscure way to set the ip address to 12.104.129.142.

> Once I had the chance to catch this message from syslog@f6bvp
>   (f6bvp is the actual name of my Linux machine):
> 
> f6bvp kernel : unregister_net_device : wainting for rose0 to become 
> free. Usage count  =1
> repeats x times ...
> 
> and then I observed a catastrophic PC reboot.

Sounds like a problem with reference counting, can't be hard to fix.

  Ralf

Re: [PATCH] ax25 Locking fix

[David S. Miller]

On Fri, 13 Feb 2004 23:48:06 +0100
Jeroen Vreeken <pe1rxq@amsat.org> wrote:

> This is a oneliner for 2.6 changing an unlock into a lock.
> This prevents an oops on removal of the ax25 module.

Durrr, thanks for the fix Jeroen.

Patch applied.