* [PATCH 02/12] headers, ax25: Add missing #include to <linux/netrom.h>, <linux/rose.h> [not found] <1312809302.2591.1139.camel@deadeye> @ 2011-08-08 13:17 ` Ben Hutchings 2011-08-08 14:07 ` Ralf Baechle 2011-08-08 13:24 ` [PATCH 11/12] headers, scc: Add missing #include to <linux/scc.h> Ben Hutchings 1 sibling, 1 reply; 5+ messages in thread From: Ben Hutchings @ 2011-08-08 13:17 UTC (permalink / raw) To: David Miller; +Cc: netdev, Ralf Baechle, linux-hams These headers use the ax25_address type defined in <linux/ax25.h>. Signed-off-by: Ben Hutchings <ben@decadent.org.uk> --- include/linux/netrom.h | 2 ++ include/linux/rose.h | 2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/include/linux/netrom.h b/include/linux/netrom.h index 6939b32..af7313c 100644 --- a/include/linux/netrom.h +++ b/include/linux/netrom.h @@ -7,6 +7,8 @@ #ifndef NETROM_KERNEL_H #define NETROM_KERNEL_H +#include <linux/ax25.h> + #define NETROM_MTU 236 #define NETROM_T1 1 diff --git a/include/linux/rose.h b/include/linux/rose.h index c7b4b18..e8289cd 100644 --- a/include/linux/rose.h +++ b/include/linux/rose.h @@ -7,6 +7,8 @@ #ifndef ROSE_KERNEL_H #define ROSE_KERNEL_H +#include <linux/ax25.h> + #define ROSE_MTU 251 #define ROSE_MAX_DIGIS 6 -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 02/12] headers, ax25: Add missing #include to <linux/netrom.h>, <linux/rose.h> 2011-08-08 13:17 ` [PATCH 02/12] headers, ax25: Add missing #include to <linux/netrom.h>, <linux/rose.h> Ben Hutchings @ 2011-08-08 14:07 ` Ralf Baechle 0 siblings, 0 replies; 5+ messages in thread From: Ralf Baechle @ 2011-08-08 14:07 UTC (permalink / raw) To: Ben Hutchings; +Cc: David Miller, netdev, linux-hams On Mon, Aug 08, 2011 at 02:17:20PM +0100, Ben Hutchings wrote: > These headers use the ax25_address type defined in <linux/ax25.h>. > > Signed-off-by: Ben Hutchings <ben@decadent.org.uk> Makes sense. Acked-by: Ralf Baechle <ralf@linux-mips.org> Ralf ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 11/12] headers, scc: Add missing #include to <linux/scc.h> [not found] <1312809302.2591.1139.camel@deadeye> 2011-08-08 13:17 ` [PATCH 02/12] headers, ax25: Add missing #include to <linux/netrom.h>, <linux/rose.h> Ben Hutchings @ 2011-08-08 13:24 ` Ben Hutchings 2011-08-08 18:20 ` Ben Hutchings 1 sibling, 1 reply; 5+ messages in thread From: Ben Hutchings @ 2011-08-08 13:24 UTC (permalink / raw) To: David Miller; +Cc: netdev, Joerg Reuter, Klaus Kudielka, linux-hams <linux/scc.h> uses SIOCDEVPRIVATE, defined in <linux/sockios.h>. Signed-off-by: Ben Hutchings <ben@decadent.org.uk> --- This file isn't listed in MAINTAINERS but appears to be associated with one of the hamradio drivers; please could one of the hams claim it? Ben. include/linux/scc.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/scc.h b/include/linux/scc.h index 3495bd9..d5916e5 100644 --- a/include/linux/scc.h +++ b/include/linux/scc.h @@ -3,6 +3,7 @@ #ifndef _SCC_H #define _SCC_H +#include <linux/sockios.h> /* selection of hardware types */ -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 11/12] headers, scc: Add missing #include to <linux/scc.h> 2011-08-08 13:24 ` [PATCH 11/12] headers, scc: Add missing #include to <linux/scc.h> Ben Hutchings @ 2011-08-08 18:20 ` Ben Hutchings 2011-08-09 7:14 ` walter harms 0 siblings, 1 reply; 5+ messages in thread From: Ben Hutchings @ 2011-08-08 18:20 UTC (permalink / raw) To: David Miller; +Cc: netdev, Joerg Reuter, Klaus Kudielka, linux-hams On Mon, Aug 08, 2011 at 02:24:29PM +0100, Ben Hutchings wrote: > <linux/scc.h> uses SIOCDEVPRIVATE, defined in <linux/sockios.h>. Unfortunately SIOCDEVPRIVATE is also defined elsewhere by glibc, so including <linux/sockios.h> can result in duplicate definitions. So I don't think we can make this change. Ben. > Signed-off-by: Ben Hutchings <ben@decadent.org.uk> > --- > This file isn't listed in MAINTAINERS but appears to be associated with > one of the hamradio drivers; please could one of the hams claim it? > > Ben. > > include/linux/scc.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/linux/scc.h b/include/linux/scc.h > index 3495bd9..d5916e5 100644 > --- a/include/linux/scc.h > +++ b/include/linux/scc.h > @@ -3,6 +3,7 @@ > #ifndef _SCC_H > #define _SCC_H > > +#include <linux/sockios.h> > > /* selection of hardware types */ > > -- > 1.7.5.4 > > > -- Ben Hutchings We get into the habit of living before acquiring the habit of thinking. - Albert Camus ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 11/12] headers, scc: Add missing #include to <linux/scc.h> 2011-08-08 18:20 ` Ben Hutchings @ 2011-08-09 7:14 ` walter harms 0 siblings, 0 replies; 5+ messages in thread From: walter harms @ 2011-08-09 7:14 UTC (permalink / raw) To: Ben Hutchings Cc: David Miller, netdev, Joerg Reuter, Klaus Kudielka, linux-hams Am 08.08.2011 20:20, schrieb Ben Hutchings: > On Mon, Aug 08, 2011 at 02:24:29PM +0100, Ben Hutchings wrote: >> <linux/scc.h> uses SIOCDEVPRIVATE, defined in <linux/sockios.h>. > > Unfortunately SIOCDEVPRIVATE is also defined elsewhere by glibc, > so including <linux/sockios.h> can result in duplicate definitions. > So I don't think we can make this change. > Maybe that is something the glibc and the kernel guys should know about. Did someone tell them ? Is that problem documented somewhere ? re, wh > Ben. > >> Signed-off-by: Ben Hutchings <ben@decadent.org.uk> >> --- >> This file isn't listed in MAINTAINERS but appears to be associated with >> one of the hamradio drivers; please could one of the hams claim it? >> >> Ben. >> >> include/linux/scc.h | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/include/linux/scc.h b/include/linux/scc.h >> index 3495bd9..d5916e5 100644 >> --- a/include/linux/scc.h >> +++ b/include/linux/scc.h >> @@ -3,6 +3,7 @@ >> #ifndef _SCC_H >> #define _SCC_H >> >> +#include <linux/sockios.h> >> >> /* selection of hardware types */ >> >> -- >> 1.7.5.4 >> >> >> > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-08-09 7:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1312809302.2591.1139.camel@deadeye>
2011-08-08 13:17 ` [PATCH 02/12] headers, ax25: Add missing #include to <linux/netrom.h>, <linux/rose.h> Ben Hutchings
2011-08-08 14:07 ` Ralf Baechle
2011-08-08 13:24 ` [PATCH 11/12] headers, scc: Add missing #include to <linux/scc.h> Ben Hutchings
2011-08-08 18:20 ` Ben Hutchings
2011-08-09 7:14 ` walter harms
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox