Linux HAM/Amateur Radio development
 help / color / mirror / Atom feed
* [BUG] ax25-tools-0.0.10-rc2 : no netrom device attached
@ 2009-10-25 10:26 Bernard Pidoux F6BVP
  0 siblings, 0 replies; only message in thread
From: Bernard Pidoux F6BVP @ 2009-10-25 10:26 UTC (permalink / raw)
  To: Linux Hams; +Cc: Ralf Baechle DL5RB, ax25

Hi,

nrattach does not create any nr# device despite a success message :

ax25-tools-0.0.10-rc2]# netrom/nrattach -m 236 netbbs
NET/ROM port netbbs bound to device nr2

ifconfig does not show any nr device !

Investigating nrattach source file revealed that a conditional compile
instruction was added.

Actually, #ifdef instruction included in nrattach.c prevents 
a call to startiface() funtion to be compiled.
This is because "notdef" is actually not defined by default.

I don't know exactly why this was added in nrattach source file but,
to keep backward compatibility with previous versions, the proposition
should be reversed, i.e. #ifdef replaced by #ifndef. 

The new code would look like the following :

#ifndef notdef
	if (!startiface(dev, hp))
		return 1;		
#endif
	printf("NET/ROM port %s bound to device %s\n", argv[optind], dev);

However, if notdef is defined somewhere, there will be again no netrom device
created, but a false success message will still be displayed.

I don't really understand the purpose of this.

73 de Bernard, f6bvp

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-10-25 10:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-25 10:26 [BUG] ax25-tools-0.0.10-rc2 : no netrom device attached Bernard Pidoux F6BVP

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox