public inbox for linux-hams@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfbbd:  Fix issue with xfbbd and AX25 radio connections
@ 2010-11-14 18:58 Bernard Pidoux
  2013-07-05 21:20 ` [PATCH] xfbbd: Run the same data files on 64-bit Cathryn Mataga
  0 siblings, 1 reply; 6+ messages in thread
From: Bernard Pidoux @ 2010-11-14 18:58 UTC (permalink / raw)
  To: Cathryn Mataga, linux-hams

Hi Cathryn,

Many thanks for the patches.
I had noticed the SIGPIPE bug when in GDB session.
However xfbbd did not fail usually when not under GDB.
Anyway, its nice you cured the problem.
Other bugs were also very annoying and I am gratefull that
your perspicacy found the reasons I did not discovered.

I applied your patch into new FBB pre release xd704r12.

http://f6bvp.free.fr/logiciels/BBS-f6fbb/xd704r12-src.tar.bz2

See CHANGES file for important notices about the use of xfbbd
on 64 bits and SMP systems.

73s de Bernard, f6bvp



>Patch versus version xfbbd version r11
>
>Same patch file, Except I changed the email subject.
>
>
>
>1. SOCK_MAXCHAN (drv_sock.c) now set to (MAXVOIES)  This was set to 50, which was less than MAXVOIES, and the code was
>accessing data off the end of this table.  This was causing strange problems.  After I made this change the gateway
>function started working again.  If anyone was having trouble with xfbbd and RF radio connections, this change may
>possibly fix their problem.
>2.  Several minor changes designed to eliminate "Bad file descriptor" error messages.  These occurred at the time
>of housekeeping due to a minor bug.  The messages actually turned out to be harmless, as far as I can tell.
>3.  Only use the signal handler for signals that have functionality in the code.  This is a simplification
>to prevent bugs.  Other signals are set to SIG_IGN.




^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH 4/11] drivers/net/hamradio: Eliminate a NULL pointer dereference
@ 2010-05-27 12:33 Julia Lawall
  2010-05-27 23:29 ` David Miller
  0 siblings, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2010-05-27 12:33 UTC (permalink / raw)
  To: Jean-Paul Roubelat, linux-hams, netdev, linux-kernel,
	kernel-janitors

From: Julia Lawall <julia@diku.dk>

At the point of the print, dev is NULL.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression E,E1;
identifier f;
statement S1,S2,S3;
@@

if ((E == NULL && ...) || ...)
{
  ... when != if (...) S1 else S2
      when != E = E1
* E->f
  ... when any
  return ...;
}
else S3
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 drivers/net/hamradio/yam.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c
index 694132e..4e7d1d0 100644
--- a/drivers/net/hamradio/yam.c
+++ b/drivers/net/hamradio/yam.c
@@ -1151,8 +1151,7 @@ static int __init yam_init_driver(void)
 		dev = alloc_netdev(sizeof(struct yam_port), name,
 				   yam_setup);
 		if (!dev) {
-			printk(KERN_ERR "yam: cannot allocate net device %s\n",
-			       dev->name);
+			pr_err("yam: cannot allocate net device\n");
 			err = -ENOMEM;
 			goto error;
 		}

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-07-16  3:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-14 18:58 [PATCH] xfbbd: Fix issue with xfbbd and AX25 radio connections Bernard Pidoux
2013-07-05 21:20 ` [PATCH] xfbbd: Run the same data files on 64-bit Cathryn Mataga
2013-07-06 21:24   ` Pidoux
2013-07-07  0:15     ` Cathryn Mataga
2013-07-16  3:09     ` Cathryn Mataga
  -- strict thread matches above, loose matches on Subject: below --
2010-05-27 12:33 [PATCH 4/11] drivers/net/hamradio: Eliminate a NULL pointer dereference Julia Lawall
2010-05-27 23:29 ` David Miller
2010-11-09 19:09   ` xfbbd oddness Cathryn Mataga
2010-11-10  2:54     ` Cathryn Mataga
2010-11-12 21:23       ` Cathryn Mataga
2010-11-14  6:52         ` Cathryn Mataga
2010-11-14  6:58           ` [PATCH] xfbbd: Fix issue with xfbbd and AX25 radio connections Cathryn Mataga

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox