* Re: linux-next-20251029 - build error in amdgpu
[not found] ` <CAO=gReF+sWpKZFa+wbtGxa3+wSjAQG1UMG3iJaDt2EOPmH-7mQ@mail.gmail.com>
@ 2025-11-06 3:18 ` Valdis Klētnieks
2025-11-06 14:02 ` Kees Cook
0 siblings, 1 reply; 4+ messages in thread
From: Valdis Klētnieks @ 2025-11-06 3:18 UTC (permalink / raw)
To: Amit Dhingra
Cc: Timur Kristóf, Alex Deucher, Leo Li, David Airlie,
amd-gfx list, dri-devel, linux-kernel, Kees Cook, linux-hardening
On Wed, 05 Nov 2025 18:34:05 -0800, Amit Dhingra said:
> I have the same problem.
> ...
> Setting RANDSTRUCT_NONE=y seems to stop the error.
>
> [1] https://lore.kernel.org/all/2025062439-tamer-diner-68e9@gregkh/
Wow. I wouldn't have guessed that RANDSTRUCT would be the cause...
However, RANDSTRUCT_NONE=y does make dce_stream_encoder.c compile cleanly.
<insert Twilight Zone theme music here>
Adding Kees Cook and the linux-hardening list to the cc:, hope somebody has an
idea what's going on.
\0\0\0\0\0\0\0\0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next-20251029 - build error in amdgpu
2025-11-06 3:18 ` linux-next-20251029 - build error in amdgpu Valdis Klētnieks
@ 2025-11-06 14:02 ` Kees Cook
2025-11-06 23:49 ` Bill Wendling
2025-11-08 15:10 ` Valdis Klētnieks
0 siblings, 2 replies; 4+ messages in thread
From: Kees Cook @ 2025-11-06 14:02 UTC (permalink / raw)
To: Valdis Klētnieks, Amit Dhingra
Cc: Timur Kristóf, Alex Deucher, Leo Li, David Airlie,
amd-gfx list, dri-devel, linux-kernel, linux-hardening
On November 5, 2025 7:18:51 PM PST, "Valdis Klētnieks" <valdis.kletnieks@vt.edu> wrote:
>On Wed, 05 Nov 2025 18:34:05 -0800, Amit Dhingra said:
>
>> I have the same problem.
>> ...
>
>> Setting RANDSTRUCT_NONE=y seems to stop the error.
>>
>> [1] https://lore.kernel.org/all/2025062439-tamer-diner-68e9@gregkh/
>
>Wow. I wouldn't have guessed that RANDSTRUCT would be the cause...
>However, RANDSTRUCT_NONE=y does make dce_stream_encoder.c compile cleanly.
>
><insert Twilight Zone theme music here>
>
>Adding Kees Cook and the linux-hardening list to the cc:, hope somebody has an
>idea what's going on.
I'm surprised the stable team didn't find the associated fix in your linked thread. It had the right Fixes tag:
https://lore.kernel.org/all/20250502224156.work.617-kees@kernel.org/
Regardless, just remove the "0" from the dce110_an_str_enc_funcs initializer; that's an older code pattern that isn't needed any more.
Randstruct requires designated initializers, though I thought the macro turned that on universally, so the fact that the error is only present with randstruct seems like a separate bug.
-Kees
--
Kees Cook
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next-20251029 - build error in amdgpu
2025-11-06 14:02 ` Kees Cook
@ 2025-11-06 23:49 ` Bill Wendling
2025-11-08 15:10 ` Valdis Klētnieks
1 sibling, 0 replies; 4+ messages in thread
From: Bill Wendling @ 2025-11-06 23:49 UTC (permalink / raw)
To: Kees Cook
Cc: Valdis Klētnieks, Amit Dhingra, Timur Kristóf,
Alex Deucher, Leo Li, David Airlie, amd-gfx list, dri-devel,
linux-kernel, linux-hardening
On Thu, Nov 6, 2025 at 6:13 AM Kees Cook <kees@kernel.org> wrote:
> On November 5, 2025 7:18:51 PM PST, "Valdis Klētnieks" <valdis.kletnieks@vt.edu> wrote:
> >On Wed, 05 Nov 2025 18:34:05 -0800, Amit Dhingra said:
> >
> >> I have the same problem.
> >> ...
> >
> >> Setting RANDSTRUCT_NONE=y seems to stop the error.
> >>
> >> [1] https://lore.kernel.org/all/2025062439-tamer-diner-68e9@gregkh/
> >
> >Wow. I wouldn't have guessed that RANDSTRUCT would be the cause...
> >However, RANDSTRUCT_NONE=y does make dce_stream_encoder.c compile cleanly.
> >
> ><insert Twilight Zone theme music here>
> >
> >Adding Kees Cook and the linux-hardening list to the cc:, hope somebody has an
> >idea what's going on.
>
> I'm surprised the stable team didn't find the associated fix in your linked thread. It had the right Fixes tag:
> https://lore.kernel.org/all/20250502224156.work.617-kees@kernel.org/
>
FYI, their Fixes tag points to something that doesn't exist. I found
it at SHA1 e136a4062174a9a8d1c1447ca040ea81accfa6a8 though.
> Regardless, just remove the "0" from the dce110_an_str_enc_funcs initializer; that's an older code pattern that isn't needed any more.
>
> Randstruct requires designated initializers, though I thought the macro turned that on universally, so the fact that the error is only present with randstruct seems like a separate bug.
>
> -Kees
>
> --
> Kees Cook
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next-20251029 - build error in amdgpu
2025-11-06 14:02 ` Kees Cook
2025-11-06 23:49 ` Bill Wendling
@ 2025-11-08 15:10 ` Valdis Klētnieks
1 sibling, 0 replies; 4+ messages in thread
From: Valdis Klētnieks @ 2025-11-08 15:10 UTC (permalink / raw)
To: Kees Cook
Cc: Amit Dhingra, Timur Kristóf, Alex Deucher, Leo Li,
David Airlie, amd-gfx list, dri-devel, linux-kernel,
linux-hardening
On Thu, 06 Nov 2025 06:02:23 -0800, Kees Cook said:
> Randstruct requires designated initializers, though I thought the macro
> turned that on universally, so the fact that the error is only present with
> randstruct seems like a separate bug.
Yeah, that's why I cc'ed you - looked to me like randstruct was doing something
weird...
\0AA1@kern
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-11-08 15:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1043551.1761844832@turing-police>
[not found] ` <32ed124e9d603cad950c4836c7a14a3ba8bc2068.camel@gmail.com>
[not found] ` <1296761.1762045181@turing-police>
[not found] ` <CAFF-SiU3XL5pZAzsB=eXi7e1LKzx5XwiNOyfGpPXOnnc6uo2cw@mail.gmail.com>
[not found] ` <CAO=gReF+sWpKZFa+wbtGxa3+wSjAQG1UMG3iJaDt2EOPmH-7mQ@mail.gmail.com>
2025-11-06 3:18 ` linux-next-20251029 - build error in amdgpu Valdis Klētnieks
2025-11-06 14:02 ` Kees Cook
2025-11-06 23:49 ` Bill Wendling
2025-11-08 15:10 ` Valdis Klētnieks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox