* Re: [PATCH 0/2]: ARM: Enable THREAD_INFO_IN_TASK [not found] <20210902155429.3987201-1-keithp@keithp.com> @ 2021-09-02 16:07 ` Kees Cook 2021-09-02 16:18 ` Ard Biesheuvel 2021-09-02 16:54 ` Russell King (Oracle) 0 siblings, 2 replies; 4+ messages in thread From: Kees Cook @ 2021-09-02 16:07 UTC (permalink / raw) To: Keith Packard Cc: linux-kernel, Abbott Liu, Alexander Sverdlin, Al Viro, Andrew Morton, Anshuman Khandual, Ard Biesheuvel, Arnd Bergmann, Bjorn Andersson, Florian Fainelli, Geert Uytterhoeven, Hartley Sweeten, Jens Axboe, Jian Cai, Joe Perches, Linus Walleij, linux-arm-kernel, Maninder Singh, Manivannan Sadhasivam, Marc Zyngier, Masahiro Yamada, Mike Rapoport, Nick Desaulniers, Nick Desaulniers, Nicolas Pitre, Peter Zijlstra, Russell King, Thomas Gleixner, Uwe Kleine-König, Valentin Schneider, Vaneet Narang, Wolfram Sang (Renesas), YiFei Zhu, Keith Packard, linux-hardening On Thu, Sep 02, 2021 at 08:54:26AM -0700, Keith Packard wrote: > Placing thread_info in the kernel stack leaves it vulnerable to stack > overflow attacks. This short series addresses that by using the > existing THREAD_INFO_IN_TASK infrastructure. Very cool! Thanks for working on this. If you want, you can refer to the KSPP bug for this too: https://github.com/KSPP/linux/issues/1 (Anyone want to do MIPS?) -Kees -- Kees Cook ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2]: ARM: Enable THREAD_INFO_IN_TASK 2021-09-02 16:07 ` [PATCH 0/2]: ARM: Enable THREAD_INFO_IN_TASK Kees Cook @ 2021-09-02 16:18 ` Ard Biesheuvel 2021-09-02 17:37 ` Kees Cook 2021-09-02 16:54 ` Russell King (Oracle) 1 sibling, 1 reply; 4+ messages in thread From: Ard Biesheuvel @ 2021-09-02 16:18 UTC (permalink / raw) To: Kees Cook Cc: Keith Packard, Linux Kernel Mailing List, Abbott Liu, Alexander Sverdlin, Al Viro, Andrew Morton, Anshuman Khandual, Arnd Bergmann, Bjorn Andersson, Florian Fainelli, Geert Uytterhoeven, Hartley Sweeten, Jens Axboe, Jian Cai, Joe Perches, Linus Walleij, Linux ARM, Maninder Singh, Manivannan Sadhasivam, Marc Zyngier, Masahiro Yamada, Mike Rapoport, Nick Desaulniers, Nick Desaulniers, Nicolas Pitre, Peter Zijlstra, Russell King, Thomas Gleixner, Uwe Kleine-König, Valentin Schneider, Vaneet Narang, Wolfram Sang (Renesas), YiFei Zhu, Keith Packard, linux-hardening On Thu, 2 Sept 2021 at 18:07, Kees Cook <keescook@chromium.org> wrote: > > On Thu, Sep 02, 2021 at 08:54:26AM -0700, Keith Packard wrote: > > Placing thread_info in the kernel stack leaves it vulnerable to stack > > overflow attacks. This short series addresses that by using the > > existing THREAD_INFO_IN_TASK infrastructure. > > Very cool! Thanks for working on this. If you want, you can refer to the > KSPP bug for this too: > https://github.com/KSPP/linux/issues/1 > > (Anyone want to do MIPS?) > I take it this breaks the GCC plugin based per-task stack protector, given that it emits code to mask the stack pointer and apply an offset to the resulting value. It would be nice if we could replace this with something suitable for THREAD_INFO_IN_TASK, and if it is suitable enough, try and get the GCC/Clang folks to adopt it as well (which was never going to happen for the stack pointer mask/offset approach) Where can I find these patches? I don't see them on linux-arm-kernel@ ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2]: ARM: Enable THREAD_INFO_IN_TASK 2021-09-02 16:18 ` Ard Biesheuvel @ 2021-09-02 17:37 ` Kees Cook 0 siblings, 0 replies; 4+ messages in thread From: Kees Cook @ 2021-09-02 17:37 UTC (permalink / raw) To: Ard Biesheuvel Cc: Keith Packard, Linux Kernel Mailing List, Abbott Liu, Alexander Sverdlin, Al Viro, Andrew Morton, Anshuman Khandual, Arnd Bergmann, Bjorn Andersson, Florian Fainelli, Geert Uytterhoeven, Hartley Sweeten, Jens Axboe, Jian Cai, Joe Perches, Linus Walleij, Linux ARM, Maninder Singh, Manivannan Sadhasivam, Marc Zyngier, Masahiro Yamada, Mike Rapoport, Nick Desaulniers, Nick Desaulniers, Nicolas Pitre, Peter Zijlstra, Russell King, Thomas Gleixner, Uwe Kleine-König, Valentin Schneider, Vaneet Narang, Wolfram Sang (Renesas), YiFei Zhu, Keith Packard, linux-hardening On Thu, Sep 02, 2021 at 06:18:29PM +0200, Ard Biesheuvel wrote: > On Thu, 2 Sept 2021 at 18:07, Kees Cook <keescook@chromium.org> wrote: > > > > On Thu, Sep 02, 2021 at 08:54:26AM -0700, Keith Packard wrote: > > > Placing thread_info in the kernel stack leaves it vulnerable to stack > > > overflow attacks. This short series addresses that by using the > > > existing THREAD_INFO_IN_TASK infrastructure. > > > > Very cool! Thanks for working on this. If you want, you can refer to the > > KSPP bug for this too: > > https://github.com/KSPP/linux/issues/1 > > > > (Anyone want to do MIPS?) > > > > I take it this breaks the GCC plugin based per-task stack protector, > given that it emits code to mask the stack pointer and apply an offset > to the resulting value. > > It would be nice if we could replace this with something suitable for > THREAD_INFO_IN_TASK, and if it is suitable enough, try and get the > GCC/Clang folks to adopt it as well (which was never going to happen > for the stack pointer mask/offset approach) I'd love to see the native GCC offset stuff work on arm32, but it's not clear to me how much work that would be. It's implemented for several architectures already. I've tried to capture the matrix here: https://github.com/KSPP/linux/issues/29 -Kees -- Kees Cook ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2]: ARM: Enable THREAD_INFO_IN_TASK 2021-09-02 16:07 ` [PATCH 0/2]: ARM: Enable THREAD_INFO_IN_TASK Kees Cook 2021-09-02 16:18 ` Ard Biesheuvel @ 2021-09-02 16:54 ` Russell King (Oracle) 1 sibling, 0 replies; 4+ messages in thread From: Russell King (Oracle) @ 2021-09-02 16:54 UTC (permalink / raw) To: Kees Cook Cc: Keith Packard, linux-kernel, Abbott Liu, Alexander Sverdlin, Al Viro, Andrew Morton, Anshuman Khandual, Ard Biesheuvel, Arnd Bergmann, Bjorn Andersson, Florian Fainelli, Geert Uytterhoeven, Hartley Sweeten, Jens Axboe, Jian Cai, Joe Perches, Linus Walleij, linux-arm-kernel, Maninder Singh, Manivannan Sadhasivam, Marc Zyngier, Masahiro Yamada, Mike Rapoport, Nick Desaulniers, Nick Desaulniers, Nicolas Pitre, Peter Zijlstra, Thomas Gleixner, Uwe Kleine-König, Valentin Schneider, Vaneet Narang, Wolfram Sang (Renesas), YiFei Zhu, Keith Packard, linux-hardening On Thu, Sep 02, 2021 at 09:07:42AM -0700, Kees Cook wrote: > On Thu, Sep 02, 2021 at 08:54:26AM -0700, Keith Packard wrote: > > Placing thread_info in the kernel stack leaves it vulnerable to stack > > overflow attacks. This short series addresses that by using the > > existing THREAD_INFO_IN_TASK infrastructure. > > Very cool! Thanks for working on this. If you want, you can refer to the > KSPP bug for this too: > https://github.com/KSPP/linux/issues/1 Not so fast. It's buggy. I've rejected this "solution" before. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-02 17:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210902155429.3987201-1-keithp@keithp.com>
2021-09-02 16:07 ` [PATCH 0/2]: ARM: Enable THREAD_INFO_IN_TASK Kees Cook
2021-09-02 16:18 ` Ard Biesheuvel
2021-09-02 17:37 ` Kees Cook
2021-09-02 16:54 ` Russell King (Oracle)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox