linux-hardening.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Petr Mladek <pmladek@suse.com>, Thomas Gleixner <tglx@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Kees Cook <kees@kernel.org>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Tycho Andersen <tycho@tycho.pizza>,
	Linus Torvalds <torvalds@linuxfoundation.org>
Subject: Re: [PATCH v2 2/2] kallsyms: Document why unresolved symbols are revealed
Date: Tue, 1 Sep 2026 09:30:51 -0400	[thread overview]
Message-ID: <20260901093051.51d23697@gandalf.local.home> (raw)
In-Reply-To: <20260901080142.CMTCw6vE@linutronix.de>

On Tue, 1 Sep 2026 10:01:42 +0200
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:

> >  [    1.498171]  <TASK>
> >  [    1.498172]  h0000000cb9bc262
> >  [    1.498174]  ? h0000000eb5021dd
> >  [    1.498176]  h0000000ed1a9938
> >  [    1.498178]  </TASK>
> > 
> > But 'h' is not a valid number number so it might confuse parsers as
> > well. And it is not that user friedly either.
> > 
> > So, I still like more Steven's variant with [hash].  
> 
> While it does make sense to add [hash] to make it obvious it breaks
> formatting for some of the %p users where %p is expected to have a fixed
> length depending on 32/64 bit. Here, it is a %pS so adding extra it
> wouldn't break anything but I don't think it should be different between
> %p and %pS assuming we do print the hash instead 'unknown'.

Since the hash value is usually less than a normal pointer length, we could
have it be:

  h:XXXXXX on 32bit and h:XXXXXXXXXXXXXX on 64 bit, where it will not take
  up more than the size expected.

 [    1.498171]  <TASK>
 [    1.498172]  h:000000cb9bc262
 [    1.498174]  ? h:000000eb5021dd
 [    1.498176]  h:000000ed1a9938
 [    1.498178]  </TASK>

-- Steve

  reply	other threads:[~2026-09-01 13:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21 15:26 [PATCH v2 0/2] vsprintf: Don't leak pointers Sebastian Andrzej Siewior
2026-08-21 15:26 ` [PATCH v2 1/2] vsprintf: Don't leak pointers for %ps without KALLSYMS enabled Sebastian Andrzej Siewior
2026-08-26 15:56   ` Petr Mladek
2026-08-27  9:14     ` Sebastian Andrzej Siewior
2026-08-27  9:51       ` Petr Mladek
2026-08-31 13:30         ` Sebastian Andrzej Siewior
2026-08-31 14:22           ` Petr Mladek
2026-08-21 15:26 ` [PATCH v2 2/2] kallsyms: Document why unresolved symbols are revealed Sebastian Andrzej Siewior
2026-08-26 16:21   ` Petr Mladek
2026-08-27 10:24     ` Sebastian Andrzej Siewior
2026-08-31 13:37       ` Sebastian Andrzej Siewior
2026-08-31 16:49         ` Steven Rostedt
2026-09-01  7:23           ` Petr Mladek
2026-09-01  8:01             ` Sebastian Andrzej Siewior
2026-09-01 13:30               ` Steven Rostedt [this message]
2026-08-26 14:51 ` [PATCH v2 0/2] vsprintf: Don't leak pointers Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260901093051.51d23697@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=kees@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=senozhatsky@chromium.org \
    --cc=tglx@kernel.org \
    --cc=torvalds@linuxfoundation.org \
    --cc=tycho@tycho.pizza \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).