Linux Hardening
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: Bill Wendling <morbo@google.com>
Cc: "Kees Cook" <kees@kernel.org>,
	"Alison Schofield" <alison.schofield@intel.com>,
	"Vishal Verma" <vishal.l.verma@intel.com>,
	"Dave Jiang" <dave.jiang@intel.com>,
	"Ira Weiny" <iweiny@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Guangshuo Li" <lgs201920130244@gmail.com>,
	nvdimm@lists.linux.dev, "Steven Rostedt" <rostedt@goodmis.org>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	linux-hardening@vger.kernel.org
Subject: [PATCH 7/7] nvdimm: ndtest: Return the string length from flags_show()
Date: Wed, 16 Sep 2026 17:23:19 -0700	[thread overview]
Message-ID: <20260917002333.2306346-7-kees@kernel.org> (raw)
In-Reply-To: <20260917002312.i.923-kees@kernel.org>

flags_show() build their output with a seq_buf and return seq_buf_used(),
which may include the trailing NUL byte when the seq_buf has
overflowed. Use seq_buf_strlen() instead.

The flag names are far shorter than the PAGE_SIZE buffer sysfs
provides, so this cannot overflow today.

Build tested ARCH=x86_64 with GCC 16.2.0, built out of tree with
make M=tools/testing/nvdimm:
tools/testing/nvdimm/test/ndtest.o

Assisted-by: LLM
Signed-off-by: Kees Cook <kees@kernel.org>
---
Cc: Alison Schofield <alison.schofield@intel.com>
Cc: Vishal Verma <vishal.l.verma@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Ira Weiny <iweiny@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Guangshuo Li <lgs201920130244@gmail.com>
Cc: <nvdimm@lists.linux.dev>
---
 tools/testing/nvdimm/test/ndtest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/nvdimm/test/ndtest.c b/tools/testing/nvdimm/test/ndtest.c
index 2051ad5d4882..f097f2992966 100644
--- a/tools/testing/nvdimm/test/ndtest.c
+++ b/tools/testing/nvdimm/test/ndtest.c
@@ -693,7 +693,7 @@ static ssize_t flags_show(struct device *dev,
 	if (seq_buf_used(&s))
 		seq_buf_printf(&s, "\n");
 
-	return seq_buf_used(&s);
+	return seq_buf_strlen(&s);
 }
 static DEVICE_ATTR_RO(flags);
 
-- 
2.34.1


  parent reply	other threads:[~2026-09-17  0:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17  0:23 [PATCH 0/7] seq_buf: Add seq_buf_strlen() Kees Cook
2026-09-17  0:23 ` [PATCH 1/7] seq_buf: Do not pop from an overflowed seq_buf Kees Cook
2026-09-17  0:23 ` [PATCH 2/7] seq_buf: Copy what fits when seq_buf_puts() and seq_buf_putmem() overflow Kees Cook
2026-09-17  0:23 ` [PATCH 3/7] seq_buf: Clear what a writer did not claim when a seq_buf overflows Kees Cook
2026-09-17  0:23 ` [PATCH 4/7] seq_buf: Add seq_buf_strlen() Kees Cook
2026-09-17  0:23 ` [PATCH 5/7] seq_buf: Use seq_buf_strlen() for the string end in seq_buf_do_printk() Kees Cook
2026-09-17  0:23 ` [PATCH 6/7] powerpc/papr_scm: Return the string length from the sysfs show functions Kees Cook
2026-09-17 12:50   ` Andy Shevchenko
2026-09-17 21:19     ` Kees Cook
2026-09-17  0:23 ` Kees Cook [this message]
2026-09-18  3:24   ` [PATCH 7/7] nvdimm: ndtest: Return the string length from flags_show() Dave Jiang
2026-09-17 12:51 ` [PATCH 0/7] seq_buf: Add seq_buf_strlen() Andy Shevchenko
2026-09-17 21:21   ` Kees Cook
2026-09-18  7:45     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260917002333.2306346-7-kees@kernel.org \
    --to=kees@kernel.org \
    --cc=alison.schofield@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dave.jiang@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=iweiny@kernel.org \
    --cc=lgs201920130244@gmail.com \
    --cc=linux-hardening@vger.kernel.org \
    --cc=morbo@google.com \
    --cc=nvdimm@lists.linux.dev \
    --cc=rostedt@goodmis.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox