Linux Hardening
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bill Wendling <morbo@google.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH 0/7] seq_buf: Add seq_buf_strlen()
Date: Thu, 17 Sep 2026 14:21:34 -0700	[thread overview]
Message-ID: <202609171419.F929921@keescook> (raw)
In-Reply-To: <aqviXSO0qnCoioWG@ashevche-desk.local>

On Thu, Sep 17, 2026 at 03:51:41PM +0300, Andy Shevchenko wrote:
> On Wed, Sep 16, 2026 at 05:23:12PM -0700, Kees Cook wrote:
> 
> > While working on seq_buf conversions, we found there was a need for
> > seq_buf_strlen() (since calling strlen(seq_buf_str()) would be a waste
> > of time: seq_buf already knows the length). And while implementing that,
> > I found a bunch of other related things that needed fixing. This is that
> > series, with tests for each fix.
> 
> I like the series, especially the trick on how to capture printk() messages.
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks! I'm going to spin a v2 with Bill's seq_buf_init_append()[1] (though
I think I want to call it seq_buf_init_existing()? I'm open to ideas
here...)

-Kees

[1] https://lore.kernel.org/lkml/20260916221528.1256283-1-morbo@google.com/

-- 
Kees Cook

  reply	other threads:[~2026-09-17 21:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17  0:23 [PATCH 0/7] seq_buf: Add seq_buf_strlen() Kees Cook
2026-09-17  0:23 ` [PATCH 1/7] seq_buf: Do not pop from an overflowed seq_buf Kees Cook
2026-09-17  0:23 ` [PATCH 2/7] seq_buf: Copy what fits when seq_buf_puts() and seq_buf_putmem() overflow Kees Cook
2026-09-17  0:23 ` [PATCH 3/7] seq_buf: Clear what a writer did not claim when a seq_buf overflows Kees Cook
2026-09-17  0:23 ` [PATCH 4/7] seq_buf: Add seq_buf_strlen() Kees Cook
2026-09-17  0:23 ` [PATCH 5/7] seq_buf: Use seq_buf_strlen() for the string end in seq_buf_do_printk() Kees Cook
2026-09-17  0:23 ` [PATCH 6/7] powerpc/papr_scm: Return the string length from the sysfs show functions Kees Cook
2026-09-17 12:50   ` Andy Shevchenko
2026-09-17 21:19     ` Kees Cook
2026-09-17  0:23 ` [PATCH 7/7] nvdimm: ndtest: Return the string length from flags_show() Kees Cook
2026-09-18  3:24   ` Dave Jiang
2026-09-17 12:51 ` [PATCH 0/7] seq_buf: Add seq_buf_strlen() Andy Shevchenko
2026-09-17 21:21   ` Kees Cook [this message]
2026-09-18  7:45     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202609171419.F929921@keescook \
    --to=kees@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-hardening@vger.kernel.org \
    --cc=morbo@google.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox