Linux Hardening
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: "David Heidelberg" <david@ixit.cz>,
	"Barnabás Czémán" <barnabas.czeman@mainlining.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Gabriel Gonzales" <semfault@disroot.org>,
	"Kees Cook" <kees@kernel.org>, "Tony Luck" <tony.luck@intel.com>,
	"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
	"Biswapriyo Nath" <nathbappai@gmail.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
	phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org
Subject: Re: [PATCH 2/6] arm64: dts: qcom: sm6125-xiaomi-ginkgo: Correct reserved memory ranges
Date: Fri, 16 Jan 2026 12:30:14 +0100	[thread overview]
Message-ID: <42a0e768-c217-44b2-81ba-1237d9f983f9@oss.qualcomm.com> (raw)
In-Reply-To: <d90872ae-968f-4340-8348-aa83de92a3de@ixit.cz>

On 1/16/26 12:21 PM, David Heidelberg wrote:
> On 16/01/2026 10:52, Konrad Dybcio wrote:
>> On 1/14/26 10:55 PM, David Heidelberg wrote:
>>> On 14/01/2026 11:28, Konrad Dybcio wrote:
>>>> On 1/14/26 11:15 AM, David Heidelberg wrote:
>>>>> On 12/01/2026 21:13, Barnabás Czémán wrote:
>>>>>> The device was crashing on high memory load because the reserved memory
>>>>>> ranges was wrongly defined. Correct the ranges for avoid the crashes.
>>>>>> Change the ramoops memory range to match with the values from the recovery
>>>>>> to be able to get the results from the device.
>>>>>>
>>>>>> Fixes: 9b1a6c925c88 ("arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo")
>>>>>> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
>>>>>> ---
>>>>
>>>> [...]
>>>>
>>>>> Hello!
>>>>>
>>>>> I suggest one more nice to have improvement:
>>>>>
>>>>> you could label framebuffer cont_splash_mem since you already touching the node and testing the series.
>>>>>
>>>>> Then in additional commit, you can replace manually defined `reg` in chosen > framebuffer node with
>>>>>
>>>>> memory-region = <&cont_splash_mem>;
>>>>>
>>>>> For example you can look at sdm845-oneplus-common.dtsi
>>>>>
>>>>> Tell me what u think
>>>>
>>>> If you wanna do that, please call it framebuffer_mem, "cont_splash" is a
>>>> Qualcomm-specific name for (roughly) flicker-free bootup
>>>
>>> I have feeling someone recommended me to stick with cont_splash_mem.
>>>
>>> I think, since we'll be doing the mdss reset anyway in sdm845 (which I used as an example), I can do the rename in our sdm845 too then without any harm? (no it's not flicker-free takeover :D )
>>
>> It's not flicker-free because the OS must cooperate in that process,
>> whereas we currently reset and re-initialize the entire display subsystem
> 
> Sure.
> 
> Previously I was thinking, that after doing proper panel driver with proper initialization sequences etc. etc., we could have device-tree property such as "linux,takeover-from-bootloader", where we could skip mdss reset, panel reset and just continue from the point what bootloader set (for devices where bootloader does the right job).

I don't think there's a need for a separate property. Once MDSS is
powered on, various registers could be read back and the state could be
largely inferred from there.

It just comes with an infinite amount of edge cases and it's not top
priority for now, I don't think

Konrad

  reply	other threads:[~2026-01-16 11:30 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-12 20:13 [PATCH 0/6] Initial Redmi Note 8T support and more Barnabás Czémán
2026-01-12 20:13 ` [PATCH 1/6] arm64: dts: qcom: sm6125-xiaomi-ginkgo: Fix msm-id and remove board-id Barnabás Czémán
2026-01-12 22:11   ` Dmitry Baryshkov
2026-01-13  8:52   ` Konrad Dybcio
2026-01-14  9:10   ` Krzysztof Kozlowski
2026-01-12 20:13 ` [PATCH 2/6] arm64: dts: qcom: sm6125-xiaomi-ginkgo: Correct reserved memory ranges Barnabás Czémán
2026-01-13  8:53   ` Konrad Dybcio
2026-01-13  9:14     ` barnabas.czeman
2026-01-13  9:21       ` Konrad Dybcio
2026-01-14 10:15   ` David Heidelberg
2026-01-14 10:28     ` Konrad Dybcio
2026-01-14 21:55       ` David Heidelberg
2026-01-16  9:52         ` Konrad Dybcio
2026-01-16 11:21           ` David Heidelberg
2026-01-16 11:30             ` Konrad Dybcio [this message]
2026-01-12 20:13 ` [PATCH 3/6] arm64: dts: qcom: sm6125-xiaomi-ginkgo: Remove extcon Barnabás Czémán
2026-01-12 22:12   ` Dmitry Baryshkov
2026-01-13  8:59   ` Konrad Dybcio
2026-01-13  9:00   ` Konrad Dybcio
2026-01-13  9:11     ` barnabas.czeman
2026-01-13  9:13       ` Konrad Dybcio
2026-01-12 20:13 ` [PATCH 4/6] arm64: dts: qcom: sm6125-xiaomi-ginkgo: Fix reserved gpio ranges Barnabás Czémán
2026-01-13  9:01   ` Konrad Dybcio
2026-01-13  9:08     ` barnabas.czeman
2026-01-13  9:12       ` Konrad Dybcio
2026-01-13  9:25         ` barnabas.czeman
2026-01-13  9:45           ` Konrad Dybcio
2026-01-13 14:13             ` Biswapriyo Nath
2026-01-12 20:13 ` [PATCH 5/6] dt-bindings: arm: qcom: Add Xiaomi Redmi Note 8T Barnabás Czémán
2026-01-15 17:37   ` Rob Herring (Arm)
2026-01-12 20:13 ` [PATCH 6/6] arm64: dts: qcom: Add " Barnabás Czémán
2026-01-12 22:15   ` Dmitry Baryshkov
2026-01-12 23:41     ` barnabas.czeman
2026-01-13  0:22       ` Dmitry Baryshkov
2026-01-13  0:49         ` barnabas.czeman
2026-01-13  1:18           ` Dmitry Baryshkov
2026-01-13  8:52           ` Konrad Dybcio
2026-01-13  9:20             ` barnabas.czeman
2026-01-13  9:04   ` Konrad Dybcio
2026-01-16  6:53     ` barnabas.czeman
2026-01-16  9:53       ` Konrad Dybcio
2026-01-16 10:51         ` barnabas.czeman
2026-01-16 11:03           ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42a0e768-c217-44b2-81ba-1237d9f983f9@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=barnabas.czeman@mainlining.org \
    --cc=conor+dt@kernel.org \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=gpiccoli@igalia.com \
    --cc=kees@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@mainlining.org \
    --cc=nathbappai@gmail.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=semfault@disroot.org \
    --cc=tony.luck@intel.com \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox