Linux Hardening
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: "Barnabás Czémán" <barnabas.czeman@mainlining.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Gabriel Gonzales" <semfault@disroot.org>,
	"Kees Cook" <kees@kernel.org>, "Tony Luck" <tony.luck@intel.com>,
	"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
	"Biswapriyo Nath" <nathbappai@gmail.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
	phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org
Subject: Re: [PATCH 6/6] arm64: dts: qcom: Add Redmi Note 8T
Date: Tue, 13 Jan 2026 10:04:16 +0100	[thread overview]
Message-ID: <ff8fbdb9-dd03-4811-b9cc-4ec0dabf9353@oss.qualcomm.com> (raw)
In-Reply-To: <20260112-xiaomi-willow-v1-6-8e4476897638@mainlining.org>

On 1/12/26 9:13 PM, Barnabás Czémán wrote:
> Redmi Note 8T (willow) is very similar to Redmi Note 8 (ginkgo)
> the only difference is willow have NFC.
> Make a common base from ginkgo devicetree for both device.
> 
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
> ---

[...]

> diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
> index 163ecdc7fd6c..70be19357d11 100644
> --- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
> @@ -1,304 +1,12 @@
>  // SPDX-License-Identifier: BSD-3-Clause
>  /*
> - * Copyright (c) 2025, Gabriel Gonzales <semfault@disroot.org>
> + * Copyright (c) 2026, Barnabas Czeman

Is there a reason for you to remove Gabriel's copyright from the 5 LoC
that remain in this file?

Adding your own to an existing file in a commit that mostly moves code
around is also odd. It would look considerably better if you did so in
one of the previous commits that fixed things, as those contributions
are easier to perceive as non-trivial.

Konrad

  parent reply	other threads:[~2026-01-13  9:04 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-12 20:13 [PATCH 0/6] Initial Redmi Note 8T support and more Barnabás Czémán
2026-01-12 20:13 ` [PATCH 1/6] arm64: dts: qcom: sm6125-xiaomi-ginkgo: Fix msm-id and remove board-id Barnabás Czémán
2026-01-12 22:11   ` Dmitry Baryshkov
2026-01-13  8:52   ` Konrad Dybcio
2026-01-14  9:10   ` Krzysztof Kozlowski
2026-01-12 20:13 ` [PATCH 2/6] arm64: dts: qcom: sm6125-xiaomi-ginkgo: Correct reserved memory ranges Barnabás Czémán
2026-01-13  8:53   ` Konrad Dybcio
2026-01-13  9:14     ` barnabas.czeman
2026-01-13  9:21       ` Konrad Dybcio
2026-01-14 10:15   ` David Heidelberg
2026-01-14 10:28     ` Konrad Dybcio
2026-01-14 21:55       ` David Heidelberg
2026-01-16  9:52         ` Konrad Dybcio
2026-01-16 11:21           ` David Heidelberg
2026-01-16 11:30             ` Konrad Dybcio
2026-01-12 20:13 ` [PATCH 3/6] arm64: dts: qcom: sm6125-xiaomi-ginkgo: Remove extcon Barnabás Czémán
2026-01-12 22:12   ` Dmitry Baryshkov
2026-01-13  8:59   ` Konrad Dybcio
2026-01-13  9:00   ` Konrad Dybcio
2026-01-13  9:11     ` barnabas.czeman
2026-01-13  9:13       ` Konrad Dybcio
2026-01-12 20:13 ` [PATCH 4/6] arm64: dts: qcom: sm6125-xiaomi-ginkgo: Fix reserved gpio ranges Barnabás Czémán
2026-01-13  9:01   ` Konrad Dybcio
2026-01-13  9:08     ` barnabas.czeman
2026-01-13  9:12       ` Konrad Dybcio
2026-01-13  9:25         ` barnabas.czeman
2026-01-13  9:45           ` Konrad Dybcio
2026-01-13 14:13             ` Biswapriyo Nath
2026-01-12 20:13 ` [PATCH 5/6] dt-bindings: arm: qcom: Add Xiaomi Redmi Note 8T Barnabás Czémán
2026-01-15 17:37   ` Rob Herring (Arm)
2026-01-12 20:13 ` [PATCH 6/6] arm64: dts: qcom: Add " Barnabás Czémán
2026-01-12 22:15   ` Dmitry Baryshkov
2026-01-12 23:41     ` barnabas.czeman
2026-01-13  0:22       ` Dmitry Baryshkov
2026-01-13  0:49         ` barnabas.czeman
2026-01-13  1:18           ` Dmitry Baryshkov
2026-01-13  8:52           ` Konrad Dybcio
2026-01-13  9:20             ` barnabas.czeman
2026-01-13  9:04   ` Konrad Dybcio [this message]
2026-01-16  6:53     ` barnabas.czeman
2026-01-16  9:53       ` Konrad Dybcio
2026-01-16 10:51         ` barnabas.czeman
2026-01-16 11:03           ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff8fbdb9-dd03-4811-b9cc-4ec0dabf9353@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=barnabas.czeman@mainlining.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gpiccoli@igalia.com \
    --cc=kees@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@mainlining.org \
    --cc=nathbappai@gmail.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=semfault@disroot.org \
    --cc=tony.luck@intel.com \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox