* [PATCH net-next v2 2/2] KEYS: annotate struct user_key_payload with __counted_by [not found] <20260409225703.158552-4-thorsten.blum@linux.dev> @ 2026-04-09 22:57 ` Thorsten Blum 2026-04-15 2:25 ` Jarkko Sakkinen 0 siblings, 1 reply; 2+ messages in thread From: Thorsten Blum @ 2026-04-09 22:57 UTC (permalink / raw) To: David Howells, Jarkko Sakkinen, Kees Cook, Gustavo A. R. Silva Cc: Thorsten Blum, netdev, keyrings, linux-kernel, linux-hardening Add the __counted_by() compiler attribute to the flexible array member 'data' to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and CONFIG_FORTIFY_SOURCE. Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> --- Changes in v2: - Use __aligned(8) as suggested by David - v1: https://lore.kernel.org/lkml/20260409073711.57020-6-thorsten.blum@linux.dev/ Cc: netdev@vger.kernel.org --- include/keys/user-type.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/keys/user-type.h b/include/keys/user-type.h index 386c31432789..c29ed9f5d300 100644 --- a/include/keys/user-type.h +++ b/include/keys/user-type.h @@ -27,7 +27,8 @@ struct user_key_payload { struct rcu_head rcu; /* RCU destructor */ unsigned short datalen; /* length of this data */ - char data[] __aligned(__alignof__(u64)); /* actual data */ + char data[] /* actual data */ + __aligned(8) __counted_by(datalen); }; extern struct key_type key_type_user; ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next v2 2/2] KEYS: annotate struct user_key_payload with __counted_by 2026-04-09 22:57 ` [PATCH net-next v2 2/2] KEYS: annotate struct user_key_payload with __counted_by Thorsten Blum @ 2026-04-15 2:25 ` Jarkko Sakkinen 0 siblings, 0 replies; 2+ messages in thread From: Jarkko Sakkinen @ 2026-04-15 2:25 UTC (permalink / raw) To: Thorsten Blum Cc: David Howells, Kees Cook, Gustavo A. R. Silva, netdev, keyrings, linux-kernel, linux-hardening On Fri, Apr 10, 2026 at 12:57:05AM +0200, Thorsten Blum wrote: > Add the __counted_by() compiler attribute to the flexible array member > 'data' to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and > CONFIG_FORTIFY_SOURCE. > > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> > --- > Changes in v2: > - Use __aligned(8) as suggested by David > - v1: https://lore.kernel.org/lkml/20260409073711.57020-6-thorsten.blum@linux.dev/ > > Cc: netdev@vger.kernel.org > --- > include/keys/user-type.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/keys/user-type.h b/include/keys/user-type.h > index 386c31432789..c29ed9f5d300 100644 > --- a/include/keys/user-type.h > +++ b/include/keys/user-type.h > @@ -27,7 +27,8 @@ > struct user_key_payload { > struct rcu_head rcu; /* RCU destructor */ > unsigned short datalen; /* length of this data */ > - char data[] __aligned(__alignof__(u64)); /* actual data */ > + char data[] /* actual data */ > + __aligned(8) __counted_by(datalen); > }; > > extern struct key_type key_type_user; The change is acceptable but I see no point split the declaration into two lines (as long as it passes checkpatch.pl as per line length). BR, Jarkko ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-15 2:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260409225703.158552-4-thorsten.blum@linux.dev>
2026-04-09 22:57 ` [PATCH net-next v2 2/2] KEYS: annotate struct user_key_payload with __counted_by Thorsten Blum
2026-04-15 2:25 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox