* [PATCH 3/3] hexagon/kbuild: replace CFLAGS_MODULE with KBUILD_CFLAGS_MODULE [not found] <1507533107-2069-1-git-send-email-caoj.fnst@cn.fujitsu.com> @ 2017-10-09 7:11 ` Cao jin 2017-10-10 1:26 ` Richard Kuo 0 siblings, 1 reply; 3+ messages in thread From: Cao jin @ 2017-10-09 7:11 UTC (permalink / raw) To: linux-kernel; +Cc: Richard Kuo, linux-hexagon As kbuild document & commit 6588169d51 says: KBUILD_CFLAGS_MODULE is used to add arch-specific options for $(CC). From commandline, CFLAGS_MODULE shall be used. Doesn't have any functional change, but just follow kbuild rules. Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com> CC: Richard Kuo <rkuo@codeaurora.org> CC: linux-hexagon@vger.kernel.org --- arch/hexagon/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/hexagon/Makefile b/arch/hexagon/Makefile index 207711a0..4f5c84c 100644 --- a/arch/hexagon/Makefile +++ b/arch/hexagon/Makefile @@ -11,9 +11,9 @@ KBUILD_CFLAGS += -fno-short-enums # Modules must use either long-calls, or use pic/plt. # Use long-calls for now, it's easier. And faster. -# CFLAGS_MODULE += -fPIC -# LDFLAGS_MODULE += -shared -CFLAGS_MODULE += -mlong-calls +# KBUILD_CFLAGS_MODULE += -fPIC +# KBUILD_LDFLAGS_MODULE += -shared +KBUILD_CFLAGS_MODULE += -mlong-calls cflags-y += $(call cc-option,-mv${CONFIG_HEXAGON_ARCH_VERSION}) aflags-y += $(call cc-option,-mv${CONFIG_HEXAGON_ARCH_VERSION}) -- 2.1.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 3/3] hexagon/kbuild: replace CFLAGS_MODULE with KBUILD_CFLAGS_MODULE 2017-10-09 7:11 ` [PATCH 3/3] hexagon/kbuild: replace CFLAGS_MODULE with KBUILD_CFLAGS_MODULE Cao jin @ 2017-10-10 1:26 ` Richard Kuo 2017-10-30 15:43 ` Masahiro Yamada 0 siblings, 1 reply; 3+ messages in thread From: Richard Kuo @ 2017-10-10 1:26 UTC (permalink / raw) To: Cao jin; +Cc: linux-kernel, linux-hexagon On Mon, Oct 09, 2017 at 03:11:47PM +0800, Cao jin wrote: > As kbuild document & commit 6588169d51 says: KBUILD_CFLAGS_MODULE is > used to add arch-specific options for $(CC). From commandline, > CFLAGS_MODULE shall be used. > Doesn't have any functional change, but just follow kbuild rules. > > Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com> > CC: Richard Kuo <rkuo@codeaurora.org> > CC: linux-hexagon@vger.kernel.org > --- > arch/hexagon/Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/hexagon/Makefile b/arch/hexagon/Makefile > index 207711a0..4f5c84c 100644 > --- a/arch/hexagon/Makefile > +++ b/arch/hexagon/Makefile > @@ -11,9 +11,9 @@ KBUILD_CFLAGS += -fno-short-enums > > # Modules must use either long-calls, or use pic/plt. > # Use long-calls for now, it's easier. And faster. > -# CFLAGS_MODULE += -fPIC > -# LDFLAGS_MODULE += -shared > -CFLAGS_MODULE += -mlong-calls > +# KBUILD_CFLAGS_MODULE += -fPIC > +# KBUILD_LDFLAGS_MODULE += -shared > +KBUILD_CFLAGS_MODULE += -mlong-calls > > cflags-y += $(call cc-option,-mv${CONFIG_HEXAGON_ARCH_VERSION}) > aflags-y += $(call cc-option,-mv${CONFIG_HEXAGON_ARCH_VERSION}) > -- > 2.1.0 > > > For Hexagon: Acked-by: Richard Kuo <rkuo@codeaurora.org> -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/3] hexagon/kbuild: replace CFLAGS_MODULE with KBUILD_CFLAGS_MODULE 2017-10-10 1:26 ` Richard Kuo @ 2017-10-30 15:43 ` Masahiro Yamada 0 siblings, 0 replies; 3+ messages in thread From: Masahiro Yamada @ 2017-10-30 15:43 UTC (permalink / raw) To: Richard Kuo; +Cc: Cao jin, Linux Kernel Mailing List, linux-hexagon 2017-10-10 10:26 GMT+09:00 Richard Kuo <rkuo@codeaurora.org>: > On Mon, Oct 09, 2017 at 03:11:47PM +0800, Cao jin wrote: >> As kbuild document & commit 6588169d51 says: KBUILD_CFLAGS_MODULE is >> used to add arch-specific options for $(CC). From commandline, >> CFLAGS_MODULE shall be used. >> Doesn't have any functional change, but just follow kbuild rules. >> >> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com> >> CC: Richard Kuo <rkuo@codeaurora.org> >> CC: linux-hexagon@vger.kernel.org >> --- >> arch/hexagon/Makefile | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/hexagon/Makefile b/arch/hexagon/Makefile >> index 207711a0..4f5c84c 100644 >> --- a/arch/hexagon/Makefile >> +++ b/arch/hexagon/Makefile >> @@ -11,9 +11,9 @@ KBUILD_CFLAGS += -fno-short-enums >> >> # Modules must use either long-calls, or use pic/plt. >> # Use long-calls for now, it's easier. And faster. >> -# CFLAGS_MODULE += -fPIC >> -# LDFLAGS_MODULE += -shared >> -CFLAGS_MODULE += -mlong-calls >> +# KBUILD_CFLAGS_MODULE += -fPIC >> +# KBUILD_LDFLAGS_MODULE += -shared >> +KBUILD_CFLAGS_MODULE += -mlong-calls >> >> cflags-y += $(call cc-option,-mv${CONFIG_HEXAGON_ARCH_VERSION}) >> aflags-y += $(call cc-option,-mv${CONFIG_HEXAGON_ARCH_VERSION}) >> -- >> 2.1.0 >> >> >> > > For Hexagon: > > Acked-by: Richard Kuo <rkuo@codeaurora.org> > Applied to linux-kbuild. Thanks! -- Best Regards Masahiro Yamada ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-30 15:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1507533107-2069-1-git-send-email-caoj.fnst@cn.fujitsu.com>
2017-10-09 7:11 ` [PATCH 3/3] hexagon/kbuild: replace CFLAGS_MODULE with KBUILD_CFLAGS_MODULE Cao jin
2017-10-10 1:26 ` Richard Kuo
2017-10-30 15:43 ` Masahiro Yamada
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox