From: Brian Cain <brian.cain@oss.qualcomm.com>
To: linux-kernel@vger.kernel.org
Cc: sid.manning@oss.qualcomm.com, peterz@infradead.org,
pierrick.bouvier@oss.qualcomm.com, linux-hexagon@vger.kernel.org,
paulmck@kernel.org, Brian Cain <brian.cain@oss.qualcomm.com>,
Ingo Molnar <mingo@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>
Subject: [PATCH] smp: align struct __call_single_node to 8 bytes
Date: Sat, 5 Sep 2026 19:39:05 -0700 [thread overview]
Message-ID: <20260906023905.2517725-1-brian.cain@oss.qualcomm.com> (raw)
Consumers walking call_single_queue cast each node to call_single_data_t
and, given that type's declared over-alignment, the compiler may load
llist.next and u_flags as one naturally aligned double word. Embedders
such as task_struct::wake_entry only guarantee pointer alignment, which
faults on strict-alignment 32-bit architectures like hexagon.
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Frederic Weisbecker <frederic@kernel.org>
Cc: linux-hexagon@vger.kernel.org
Signed-off-by: Brian Cain <brian.cain@oss.qualcomm.com>
---
include/linux/smp_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/smp_types.h b/include/linux/smp_types.h
index 2e8461af8df6..5773e1fb2660 100644
--- a/include/linux/smp_types.h
+++ b/include/linux/smp_types.h
@@ -64,6 +64,6 @@ struct __call_single_node {
#ifdef CONFIG_64BIT
u16 src, dst;
#endif
-};
+} __aligned(8);
#endif /* __LINUX_SMP_TYPES_H */
--
2.34.1
reply other threads:[~2026-09-06 2:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260906023905.2517725-1-brian.cain@oss.qualcomm.com \
--to=brian.cain@oss.qualcomm.com \
--cc=frederic@kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=sid.manning@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox