* [PATCH] smp: align struct __call_single_node to 8 bytes
@ 2026-09-06 2:39 Brian Cain
0 siblings, 0 replies; only message in thread
From: Brian Cain @ 2026-09-06 2:39 UTC (permalink / raw)
To: linux-kernel
Cc: sid.manning, peterz, pierrick.bouvier, linux-hexagon, paulmck,
Brian Cain, Ingo Molnar, Frederic Weisbecker
Consumers walking call_single_queue cast each node to call_single_data_t
and, given that type's declared over-alignment, the compiler may load
llist.next and u_flags as one naturally aligned double word. Embedders
such as task_struct::wake_entry only guarantee pointer alignment, which
faults on strict-alignment 32-bit architectures like hexagon.
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Frederic Weisbecker <frederic@kernel.org>
Cc: linux-hexagon@vger.kernel.org
Signed-off-by: Brian Cain <brian.cain@oss.qualcomm.com>
---
include/linux/smp_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/smp_types.h b/include/linux/smp_types.h
index 2e8461af8df6..5773e1fb2660 100644
--- a/include/linux/smp_types.h
+++ b/include/linux/smp_types.h
@@ -64,6 +64,6 @@ struct __call_single_node {
#ifdef CONFIG_64BIT
u16 src, dst;
#endif
-};
+} __aligned(8);
#endif /* __LINUX_SMP_TYPES_H */
--
2.34.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-09-06 2:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-06 2:39 [PATCH] smp: align struct __call_single_node to 8 bytes Brian Cain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).