[PATCH] modem-modeswitch: 61-option-modem-modeswitch.rules only

[PATCH] modem-modeswitch: 61-option-modem-modeswitch.rules only

[Dan Williams]

Make people aware that they shouldn't add devices not manufactured by
Option NV to 61-option-modem-modeswitch.rules.  modem-modeswitch only
supports ejecting the fake CD for Option NV devices at this time.
People should be using (and fixing) usb_modeswitch instead of
modem-modeswitch.

Signed-off-by: Dan Williams <dcbw@redhat.com>

---
Note: this patch depends on the revert of
53842b53820a0f0b2b0ff5b28caf01e3f7e26f22 and
5052297b6a8928d3ccfdd9996b71fdfff8bc8921.

Note #2; please CC-me in all replies as I'm not subscribed to the list.

diff --git a/extras/modem-modeswitch/61-option-modem-modeswitch.rules b/extras/modem-modeswitch/61-option-modem-modeswitch.rules
index 3ef6f08..933368c 100644
--- a/extras/modem-modeswitch/61-option-modem-modeswitch.rules
+++ b/extras/modem-modeswitch/61-option-modem-modeswitch.rules
@@ -1,3 +1,6 @@
+# NOTE: only for devices manufactured by Option NV
+# DO NOT add devices that are not manufactured by Option NV
+
 ACTION!="add", GOTO="option_zerocd_end"
 
 SUBSYSTEM="usb", ATTR{bDeviceClass}!="ff", ENV{DEVTYPE}="usb_device", GOTO="option_zerocd_disable"
@@ -34,5 +37,8 @@ ATTRS{idVendor}="0af0", ATTRS{idProduct}="7401", RUN+="modem-modeswitch -v 0x%
 ATTRS{idVendor}="0af0", ATTRS{idProduct}="7501", RUN+="modem-modeswitch -v 0x%s{idVendor} -p 0x%s{idProduct} -t option-zerocd"
 ATTRS{idVendor}="0af0", ATTRS{idProduct}="7601", RUN+="modem-modeswitch -v 0x%s{idVendor} -p 0x%s{idProduct} -t option-zerocd"
 ATTRS{idVendor}="0af0", ATTRS{idProduct}="7901", RUN+="modem-modeswitch -v 0x%s{idVendor} -p 0x%s{idProduct} -t option-zerocd"
+
+# NOTE: only for devices manufactured by Option NV
+# DO NOT add devices that are not manufactured by Option NV
 
 LABEL="option_zerocd_end"

Re: [PATCH] modem-modeswitch: 61-option-modem-modeswitch.rules only

[Kay Sievers]

On Sun, Nov 22, 2009 at 23:38, Dan Williams <dcbw@redhat.com> wrote:
> Make people aware that they shouldn't add devices not manufactured by
> Option NV to 61-option-modem-modeswitch.rules.  modem-modeswitch only
> supports ejecting the fake CD for Option NV devices at this time.
> People should be using (and fixing) usb_modeswitch instead of
> modem-modeswitch.

Hey Dan,
feel free to revert these wrong changes and apply such patches
yourself directly to the udev repo.

Please let me know, if I should do anything instead.

Thanks,
Kay