From: Bryan Kadzban <bryan@kadzban.is-a-geek.net>
To: linux-hotplug@vger.kernel.org
Subject: [PATCH] Fix default firmware search paths
Date: Mon, 30 Jan 2012 03:10:52 +0000 [thread overview]
Message-ID: <4F260A3C.6090309@kadzban.is-a-geek.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 714 bytes --]
"./configure --help" says the default firmware search path
(--with-firmware-path) is /lib/firmware/updates:/lib/firmware. But the
actual default is:
[with_firmware_path="$rootprefix/lib/firmware/updates:$rootprefix/lib/firmware"]
and $rootprefix defaults to $ac_default_prefix, which is /usr, not the
empty string.
Fix this by changing the default with_firmware_path to explicitly match
the directories the kernel uses to install firmware.
(An alternative fix would be to change the help string for
--with-firmware-path to mention ${rootprefix}, although I think it'd be
a good idea to mention that flag's default of /usr as well, if this is
done.)
Signed-Off-By: Bryan Kadzban <bryan@kadzban.is-a-geek.net>
[-- Attachment #2: udev-fix-firmware-search-paths.patch --]
[-- Type: text/plain, Size: 605 bytes --]
diff --git a/configure.ac b/configure.ac
index 9772d82..51dd7dd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -96,7 +96,7 @@ AS_IF([test "x$enable_logging" = "xyes"], [ AC_DEFINE(ENABLE_LOGGING, [1], [Syst
AC_ARG_WITH(firmware-path,
AS_HELP_STRING([--with-firmware-path=DIR[[[:DIR[...]]]]],
[Firmware search path (default=/lib/firmware/updates:/lib/firmware)]),
- [], [with_firmware_path="$rootprefix/lib/firmware/updates:$rootprefix/lib/firmware"])
+ [], [with_firmware_path="/lib/firmware/updates:/lib/firmware"])
OLD_IFS=$IFS
IFS=:
for i in $with_firmware_path; do
next reply other threads:[~2012-01-30 3:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 3:10 Bryan Kadzban [this message]
2012-01-30 3:34 ` [PATCH] Fix default firmware search paths Kay Sievers
2012-01-30 3:49 ` Bryan Kadzban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F260A3C.6090309@kadzban.is-a-geek.net \
--to=bryan@kadzban.is-a-geek.net \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox