From: Bryan Kadzban <bryan@kadzban.is-a-geek.net>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] Fix default firmware search paths
Date: Mon, 30 Jan 2012 03:49:40 +0000 [thread overview]
Message-ID: <4F261354.1010908@kadzban.is-a-geek.net> (raw)
In-Reply-To: <4F260A3C.6090309@kadzban.is-a-geek.net>
Kay Sievers wrote:
> On Mon, Jan 30, 2012 at 04:10, Bryan Kadzban
> <bryan@kadzban.is-a-geek.net> wrote:
>> "./configure --help" says the default firmware search path
>> (--with-firmware-path) is /lib/firmware/updates:/lib/firmware. But the
>> actual default is:
>>
>> [with_firmware_path="$rootprefix/lib/firmware/updates:$rootprefix/lib/firmware"]
>>
>> and $rootprefix defaults to $ac_default_prefix, which is /usr, not the
>> empty string.
>>
>> Fix this by changing the default with_firmware_path to explicitly match
>> the directories the kernel uses to install firmware.
>>
>> (An alternative fix would be to change the help string for
>> --with-firmware-path to mention ${rootprefix}, although I think it'd be
>> a good idea to mention that flag's default of /usr as well, if this is
>> done.)
>
> With rootprefix = prefix = /usr, everything is in /usr, also the
> kernel package is changed to install the stuff in /usr, and no longer
> in /lib.
The confusing thing to me is that the kernel source tree, when I "make
modules_install" (or firmware_install) dumps the files in /lib/firmware,
not under /usr. (Verified just now with 3.2.2 and a couple modules that
provide external firmware files: e100 / snd-ymfpci.)
On the other hand, I might have set something in the kernel config to
make it do that. Didn't notice it, but that doesn't mean much. :-/
> I'll change the help text.
That works too. Thanks!
prev parent reply other threads:[~2012-01-30 3:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 3:10 [PATCH] Fix default firmware search paths Bryan Kadzban
2012-01-30 3:34 ` Kay Sievers
2012-01-30 3:49 ` Bryan Kadzban [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F261354.1010908@kadzban.is-a-geek.net \
--to=bryan@kadzban.is-a-geek.net \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox