Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: <markus.stockhausen@gmx.de>
To: <sashiko@lists.linux.dev>
Cc: <linux-hwmon@vger.kernel.org>
Subject: AW: [PATCH 2/2] hwmon: (lm75) Support active-high alert polarity
Date: Fri, 1 May 2026 16:06:46 +0200	[thread overview]
Message-ID: <039601dcd973$bf191230$3d4b3690$@gmx.de> (raw)
In-Reply-To: <20260501124540.0C11CC2BCB4@smtp.kernel.org>

Hi bot,

> Von: sashiko-bot@kernel.org <sashiko-bot@kernel.org> 
> Gesendet: Freitag, 1. Mai 2026 14:46
> An: Markus Stockhausen <markus.stockhausen@gmx.de>
> Cc: linux-hwmon@vger.kernel.org
> Betreff: Re: [PATCH 2/2] hwmon: (lm75) Support active-high alert polarity
>
> Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
> - [High] The active-high alert polarity configuration is completely ignored by the hardware because it is not added to the register update mask.
> - [High] LM75_ALERT_POLARITY_HIGH_16_BIT targets the wrong byte of the configuration register.
> - [High] Changing the AS6200 default from active-high to active-low breaks devicetree backward compatibility.

unsure if answering to you helps both of us further. So my 2 cents only shortly:

- Issue 1: Existing definitions for tmp1XX devices do not not obey "clr_mask is superset of set_mask".
- Issue 2: AS6200 datasheet states BIT(10) is polarity. Thus .set_mask = 0x94C0 can only align one way.
- Issue 3: Please advise. 

Best regards.

Markus



  reply	other threads:[~2026-05-01 14:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-01 12:05 [PATCH 0/2] Support active-high alert polarity for LM75 Markus Stockhausen
2026-05-01 12:05 ` [PATCH 1/2] dt-bindings: hwmon: lm75: Add lm75,alert-polarity-active-high property Markus Stockhausen
2026-05-01 12:24   ` sashiko-bot
2026-05-02 17:37     ` AW: " markus.stockhausen
2026-05-02 18:10       ` Guenter Roeck
2026-05-03 18:02   ` Conor Dooley
2026-05-01 12:05 ` [PATCH 2/2] hwmon: (lm75) Support active-high alert polarity Markus Stockhausen
2026-05-01 12:45   ` sashiko-bot
2026-05-01 14:06     ` markus.stockhausen [this message]
2026-05-01 17:37       ` AW: " Guenter Roeck
2026-05-01 19:00         ` AW: " markus.stockhausen
2026-05-01 19:24           ` Guenter Roeck
2026-05-01 20:14         ` Guenter Roeck
2026-05-01 20:42           ` AW: " markus.stockhausen
2026-05-01 21:19             ` Guenter Roeck
2026-05-01 17:05   ` Conor Dooley
2026-05-01 19:32     ` Guenter Roeck
2026-05-03 18:00       ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='039601dcd973$bf191230$3d4b3690$@gmx.de' \
    --to=markus.stockhausen@gmx.de \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=sashiko@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox