Re: [PATCH 1/2] dt-bindings: hwmon: lm75: Add lm75,alert-polarity-active-high property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The custom Device Tree property `lm75,alert-polarity-active-high` uses an unregistered and invalid vendor prefix.
--

commit 69df01a5031a4da5aac0d016930cd76771ff596c
Author: Markus Stockhausen <markus.stockhausen@gmx.de>

dt-bindings: hwmon: lm75: Add lm75,alert-polarity-active-high property

This commit adds an optional boolean property to override the LM75 alert
pin polarity. It allows configuring the alert pin to be active-high instead
of the default active-low behavior.

> diff --git a/Documentation/devicetree/bindings/hwmon/lm75.yaml b/Documentation/devicetree/bindings/hwmon/lm75.yaml
> index 0b9fda81e3ec5..173751a726f34 100644
> --- a/Documentation/devicetree/bindings/hwmon/lm75.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/lm75.yaml
> @@ -54,6 +54,13 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  lm75,alert-polarity-active-high:

Does this property use an unregistered vendor prefix?

Device tree conventions require using a valid, registered vendor prefix
from vendor-prefixes.yaml for device-specific properties. The string lm75
is a device part number rather than a registered vendor.

Should this property be named with the proper vendor prefix for the
original LM75, such as national,alert-polarity-active-high?

> +    description: Alert pin is asserted based on the value of alert polarity
> +      bit of configuration register. Default value is normal (0 which maps to
> +      active-low). The other value is inverted (1 which maps to active-high).
> +      Specify this property to set the alert polarity to active-high.
> +    $ref: /schemas/types.yaml#/definitions/flag
> +
>  required:
>    - compatible
>    - reg

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260501120518.3085501-1-markus.stockhausen@gmx.de?part=1