* [PATCH] hwmon: (pmbus) Add driver for STMicroelectronics PM6764 Voltage Regulator
@ 2020-11-04 7:09 Yungteng Hsu
0 siblings, 0 replies; 3+ messages in thread
From: Yungteng Hsu @ 2020-11-04 7:09 UTC (permalink / raw)
To: linux-kernel, linux-hwmon; +Cc: Yungteng Hsu, alan
Add the pmbus driver for the STMicroelectronics pm6764 voltage regulator.
the output voltage use the MFR_READ_VOUT 0xD4
vout value returned is linear11
Signed-off-by: Charles Hsu <hsu.yungteng@gmail.com>
---
drivers/hwmon/pmbus/Kconfig | 8 ++++
drivers/hwmon/pmbus/Makefile | 1 +
drivers/hwmon/pmbus/pm6764tr.c | 74 ++++++++++++++++++++++++++++++++++
3 files changed, 83 insertions(+)
create mode 100644 drivers/hwmon/pmbus/pm6764tr.c
diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
index a25faf69fce3..2b487c401a4e 100644
--- a/drivers/hwmon/pmbus/Kconfig
+++ b/drivers/hwmon/pmbus/Kconfig
@@ -220,6 +220,14 @@ config SENSORS_MP2975
This driver can also be built as a module. If so, the module will
be called mp2975.
+config SENSORS_PM6764TR
+ tristate "PM6764TR"
+ help
+ If you say yes here you get hardware monitoring support for PM6764TR.
+
+ This driver can also be built as a module. If so, the module will
+ be called pm6764tr.
+
config SENSORS_PXE1610
tristate "Infineon PXE1610"
help
diff --git a/drivers/hwmon/pmbus/Makefile b/drivers/hwmon/pmbus/Makefile
index 4c97ad0bd791..31ebdef5d4a6 100644
--- a/drivers/hwmon/pmbus/Makefile
+++ b/drivers/hwmon/pmbus/Makefile
@@ -25,6 +25,7 @@ obj-$(CONFIG_SENSORS_MAX31785) += max31785.o
obj-$(CONFIG_SENSORS_MAX34440) += max34440.o
obj-$(CONFIG_SENSORS_MAX8688) += max8688.o
obj-$(CONFIG_SENSORS_MP2975) += mp2975.o
+obj-$(CONFIG_SENSORS_PM6764TR) += pm6764tr.o
obj-$(CONFIG_SENSORS_PXE1610) += pxe1610.o
obj-$(CONFIG_SENSORS_TPS40422) += tps40422.o
obj-$(CONFIG_SENSORS_TPS53679) += tps53679.o
diff --git a/drivers/hwmon/pmbus/pm6764tr.c b/drivers/hwmon/pmbus/pm6764tr.c
new file mode 100644
index 000000000000..b125a1cbfea5
--- /dev/null
+++ b/drivers/hwmon/pmbus/pm6764tr.c
@@ -0,0 +1,74 @@
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/init.h>
+#include <linux/err.h>
+#include <linux/slab.h>
+#include <linux/mutex.h>
+#include <linux/i2c.h>
+#include <linux/pmbus.h>
+#include "pmbus.h"
+
+#define PM6764TR_PMBUS_READ_VOUT 0xD4
+
+static int pm6764tr_read_word_data(struct i2c_client *client, int
page, int reg)
+{
+ int ret;
+
+ switch (reg) {
+ case PMBUS_VIRT_READ_VMON:
+ ret = pmbus_read_word_data(client, page,
+ PM6764TR_PMBUS_READ_VOUT);
+ break;
+ default:
+ ret = -ENODATA;
+ break;
+ }
+ return ret;
+}
+
+static struct pmbus_driver_info pm6764tr_info = {
+ .pages = 1,
+ .format[PSC_VOLTAGE_IN] = linear,
+ .format[PSC_VOLTAGE_OUT] = vid,
+ .format[PSC_TEMPERATURE] = linear,
+ .format[PSC_CURRENT_OUT] = linear,
+ .format[PSC_POWER] = linear,
+ .func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_IIN | PMBUS_HAVE_PIN |
+ PMBUS_HAVE_IOUT | PMBUS_HAVE_POUT | PMBUS_HAVE_VMON |
+ PMBUS_HAVE_STATUS_IOUT | PMBUS_HAVE_STATUS_VOUT |
+ PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP,
+ .read_word_data = pm6764tr_read_word_data,
+};
+
+static int pm6764tr_probe(struct i2c_client *client,
+ const struct i2c_device_id *id)
+{
+ return pmbus_do_probe(client, id, &pm6764tr_info);
+}
+
+static const struct i2c_device_id pm6764tr_id[] = {
+ {"pm6764tr", 0},
+ {}
+};
+MODULE_DEVICE_TABLE(i2c, pm6764tr_id);
+
+static const struct of_device_id pm6764tr_of_match[] = {
+ {.compatible = "pm6764tr"},
+ {}
+};
+/* This is the driver that will be inserted */
+static struct i2c_driver pm6764tr_driver = {
+ .driver = {
+ .name = "pm6764tr",
+ .of_match_table = of_match_ptr(pm6764tr_of_match),
+ },
+ .probe = pm6764tr_probe,
+ .remove = pmbus_do_remove,
+ .id_table = pm6764tr_id,
+};
+
+module_i2c_driver(pm6764tr_driver);
+
+MODULE_AUTHOR("Charles Hsu");
+MODULE_DESCRIPTION("PMBus driver for ST PM6764TR");
+MODULE_LICENSE("GPL");
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hwmon: (pmbus) Add driver for STMicroelectronics PM6764 Voltage Regulator
@ 2020-11-04 14:37 Guenter Roeck
2020-11-05 13:01 ` Charles Hsu
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2020-11-04 14:37 UTC (permalink / raw)
To: Yungteng Hsu; +Cc: linux-kernel, linux-hwmon, alan
On Wed, Nov 04, 2020 at 03:09:23PM +0800, Yungteng Hsu wrote:
> Add the pmbus driver for the STMicroelectronics pm6764 voltage regulator.
>
> the output voltage use the MFR_READ_VOUT 0xD4
> vout value returned is linear11
>
> Signed-off-by: Charles Hsu <hsu.yungteng@gmail.com>
Please use standard Linux kernel code formatting rules.
Run checkpatch --strict on the patch and make sure it does not report
any problems.
total: 1 errors, 39 warnings, 3 checks, 96 lines checked
is a bit much for a 74-line patch.
> ---
> drivers/hwmon/pmbus/Kconfig | 8 ++++
> drivers/hwmon/pmbus/Makefile | 1 +
> drivers/hwmon/pmbus/pm6764tr.c | 74 ++++++++++++++++++++++++++++++++++
> 3 files changed, 83 insertions(+)
> create mode 100644 drivers/hwmon/pmbus/pm6764tr.c
>
> diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
> index a25faf69fce3..2b487c401a4e 100644
> --- a/drivers/hwmon/pmbus/Kconfig
> +++ b/drivers/hwmon/pmbus/Kconfig
> @@ -220,6 +220,14 @@ config SENSORS_MP2975
> This driver can also be built as a module. If so, the module will
> be called mp2975.
>
> +config SENSORS_PM6764TR
> + tristate "PM6764TR"
> + help
> + If you say yes here you get hardware monitoring support for PM6764TR.
> +
> + This driver can also be built as a module. If so, the module will
> + be called pm6764tr.
> +
> config SENSORS_PXE1610
> tristate "Infineon PXE1610"
> help
> diff --git a/drivers/hwmon/pmbus/Makefile b/drivers/hwmon/pmbus/Makefile
> index 4c97ad0bd791..31ebdef5d4a6 100644
> --- a/drivers/hwmon/pmbus/Makefile
> +++ b/drivers/hwmon/pmbus/Makefile
> @@ -25,6 +25,7 @@ obj-$(CONFIG_SENSORS_MAX31785) += max31785.o
> obj-$(CONFIG_SENSORS_MAX34440) += max34440.o
> obj-$(CONFIG_SENSORS_MAX8688) += max8688.o
> obj-$(CONFIG_SENSORS_MP2975) += mp2975.o
> +obj-$(CONFIG_SENSORS_PM6764TR) += pm6764tr.o
> obj-$(CONFIG_SENSORS_PXE1610) += pxe1610.o
> obj-$(CONFIG_SENSORS_TPS40422) += tps40422.o
> obj-$(CONFIG_SENSORS_TPS53679) += tps53679.o
> diff --git a/drivers/hwmon/pmbus/pm6764tr.c b/drivers/hwmon/pmbus/pm6764tr.c
> new file mode 100644
> index 000000000000..b125a1cbfea5
> --- /dev/null
> +++ b/drivers/hwmon/pmbus/pm6764tr.c
> @@ -0,0 +1,74 @@
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/init.h>
> +#include <linux/err.h>
> +#include <linux/slab.h>
> +#include <linux/mutex.h>
> +#include <linux/i2c.h>
> +#include <linux/pmbus.h>
Alphabetic include file order, please.
> +#include "pmbus.h"
> +
> +#define PM6764TR_PMBUS_READ_VOUT 0xD4
tab after PM6764TR_PMBUS_READ_VOUT, please.
I see you don't use any tabs in the patch. Please do.
> +
> +static int pm6764tr_read_word_data(struct i2c_client *client, int
> page, int reg)
Corrupted ?
That makes me wonder if the patch was corrupted by your e-mail system,
and if that system replaced tabs with spaces. Is that possible ?
> +{
> + int ret;
> +
> + switch (reg) {
> + case PMBUS_VIRT_READ_VMON:
> + ret = pmbus_read_word_data(client, page,
> + PM6764TR_PMBUS_READ_VOUT);
That can be one line (line limit is now 100 columns).
> + break;
> + default:
> + ret = -ENODATA;
> + break;
> + }
> + return ret;
> +}
> +
> +static struct pmbus_driver_info pm6764tr_info = {
> + .pages = 1,
> + .format[PSC_VOLTAGE_IN] = linear,
> + .format[PSC_VOLTAGE_OUT] = vid,
> + .format[PSC_TEMPERATURE] = linear,
> + .format[PSC_CURRENT_OUT] = linear,
> + .format[PSC_POWER] = linear,
> + .func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_IIN | PMBUS_HAVE_PIN |
> + PMBUS_HAVE_IOUT | PMBUS_HAVE_POUT | PMBUS_HAVE_VMON |
> + PMBUS_HAVE_STATUS_IOUT | PMBUS_HAVE_STATUS_VOUT |
> + PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP,
> + .read_word_data = pm6764tr_read_word_data,
> +};
> +
> +static int pm6764tr_probe(struct i2c_client *client,
> + const struct i2c_device_id *id)
Please use the new style probe function (probe_new).
> +{
> + return pmbus_do_probe(client, id, &pm6764tr_info);
> +}
> +
> +static const struct i2c_device_id pm6764tr_id[] = {
> + {"pm6764tr", 0},
> + {}
> +};
> +MODULE_DEVICE_TABLE(i2c, pm6764tr_id);
> +
> +static const struct of_device_id pm6764tr_of_match[] = {
> + {.compatible = "pm6764tr"},
> + {}
> +};
> +/* This is the driver that will be inserted */
> +static struct i2c_driver pm6764tr_driver = {
> + .driver = {
> + .name = "pm6764tr",
> + .of_match_table = of_match_ptr(pm6764tr_of_match),
> + },
> + .probe = pm6764tr_probe,
> + .remove = pmbus_do_remove,
pmbus_do_remove no longer exists.
> + .id_table = pm6764tr_id,
> +};
> +
> +module_i2c_driver(pm6764tr_driver);
> +
> +MODULE_AUTHOR("Charles Hsu");
> +MODULE_DESCRIPTION("PMBus driver for ST PM6764TR");
> +MODULE_LICENSE("GPL");
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hwmon: (pmbus) Add driver for STMicroelectronics PM6764 Voltage Regulator
2020-11-04 14:37 [PATCH] hwmon: (pmbus) Add driver for STMicroelectronics PM6764 Voltage Regulator Guenter Roeck
@ 2020-11-05 13:01 ` Charles Hsu
0 siblings, 0 replies; 3+ messages in thread
From: Charles Hsu @ 2020-11-05 13:01 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Yungteng Hsu, linux-kernel, linux-hwmon, alan
On Wed, Nov 4, 2020 at 10:40 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On Wed, Nov 04, 2020 at 03:09:23PM +0800, Yungteng Hsu wrote:
> > Add the pmbus driver for the STMicroelectronics pm6764 voltage regulator.
> >
> > the output voltage use the MFR_READ_VOUT 0xD4
> > vout value returned is linear11
> >
> > Signed-off-by: Charles Hsu <hsu.yungteng@gmail.com>
>
> Please use standard Linux kernel code formatting rules.
> Run checkpatch --strict on the patch and make sure it does not report
> any problems.
>
> total: 1 errors, 39 warnings, 3 checks, 96 lines checked
>
> is a bit much for a 74-line patch.
>
Okay, I got it.
> > ---
> > drivers/hwmon/pmbus/Kconfig | 8 ++++
> > drivers/hwmon/pmbus/Makefile | 1 +
> > drivers/hwmon/pmbus/pm6764tr.c | 74 ++++++++++++++++++++++++++++++++++
> > 3 files changed, 83 insertions(+)
> > create mode 100644 drivers/hwmon/pmbus/pm6764tr.c
> >
> > diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
> > index a25faf69fce3..2b487c401a4e 100644
> > --- a/drivers/hwmon/pmbus/Kconfig
> > +++ b/drivers/hwmon/pmbus/Kconfig
> > @@ -220,6 +220,14 @@ config SENSORS_MP2975
> > This driver can also be built as a module. If so, the module will
> > be called mp2975.
> >
> > +config SENSORS_PM6764TR
> > + tristate "PM6764TR"
> > + help
> > + If you say yes here you get hardware monitoring support for PM6764TR.
> > +
> > + This driver can also be built as a module. If so, the module will
> > + be called pm6764tr.
> > +
> > config SENSORS_PXE1610
> > tristate "Infineon PXE1610"
> > help
> > diff --git a/drivers/hwmon/pmbus/Makefile b/drivers/hwmon/pmbus/Makefile
> > index 4c97ad0bd791..31ebdef5d4a6 100644
> > --- a/drivers/hwmon/pmbus/Makefile
> > +++ b/drivers/hwmon/pmbus/Makefile
> > @@ -25,6 +25,7 @@ obj-$(CONFIG_SENSORS_MAX31785) += max31785.o
> > obj-$(CONFIG_SENSORS_MAX34440) += max34440.o
> > obj-$(CONFIG_SENSORS_MAX8688) += max8688.o
> > obj-$(CONFIG_SENSORS_MP2975) += mp2975.o
> > +obj-$(CONFIG_SENSORS_PM6764TR) += pm6764tr.o
> > obj-$(CONFIG_SENSORS_PXE1610) += pxe1610.o
> > obj-$(CONFIG_SENSORS_TPS40422) += tps40422.o
> > obj-$(CONFIG_SENSORS_TPS53679) += tps53679.o
> > diff --git a/drivers/hwmon/pmbus/pm6764tr.c b/drivers/hwmon/pmbus/pm6764tr.c
> > new file mode 100644
> > index 000000000000..b125a1cbfea5
> > --- /dev/null
> > +++ b/drivers/hwmon/pmbus/pm6764tr.c
> > @@ -0,0 +1,74 @@
> > +#include <linux/kernel.h>
> > +#include <linux/module.h>
> > +#include <linux/init.h>
> > +#include <linux/err.h>
> > +#include <linux/slab.h>
> > +#include <linux/mutex.h>
> > +#include <linux/i2c.h>
> > +#include <linux/pmbus.h>
>
> Alphabetic include file order, please.
>
update include file order in v2.
> > +#include "pmbus.h"
> > +
> > +#define PM6764TR_PMBUS_READ_VOUT 0xD4
>
> tab after PM6764TR_PMBUS_READ_VOUT, please.
>
> I see you don't use any tabs in the patch. Please do.
>
> > +
> > +static int pm6764tr_read_word_data(struct i2c_client *client, int
> > page, int reg)
>
> Corrupted ?
>
> That makes me wonder if the patch was corrupted by your e-mail system,
> and if that system replaced tabs with spaces. Is that possible ?
>
This is corrupted by e-mail system,
and tabs are replaced with spaces.
I'll check the e-mail system setting and updated in v2.
> > +{
> > + int ret;
> > +
> > + switch (reg) {
> > + case PMBUS_VIRT_READ_VMON:
> > + ret = pmbus_read_word_data(client, page,
> > + PM6764TR_PMBUS_READ_VOUT);
>
> That can be one line (line limit is now 100 columns).
>
fix to one line in v2.
> > + break;
> > + default:
> > + ret = -ENODATA;
> > + break;
> > + }
> > + return ret;
> > +}
> > +
> > +static struct pmbus_driver_info pm6764tr_info = {
> > + .pages = 1,
> > + .format[PSC_VOLTAGE_IN] = linear,
> > + .format[PSC_VOLTAGE_OUT] = vid,
> > + .format[PSC_TEMPERATURE] = linear,
> > + .format[PSC_CURRENT_OUT] = linear,
> > + .format[PSC_POWER] = linear,
> > + .func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_IIN | PMBUS_HAVE_PIN |
> > + PMBUS_HAVE_IOUT | PMBUS_HAVE_POUT | PMBUS_HAVE_VMON |
> > + PMBUS_HAVE_STATUS_IOUT | PMBUS_HAVE_STATUS_VOUT |
> > + PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP,
> > + .read_word_data = pm6764tr_read_word_data,
> > +};
> > +
> > +static int pm6764tr_probe(struct i2c_client *client,
> > + const struct i2c_device_id *id)
>
> Please use the new style probe function (probe_new).
>
Change form .probe to .probe_new in v2.
> > +{
> > + return pmbus_do_probe(client, id, &pm6764tr_info);
> > +}
> > +
> > +static const struct i2c_device_id pm6764tr_id[] = {
> > + {"pm6764tr", 0},
> > + {}
> > +};
> > +MODULE_DEVICE_TABLE(i2c, pm6764tr_id);
> > +
> > +static const struct of_device_id pm6764tr_of_match[] = {
> > + {.compatible = "pm6764tr"},
> > + {}
> > +};
> > +/* This is the driver that will be inserted */
> > +static struct i2c_driver pm6764tr_driver = {
> > + .driver = {
> > + .name = "pm6764tr",
> > + .of_match_table = of_match_ptr(pm6764tr_of_match),
> > + },
> > + .probe = pm6764tr_probe,
> > + .remove = pmbus_do_remove,
>
> pmbus_do_remove no longer exists.
>
remove .remove = pmbus_do_remove in v2.
> > + .id_table = pm6764tr_id,
> > +};
> > +
> > +module_i2c_driver(pm6764tr_driver);
> > +
> > +MODULE_AUTHOR("Charles Hsu");
> > +MODULE_DESCRIPTION("PMBus driver for ST PM6764TR");
> > +MODULE_LICENSE("GPL");
> > --
> > 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-05 13:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-04 14:37 [PATCH] hwmon: (pmbus) Add driver for STMicroelectronics PM6764 Voltage Regulator Guenter Roeck
2020-11-05 13:01 ` Charles Hsu
-- strict thread matches above, loose matches on Subject: below --
2020-11-04 7:09 Yungteng Hsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox