* [PATCH v4 3/6] hwmon: scmi: update hwmon internal scale data type [not found] <20201119174906.43862-1-cristian.marussi@arm.com> @ 2020-11-19 17:49 ` Cristian Marussi 2020-11-19 17:59 ` Sudeep Holla 2020-11-21 16:59 ` Guenter Roeck 0 siblings, 2 replies; 4+ messages in thread From: Cristian Marussi @ 2020-11-19 17:49 UTC (permalink / raw) To: linux-kernel, linux-arm-kernel Cc: sudeep.holla, lukasz.luba, james.quinlan, Jonathan.Cameron, egranata, jbhayana, peter.hilber, mikhail.golubev, Igor.Skalkin, Cristian Marussi, linux-hwmon, Guenter Roeck Use an int to calculate scale values inside scmi_hwmon_scale() to match the updated scale data type in struct scmi_sensor_info. Cc: linux-hwmon@vger.kernel.org Cc: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> --- drivers/hwmon/scmi-hwmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c index 09ce30cba54b..17d064e58938 100644 --- a/drivers/hwmon/scmi-hwmon.c +++ b/drivers/hwmon/scmi-hwmon.c @@ -30,7 +30,7 @@ static inline u64 __pow10(u8 x) static int scmi_hwmon_scale(const struct scmi_sensor_info *sensor, u64 *value) { - s8 scale = sensor->scale; + int scale = sensor->scale; u64 f; switch (sensor->type) { -- 2.17.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v4 3/6] hwmon: scmi: update hwmon internal scale data type 2020-11-19 17:49 ` [PATCH v4 3/6] hwmon: scmi: update hwmon internal scale data type Cristian Marussi @ 2020-11-19 17:59 ` Sudeep Holla 2020-11-21 16:59 ` Guenter Roeck 1 sibling, 0 replies; 4+ messages in thread From: Sudeep Holla @ 2020-11-19 17:59 UTC (permalink / raw) To: Cristian Marussi, Guenter Roeck Cc: linux-kernel, linux-arm-kernel, lukasz.luba, james.quinlan, Jonathan.Cameron, egranata, jbhayana, peter.hilber, mikhail.golubev, Igor.Skalkin, linux-hwmon, Guenter Roeck, Sudeep Holla Hi Guenter, On Thu, Nov 19, 2020 at 05:49:03PM +0000, Cristian Marussi wrote: > Use an int to calculate scale values inside scmi_hwmon_scale() to match > the updated scale data type in struct scmi_sensor_info. > You were not cc-ed in previous versions unfortunately. I plan to take this along with the rest of SCMI changes if you are fine with this change and provide Ack/Review. Sorry for the rush. -- Regards, Sudeep ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4 3/6] hwmon: scmi: update hwmon internal scale data type 2020-11-19 17:49 ` [PATCH v4 3/6] hwmon: scmi: update hwmon internal scale data type Cristian Marussi 2020-11-19 17:59 ` Sudeep Holla @ 2020-11-21 16:59 ` Guenter Roeck 2020-11-23 10:00 ` Sudeep Holla 1 sibling, 1 reply; 4+ messages in thread From: Guenter Roeck @ 2020-11-21 16:59 UTC (permalink / raw) To: Cristian Marussi Cc: linux-kernel, linux-arm-kernel, sudeep.holla, lukasz.luba, james.quinlan, Jonathan.Cameron, egranata, jbhayana, peter.hilber, mikhail.golubev, Igor.Skalkin, linux-hwmon On Thu, Nov 19, 2020 at 05:49:03PM +0000, Cristian Marussi wrote: > Use an int to calculate scale values inside scmi_hwmon_scale() to match > the updated scale data type in struct scmi_sensor_info. > > Cc: linux-hwmon@vger.kernel.org > Cc: Guenter Roeck <linux@roeck-us.net> > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> Acked-by: Guenter Roeck <linux@roeck-us.net> [ Assuming this will be pushed togesther with the other patches in the series ] Guenter > --- > drivers/hwmon/scmi-hwmon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c > index 09ce30cba54b..17d064e58938 100644 > --- a/drivers/hwmon/scmi-hwmon.c > +++ b/drivers/hwmon/scmi-hwmon.c > @@ -30,7 +30,7 @@ static inline u64 __pow10(u8 x) > > static int scmi_hwmon_scale(const struct scmi_sensor_info *sensor, u64 *value) > { > - s8 scale = sensor->scale; > + int scale = sensor->scale; > u64 f; > > switch (sensor->type) { > -- > 2.17.1 > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4 3/6] hwmon: scmi: update hwmon internal scale data type 2020-11-21 16:59 ` Guenter Roeck @ 2020-11-23 10:00 ` Sudeep Holla 0 siblings, 0 replies; 4+ messages in thread From: Sudeep Holla @ 2020-11-23 10:00 UTC (permalink / raw) To: Guenter Roeck Cc: Cristian Marussi, linux-kernel, linux-arm-kernel, lukasz.luba, james.quinlan, Jonathan.Cameron, egranata, jbhayana, peter.hilber, mikhail.golubev, Igor.Skalkin, linux-hwmon On Sat, Nov 21, 2020 at 08:59:03AM -0800, Guenter Roeck wrote: > On Thu, Nov 19, 2020 at 05:49:03PM +0000, Cristian Marussi wrote: > > Use an int to calculate scale values inside scmi_hwmon_scale() to match > > the updated scale data type in struct scmi_sensor_info. > > > > Cc: linux-hwmon@vger.kernel.org > > Cc: Guenter Roeck <linux@roeck-us.net> > > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> > > Acked-by: Guenter Roeck <linux@roeck-us.net> > Thanks. > [ Assuming this will be pushed togesther with the other patches in the series ] > Yes I am planning to take as part of the series. -- Regards, Sudeep ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-23 10:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20201119174906.43862-1-cristian.marussi@arm.com>
2020-11-19 17:49 ` [PATCH v4 3/6] hwmon: scmi: update hwmon internal scale data type Cristian Marussi
2020-11-19 17:59 ` Sudeep Holla
2020-11-21 16:59 ` Guenter Roeck
2020-11-23 10:00 ` Sudeep Holla
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox