* Re: [PATCH] net: sfp: use simplified HWMON_CHANNEL_INFO macro
[not found] ` <Yv2UMcVUSwiaFyH6@lunn.ch>
@ 2022-08-18 2:19 ` Jakub Kicinski
2022-08-18 16:58 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2022-08-18 2:19 UTC (permalink / raw)
To: Andrew Lunn
Cc: Russell King (Oracle), Beniamin Sandu, hkallweit1, davem,
edumazet, pabeni, netdev, linux-kernel, linux-hwmon
On Thu, 18 Aug 2022 03:21:53 +0200 Andrew Lunn wrote:
> > > I had a quick look and couldn't see anything obviously wrong, but then
> > > I'm no expert with the hwmon code.
> >
> > That makes two of us, good enough! :) Thanks for taking a look.
>
> It would of been nice to Cc: the HWMON maintainer. His input would of
> been just as valuable as a PHY Maintainer.
Fair point, I lazy'd out and only checked that everyone get_maintainers
asks for was CCed. Perhaps it'd be worth extending the hwmon's keyword
match to trigger on the structs or the constants if it matters.
Adding hwmon@ to CC just in case.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: sfp: use simplified HWMON_CHANNEL_INFO macro
2022-08-18 2:19 ` [PATCH] net: sfp: use simplified HWMON_CHANNEL_INFO macro Jakub Kicinski
@ 2022-08-18 16:58 ` Guenter Roeck
2022-08-18 17:14 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2022-08-18 16:58 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Andrew Lunn, Russell King (Oracle), Beniamin Sandu, hkallweit1,
davem, edumazet, pabeni, netdev, linux-kernel, linux-hwmon
On Wed, Aug 17, 2022 at 07:19:16PM -0700, Jakub Kicinski wrote:
> On Thu, 18 Aug 2022 03:21:53 +0200 Andrew Lunn wrote:
> > > > I had a quick look and couldn't see anything obviously wrong, but then
> > > > I'm no expert with the hwmon code.
> > >
> > > That makes two of us, good enough! :) Thanks for taking a look.
> >
> > It would of been nice to Cc: the HWMON maintainer. His input would of
> > been just as valuable as a PHY Maintainer.
>
> Fair point, I lazy'd out and only checked that everyone get_maintainers
> asks for was CCed. Perhaps it'd be worth extending the hwmon's keyword
> match to trigger on the structs or the constants if it matters.
> Adding hwmon@ to CC just in case.
And you expect me to dig up the actual patch ?
Guenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: sfp: use simplified HWMON_CHANNEL_INFO macro
2022-08-18 16:58 ` Guenter Roeck
@ 2022-08-18 17:14 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2022-08-18 17:14 UTC (permalink / raw)
To: Guenter Roeck
Cc: Andrew Lunn, Russell King (Oracle), Beniamin Sandu, hkallweit1,
davem, edumazet, pabeni, netdev, linux-kernel, linux-hwmon
On Thu, 18 Aug 2022 09:58:56 -0700 Guenter Roeck wrote:
> And you expect me to dig up the actual patch ?
Sorry, I assumed we all have some form of fast lore access built
into our email setups. Here's the link to your reply and therefore
the thread:
https://lore.kernel.org/all/20220818165856.GC923105@roeck-us.net/
Speaking of expectations tho, I would expect you to not ask me
rhetorical passive aggressive questions.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-18 17:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220813204658.848372-1-beniaminsandu@gmail.com>
[not found] ` <20220817085429.4f7e4aac@kernel.org>
[not found] ` <Yv0TaF+So0euV0DR@shell.armlinux.org.uk>
[not found] ` <20220817101916.10dec387@kernel.org>
[not found] ` <Yv2UMcVUSwiaFyH6@lunn.ch>
2022-08-18 2:19 ` [PATCH] net: sfp: use simplified HWMON_CHANNEL_INFO macro Jakub Kicinski
2022-08-18 16:58 ` Guenter Roeck
2022-08-18 17:14 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox