* [PATCH] hwmon: (nzxt-smart2) add another USB ID
@ 2022-09-18 11:55 Aleksandr Mezin
2022-09-19 12:56 ` Guenter Roeck
0 siblings, 1 reply; 8+ messages in thread
From: Aleksandr Mezin @ 2022-09-18 11:55 UTC (permalink / raw)
To: linux-hwmon; +Cc: Guenter Roeck, Jean Delvare, Aleksandr Mezin
No known differences from already supported devices.
Signed-off-by: Aleksandr Mezin <mezin.alexander@gmail.com>
---
drivers/hwmon/nzxt-smart2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwmon/nzxt-smart2.c b/drivers/hwmon/nzxt-smart2.c
index dd892ff5a3e8..533f38b0b4e9 100644
--- a/drivers/hwmon/nzxt-smart2.c
+++ b/drivers/hwmon/nzxt-smart2.c
@@ -787,6 +787,7 @@ static void nzxt_smart2_hid_remove(struct hid_device *hdev)
static const struct hid_device_id nzxt_smart2_hid_id_table[] = {
{ HID_USB_DEVICE(0x1e71, 0x2006) }, /* NZXT Smart Device V2 */
{ HID_USB_DEVICE(0x1e71, 0x200d) }, /* NZXT Smart Device V2 */
+ { HID_USB_DEVICE(0x1e71, 0x200f) }, /* NZXT Smart Device V2 */
{ HID_USB_DEVICE(0x1e71, 0x2009) }, /* NZXT RGB & Fan Controller */
{ HID_USB_DEVICE(0x1e71, 0x200e) }, /* NZXT RGB & Fan Controller */
{ HID_USB_DEVICE(0x1e71, 0x2010) }, /* NZXT RGB & Fan Controller */
--
2.37.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] hwmon: (nzxt-smart2) add another USB ID
2022-09-18 11:55 [PATCH] hwmon: (nzxt-smart2) add another USB ID Aleksandr Mezin
@ 2022-09-19 12:56 ` Guenter Roeck
0 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2022-09-19 12:56 UTC (permalink / raw)
To: Aleksandr Mezin; +Cc: linux-hwmon, Jean Delvare
On Sun, Sep 18, 2022 at 05:55:06PM +0600, Aleksandr Mezin wrote:
> No known differences from already supported devices.
>
> Signed-off-by: Aleksandr Mezin <mezin.alexander@gmail.com>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] hwmon: (nzxt-smart2) add another USB ID
@ 2023-02-19 10:59 Aleksandr Mezin
2023-02-25 15:04 ` Guenter Roeck
0 siblings, 1 reply; 8+ messages in thread
From: Aleksandr Mezin @ 2023-02-19 10:59 UTC (permalink / raw)
To: linux-hwmon; +Cc: Herman Fries, Aleksandr Mezin, Jean Delvare, Guenter Roeck
This seems to be a new revision of the device. RGB controls have changed,
but this driver doesn't touch them anyway.
Fan speed control reported to be working with existing userspace (hidraw)
software, so I assume it's compatible. Fan channel count is the same.
Recently added (0x1e71, 0x2019) seems to be the same device.
Discovered in liquidctl project:
https://github.com/liquidctl/liquidctl/issues/541
Signed-off-by: Aleksandr Mezin <mezin.alexander@gmail.com>
---
drivers/hwmon/nzxt-smart2.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/hwmon/nzxt-smart2.c b/drivers/hwmon/nzxt-smart2.c
index 2b93ba89610a..a8e72d8fd060 100644
--- a/drivers/hwmon/nzxt-smart2.c
+++ b/drivers/hwmon/nzxt-smart2.c
@@ -791,7 +791,8 @@ static const struct hid_device_id nzxt_smart2_hid_id_table[] = {
{ HID_USB_DEVICE(0x1e71, 0x2009) }, /* NZXT RGB & Fan Controller */
{ HID_USB_DEVICE(0x1e71, 0x200e) }, /* NZXT RGB & Fan Controller */
{ HID_USB_DEVICE(0x1e71, 0x2010) }, /* NZXT RGB & Fan Controller */
- { HID_USB_DEVICE(0x1e71, 0x2019) }, /* NZXT RGB & Fan Controller */
+ { HID_USB_DEVICE(0x1e71, 0x2011) }, /* NZXT RGB & Fan Controller (6 RGB) */
+ { HID_USB_DEVICE(0x1e71, 0x2019) }, /* NZXT RGB & Fan Controller (6 RGB) */
{},
};
--
2.39.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] hwmon: (nzxt-smart2) add another USB ID
2023-02-19 10:59 Aleksandr Mezin
@ 2023-02-25 15:04 ` Guenter Roeck
0 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2023-02-25 15:04 UTC (permalink / raw)
To: Aleksandr Mezin; +Cc: linux-hwmon, Herman Fries, Jean Delvare
On Sun, Feb 19, 2023 at 12:59:19PM +0200, Aleksandr Mezin wrote:
> This seems to be a new revision of the device. RGB controls have changed,
> but this driver doesn't touch them anyway.
>
> Fan speed control reported to be working with existing userspace (hidraw)
> software, so I assume it's compatible. Fan channel count is the same.
>
> Recently added (0x1e71, 0x2019) seems to be the same device.
>
> Discovered in liquidctl project:
>
> https://github.com/liquidctl/liquidctl/issues/541
>
> Signed-off-by: Aleksandr Mezin <mezin.alexander@gmail.com>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] hwmon: (nzxt-smart2) add another USB ID
@ 2024-05-23 20:31 Aleksandr Mezin
2024-05-23 21:47 ` Guenter Roeck
0 siblings, 1 reply; 8+ messages in thread
From: Aleksandr Mezin @ 2024-05-23 20:31 UTC (permalink / raw)
To: linux-hwmon; +Cc: Aleksandr Mezin, stable, Jean Delvare, Guenter Roeck
Fan speed control reported to be working with existing userspace (hidraw)
software, so I assume it's compatible. Fan channel count is the same. No known
differences from already supported devices, at least regarding fan speed
control and initialization.
Discovered in liquidctl project:
https://github.com/liquidctl/liquidctl/pull/702
Signed-off-by: Aleksandr Mezin <mezin.alexander@gmail.com>
Cc: stable@vger.kernel.org # v6.1+
---
drivers/hwmon/nzxt-smart2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwmon/nzxt-smart2.c b/drivers/hwmon/nzxt-smart2.c
index 7aa586eb74be..df6fa72a6b59 100644
--- a/drivers/hwmon/nzxt-smart2.c
+++ b/drivers/hwmon/nzxt-smart2.c
@@ -799,6 +799,7 @@ static const struct hid_device_id nzxt_smart2_hid_id_table[] = {
{ HID_USB_DEVICE(0x1e71, 0x2010) }, /* NZXT RGB & Fan Controller */
{ HID_USB_DEVICE(0x1e71, 0x2011) }, /* NZXT RGB & Fan Controller (6 RGB) */
{ HID_USB_DEVICE(0x1e71, 0x2019) }, /* NZXT RGB & Fan Controller (6 RGB) */
+ { HID_USB_DEVICE(0x1e71, 0x2020) }, /* NZXT RGB & Fan Controller (6 RGB) */
{},
};
--
2.45.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] hwmon: (nzxt-smart2) add another USB ID
2024-05-23 20:31 Aleksandr Mezin
@ 2024-05-23 21:47 ` Guenter Roeck
2024-05-23 23:34 ` Aleksandr Mezin
0 siblings, 1 reply; 8+ messages in thread
From: Guenter Roeck @ 2024-05-23 21:47 UTC (permalink / raw)
To: Aleksandr Mezin, linux-hwmon; +Cc: Jean Delvare
On 5/23/24 13:31, Aleksandr Mezin wrote:
> Fan speed control reported to be working with existing userspace (hidraw)
> software, so I assume it's compatible. Fan channel count is the same. No known
> differences from already supported devices, at least regarding fan speed
> control and initialization.
>
> Discovered in liquidctl project:
>
> https://github.com/liquidctl/liquidctl/pull/702
>
That is not an appropriate commit description.
Guenter
> Signed-off-by: Aleksandr Mezin <mezin.alexander@gmail.com>
> Cc: stable@vger.kernel.org # v6.1+
> ---
> drivers/hwmon/nzxt-smart2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/nzxt-smart2.c b/drivers/hwmon/nzxt-smart2.c
> index 7aa586eb74be..df6fa72a6b59 100644
> --- a/drivers/hwmon/nzxt-smart2.c
> +++ b/drivers/hwmon/nzxt-smart2.c
> @@ -799,6 +799,7 @@ static const struct hid_device_id nzxt_smart2_hid_id_table[] = {
> { HID_USB_DEVICE(0x1e71, 0x2010) }, /* NZXT RGB & Fan Controller */
> { HID_USB_DEVICE(0x1e71, 0x2011) }, /* NZXT RGB & Fan Controller (6 RGB) */
> { HID_USB_DEVICE(0x1e71, 0x2019) }, /* NZXT RGB & Fan Controller (6 RGB) */
> + { HID_USB_DEVICE(0x1e71, 0x2020) }, /* NZXT RGB & Fan Controller (6 RGB) */
> {},
> };
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hwmon: (nzxt-smart2) add another USB ID
2024-05-23 21:47 ` Guenter Roeck
@ 2024-05-23 23:34 ` Aleksandr Mezin
2024-05-24 0:11 ` Guenter Roeck
0 siblings, 1 reply; 8+ messages in thread
From: Aleksandr Mezin @ 2024-05-23 23:34 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-hwmon, Jean Delvare
I'm sorry, I don't understand what exactly is wrong with the
description. Especially because patches with similar descriptions were
accepted before.
On Fri, May 24, 2024 at 12:47 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 5/23/24 13:31, Aleksandr Mezin wrote:
> > Fan speed control reported to be working with existing userspace (hidraw)
> > software, so I assume it's compatible. Fan channel count is the same. No known
> > differences from already supported devices, at least regarding fan speed
> > control and initialization.
> >
> > Discovered in liquidctl project:
> >
> > https://github.com/liquidctl/liquidctl/pull/702
> >
>
> That is not an appropriate commit description.
>
> Guenter
>
> > Signed-off-by: Aleksandr Mezin <mezin.alexander@gmail.com>
> > Cc: stable@vger.kernel.org # v6.1+
> > ---
> > drivers/hwmon/nzxt-smart2.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hwmon/nzxt-smart2.c b/drivers/hwmon/nzxt-smart2.c
> > index 7aa586eb74be..df6fa72a6b59 100644
> > --- a/drivers/hwmon/nzxt-smart2.c
> > +++ b/drivers/hwmon/nzxt-smart2.c
> > @@ -799,6 +799,7 @@ static const struct hid_device_id nzxt_smart2_hid_id_table[] = {
> > { HID_USB_DEVICE(0x1e71, 0x2010) }, /* NZXT RGB & Fan Controller */
> > { HID_USB_DEVICE(0x1e71, 0x2011) }, /* NZXT RGB & Fan Controller (6 RGB) */
> > { HID_USB_DEVICE(0x1e71, 0x2019) }, /* NZXT RGB & Fan Controller (6 RGB) */
> > + { HID_USB_DEVICE(0x1e71, 0x2020) }, /* NZXT RGB & Fan Controller (6 RGB) */
> > {},
> > };
> >
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hwmon: (nzxt-smart2) add another USB ID
2024-05-23 23:34 ` Aleksandr Mezin
@ 2024-05-24 0:11 ` Guenter Roeck
0 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2024-05-24 0:11 UTC (permalink / raw)
To: Aleksandr Mezin; +Cc: linux-hwmon, Jean Delvare
On 5/23/24 16:34, Aleksandr Mezin wrote:
> I'm sorry, I don't understand what exactly is wrong with the
> description. Especially because patches with similar descriptions were
> accepted before.
>
See Documentation/process/submitting-patches.rst, "Describe your changes"
And thanks for pointing out that I am not perfect.
Guenter
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-05-24 0:11 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-18 11:55 [PATCH] hwmon: (nzxt-smart2) add another USB ID Aleksandr Mezin
2022-09-19 12:56 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2023-02-19 10:59 Aleksandr Mezin
2023-02-25 15:04 ` Guenter Roeck
2024-05-23 20:31 Aleksandr Mezin
2024-05-23 21:47 ` Guenter Roeck
2024-05-23 23:34 ` Aleksandr Mezin
2024-05-24 0:11 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox