From: Zhang Rui <rui.zhang@intel.com>
To: linux-kernel@vger.kernel.org, x86@kernel.org,
linux-hwmon@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com, peterz@infradead.org,
jdelvare@suse.com, linux@roeck-us.net, len.brown@intel.com,
rui.zhang@intel.com
Subject: [PATCH V4 0/4] x86/topology: Fix CPUID.1F handling
Date: Fri, 14 Oct 2022 17:01:43 +0800 [thread overview]
Message-ID: <20221014090147.1836-1-rui.zhang@intel.com> (raw)
Handling for CPUID.1F is introduced by commit 7745f03eb395 ("x86/topology:
Add CPUID.1F multi-die/package support").
And only SMT/Core/Die level types are supported at that time.
On Intel AlderLake-N platforms where there are Ecores only, the Ecore
Module topology is enumerated via CPUID.1F Module level.
This exposes two bugs in the CPUID.1F handling code,
1. Linux interprets the Module ID bits as package ID and erroneously
reports a multi module system as a multi-package system.
2. Linux excludes the unknown Module ID bits from the core ID, and results
in duplicate core ID’s shown in a package after the first issue solved.
Patch 3/4 and 4/4 fixes these two problems in CPUID.1F handling code, and
patch 1/4 and 2/4 are needed to avoid potential regressions.
thanks,
-rui
---
Changes in V4:
- Drop a fix for a potential issue, as well as document cleanups/updates.
So this patch series only contains bug fixes (stable candidates).
- Integrate the patch subject/changelog improvements from Dave.
- Add Fixes tags.
Changes in V3:
- changelog improvements based on Peter' feedback
- Remove combined tags
Changes in V2:
- fix/improve changelog/comment wording issues
- reorder the patches to eliminate bisection breakage window
- add a new patch for coretemp driver variable renaming
- update coretemp driver patch to fix a case of ida_free(&ida, -2)
next reply other threads:[~2022-10-14 8:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 9:01 Zhang Rui [this message]
2022-10-14 9:01 ` [PATCH V4 1/4] hwmon/coretemp: Rename indx to index Zhang Rui
2022-10-14 13:26 ` Guenter Roeck
2022-10-14 17:12 ` Dave Hansen
2022-10-14 17:20 ` Guenter Roeck
2022-10-16 3:01 ` Zhang Rui
2022-10-14 9:01 ` [PATCH V4 2/4] hwmon/coretemp: Handle large core ID value Zhang Rui
2022-10-14 9:01 ` [PATCH V4 3/4] x86/topology: Fix multiple packages shown on a single-package system Zhang Rui
2022-10-14 9:01 ` [PATCH V4 4/4] x86/topology: Fix duplicated core ID within a package Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221014090147.1836-1-rui.zhang@intel.com \
--to=rui.zhang@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jdelvare@suse.com \
--cc=len.brown@intel.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox