Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: Zhang Rui <rui.zhang@intel.com>
To: Guenter Roeck <linux@roeck-us.net>,
	Dave Hansen <dave.hansen@intel.com>,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	linux-hwmon@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, hpa@zytor.com, peterz@infradead.org,
	jdelvare@suse.com, len.brown@intel.com
Subject: Re: [PATCH V4 1/4] hwmon/coretemp: Rename indx to index
Date: Sun, 16 Oct 2022 11:01:45 +0800	[thread overview]
Message-ID: <cc62b99f7762eeb5de271d87e1ceb8a69e56cb71.camel@intel.com> (raw)
In-Reply-To: <ed901a64-7002-4a4e-1342-c06f9a398fd1@roeck-us.net>

Hi, Dave,

Thanks for taking care of this.
That totally works for me.

thanks,
rui


On Fri, 2022-10-14 at 10:20 -0700, Guenter Roeck wrote:
> On 10/14/22 10:12, Dave Hansen wrote:
> > On 10/14/22 02:01, Zhang Rui wrote:
> > > Use variable name 'index' instead of 'indx' for the index in the
> > > core_data[] array.
> > > 
> > > No functional change expected.
> > > 
> > > Cc: stable@vger.kernel.org
> > > Suggested-by: Ingo Molnar <mingo@kernel.org>
> > > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> > 
> > Hi,
> > 
> > Thanks for paring this series down.
> > 
> > I think I'm also going to pull this patch out of the series before
> > I
> > apply it and just rework 2/4 to apply cleanly without it.  I just
> > can't
> > put this in our "urgent" fixes pile and keep the stable@ tag on
> > such a
> > trivial rename and keep a straight face.
> > 
> 
> To be fair, this patch was only submitted as a prerequisite to the
> next
> patch in the series because someone had objected to the use of both
> 'indx'
> and 'index' in the driver.
> 
> Guenter
> 


  reply	other threads:[~2022-10-16  3:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-14  9:01 [PATCH V4 0/4] x86/topology: Fix CPUID.1F handling Zhang Rui
2022-10-14  9:01 ` [PATCH V4 1/4] hwmon/coretemp: Rename indx to index Zhang Rui
2022-10-14 13:26   ` Guenter Roeck
2022-10-14 17:12   ` Dave Hansen
2022-10-14 17:20     ` Guenter Roeck
2022-10-16  3:01       ` Zhang Rui [this message]
2022-10-14  9:01 ` [PATCH V4 2/4] hwmon/coretemp: Handle large core ID value Zhang Rui
2022-10-14  9:01 ` [PATCH V4 3/4] x86/topology: Fix multiple packages shown on a single-package system Zhang Rui
2022-10-14  9:01 ` [PATCH V4 4/4] x86/topology: Fix duplicated core ID within a package Zhang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc62b99f7762eeb5de271d87e1ceb8a69e56cb71.camel@intel.com \
    --to=rui.zhang@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jdelvare@suse.com \
    --cc=len.brown@intel.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox