* [PATCH] hwmon: (aquacomputer_d5next) Remove unneeded CONFIG_DEBUG_FS #ifdef
@ 2023-12-16 14:07 Aleksa Savic
2023-12-17 15:10 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Aleksa Savic @ 2023-12-16 14:07 UTC (permalink / raw)
To: linux-hwmon
Cc: Aleksa Savic, Jack Doan, Jean Delvare, Guenter Roeck,
linux-kernel
Remove the #ifdef check for CONFIG_DEBUG_FS and the empty variant
of aqc_debugfs_init(), because the debugfs functions already do nothing
if debugfs isn't enabled.
Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
---
drivers/hwmon/aquacomputer_d5next.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/hwmon/aquacomputer_d5next.c b/drivers/hwmon/aquacomputer_d5next.c
index 4fdd2e12427b..2efe97f8d003 100644
--- a/drivers/hwmon/aquacomputer_d5next.c
+++ b/drivers/hwmon/aquacomputer_d5next.c
@@ -1476,8 +1476,6 @@ static int aqc_raw_event(struct hid_device *hdev, struct hid_report *report, u8
return 0;
}
-#ifdef CONFIG_DEBUG_FS
-
static int serial_number_show(struct seq_file *seqf, void *unused)
{
struct aqc_data *priv = seqf->private;
@@ -1527,14 +1525,6 @@ static void aqc_debugfs_init(struct aqc_data *priv)
debugfs_create_file("power_cycles", 0444, priv->debugfs, priv, &power_cycles_fops);
}
-#else
-
-static void aqc_debugfs_init(struct aqc_data *priv)
-{
-}
-
-#endif
-
static int aqc_probe(struct hid_device *hdev, const struct hid_device_id *id)
{
struct aqc_data *priv;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: (aquacomputer_d5next) Remove unneeded CONFIG_DEBUG_FS #ifdef
2023-12-16 14:07 [PATCH] hwmon: (aquacomputer_d5next) Remove unneeded CONFIG_DEBUG_FS #ifdef Aleksa Savic
@ 2023-12-17 15:10 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2023-12-17 15:10 UTC (permalink / raw)
To: Aleksa Savic; +Cc: linux-hwmon, Jack Doan, Jean Delvare, linux-kernel
On Sat, Dec 16, 2023 at 03:07:54PM +0100, Aleksa Savic wrote:
> Remove the #ifdef check for CONFIG_DEBUG_FS and the empty variant
> of aqc_debugfs_init(), because the debugfs functions already do nothing
> if debugfs isn't enabled.
>
> Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-17 15:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-16 14:07 [PATCH] hwmon: (aquacomputer_d5next) Remove unneeded CONFIG_DEBUG_FS #ifdef Aleksa Savic
2023-12-17 15:10 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox