Linux Hardware Monitor development
 help / color / mirror / Atom feed
* [PATCH] hwmon: (nct6775) add G15CF to ASUS WMI monitoring list
@ 2024-08-12 15:26 Denis Pauk
  2024-08-13 15:55 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Denis Pauk @ 2024-08-12 15:26 UTC (permalink / raw)
  To: pauk.denis; +Cc: jdelvare, linux, linux-hwmon, linux-kernel, attila

Boards G15CF has got a nct6775 chip, but by default there's no use of it
because of resource conflict with WMI method.

This commit adds such board to the WMI monitoring list.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=204807
Signed-off-by: Denis Pauk <pauk.denis@gmail.com>
Tested-by: Attila <attila@fulop.one>
---
 drivers/hwmon/nct6775-platform.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hwmon/nct6775-platform.c b/drivers/hwmon/nct6775-platform.c
index 9aa4dcf4a6f3..096f1daa8f2b 100644
--- a/drivers/hwmon/nct6775-platform.c
+++ b/drivers/hwmon/nct6775-platform.c
@@ -1269,6 +1269,7 @@ static const char * const asus_msi_boards[] = {
 	"EX-B760M-V5 D4",
 	"EX-H510M-V3",
 	"EX-H610M-V3 D4",
+	"G15CF",
 	"PRIME A620M-A",
 	"PRIME B560-PLUS",
 	"PRIME B560-PLUS AC-HES",
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] hwmon: (nct6775) add G15CF to ASUS WMI monitoring list
  2024-08-12 15:26 [PATCH] hwmon: (nct6775) add G15CF to ASUS WMI monitoring list Denis Pauk
@ 2024-08-13 15:55 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2024-08-13 15:55 UTC (permalink / raw)
  To: Denis Pauk; +Cc: jdelvare, linux-hwmon, linux-kernel, attila

On Mon, Aug 12, 2024 at 06:26:38PM +0300, Denis Pauk wrote:
> Boards G15CF has got a nct6775 chip, but by default there's no use of it
> because of resource conflict with WMI method.
> 
> This commit adds such board to the WMI monitoring list.

Please read the documentation for proper patch descriptions.
Specifically,

> Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
> instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
> to do frotz", as if you are giving orders to the codebase to change
> its behaviour.

I'll fix that up, but please keep it in mind for future patches.

Applied,

Thanks,
Guenter

> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=204807
> Signed-off-by: Denis Pauk <pauk.denis@gmail.com>
> Tested-by: Attila <attila@fulop.one>
> ---
>  drivers/hwmon/nct6775-platform.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hwmon/nct6775-platform.c b/drivers/hwmon/nct6775-platform.c
> index 9aa4dcf4a6f3..096f1daa8f2b 100644
> --- a/drivers/hwmon/nct6775-platform.c
> +++ b/drivers/hwmon/nct6775-platform.c
> @@ -1269,6 +1269,7 @@ static const char * const asus_msi_boards[] = {
>  	"EX-B760M-V5 D4",
>  	"EX-H510M-V3",
>  	"EX-H610M-V3 D4",
> +	"G15CF",
>  	"PRIME A620M-A",
>  	"PRIME B560-PLUS",
>  	"PRIME B560-PLUS AC-HES",

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-08-13 15:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-12 15:26 [PATCH] hwmon: (nct6775) add G15CF to ASUS WMI monitoring list Denis Pauk
2024-08-13 15:55 ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox