From: Armin Wolf <W_Armin@gmx.de>
To: james@equiv.tech, jlee@suse.com, corentin.chary@gmail.com,
luke@ljones.dev, matan@svgalib.org, coproscefalo@gmail.com
Cc: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com,
rafael@kernel.org, lenb@kernel.org,
platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/5] platform/x86: wmi: Pass event data directly to legacy notify handlers
Date: Thu, 22 Aug 2024 19:38:05 +0200 [thread overview]
Message-ID: <20240822173810.11090-1-W_Armin@gmx.de> (raw)
The current legacy WMI handlers are susceptible to picking up wrong
WMI event data on systems where different WMI devices share some
notification IDs.
Prevent this by letting the WMI driver core taking care of retrieving
the event data. This also simplifies the legacy WMI handlers and their
implementation inside the WMI driver core.
The first patch converts all legacy WMI notify handlers to stop using
wmi_get_event_data() and instead use the new event data provided by
the WMI driver core.
The second patch fixes a minor issue discovered inside the
hp-wmi-sensors driver, and the remaining patches perform some cleanups.
The patch series was tested on a Dell Inspiron 3505 and a Acer Aspire
E1-731 and appears to work.
Armin Wolf (5):
platform/x86: wmi: Pass event data directly to legacy notify handlers
hwmon: (hp-wmi-sensors) Check if WMI event data exists
platform/x86: wmi: Remove wmi_get_event_data()
platform/x86: wmi: Merge get_event_data() with wmi_get_notify_data()
platform/x86: wmi: Call both legacy and WMI driver notify handlers
drivers/hwmon/hp-wmi-sensors.c | 20 +---
drivers/platform/x86/acer-wmi.c | 16 +--
drivers/platform/x86/asus-wmi.c | 19 +--
drivers/platform/x86/dell/dell-wmi-aio.c | 13 +--
drivers/platform/x86/hp/hp-wmi.c | 16 +--
drivers/platform/x86/huawei-wmi.c | 14 +--
drivers/platform/x86/lg-laptop.c | 13 +--
drivers/platform/x86/msi-wmi.c | 20 +---
drivers/platform/x86/toshiba-wmi.c | 15 +--
drivers/platform/x86/wmi.c | 143 ++++++-----------------
include/linux/acpi.h | 3 +-
11 files changed, 53 insertions(+), 239 deletions(-)
--
2.39.2
next reply other threads:[~2024-08-22 17:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 17:38 Armin Wolf [this message]
2024-08-22 17:38 ` [PATCH 1/5] platform/x86: wmi: Pass event data directly to legacy notify handlers Armin Wolf
2024-08-27 8:32 ` Ilpo Järvinen
2024-08-22 17:38 ` [PATCH 2/5] hwmon: (hp-wmi-sensors) Check if WMI event data exists Armin Wolf
2024-08-23 5:57 ` James Seo
2024-08-23 6:03 ` Guenter Roeck
2024-08-27 8:20 ` Ilpo Järvinen
2024-08-27 22:11 ` Armin Wolf
2024-08-22 17:38 ` [PATCH 3/5] platform/x86: wmi: Remove wmi_get_event_data() Armin Wolf
2024-08-27 8:33 ` Ilpo Järvinen
2024-08-22 17:38 ` [PATCH 4/5] platform/x86: wmi: Merge get_event_data() with wmi_get_notify_data() Armin Wolf
2024-08-27 8:36 ` Ilpo Järvinen
2024-08-22 17:38 ` [PATCH 5/5] platform/x86: wmi: Call both legacy and WMI driver notify handlers Armin Wolf
2024-08-22 18:04 ` [PATCH 0/5] platform/x86: wmi: Pass event data directly to legacy " Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240822173810.11090-1-W_Armin@gmx.de \
--to=w_armin@gmx.de \
--cc=coproscefalo@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=james@equiv.tech \
--cc=jlee@suse.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=matan@svgalib.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox