From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Armin Wolf <W_Armin@gmx.de>
Cc: james@equiv.tech, jlee@suse.com, corentin.chary@gmail.com,
luke@ljones.dev, matan@svgalib.org, coproscefalo@gmail.com,
Hans de Goede <hdegoede@redhat.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
lenb@kernel.org, platform-driver-x86@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-acpi@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] hwmon: (hp-wmi-sensors) Check if WMI event data exists
Date: Tue, 27 Aug 2024 11:20:42 +0300 (EEST) [thread overview]
Message-ID: <e791f8ed-f6af-d433-5c9b-a68fc9598dcc@linux.intel.com> (raw)
In-Reply-To: <20240822173810.11090-3-W_Armin@gmx.de>
On Thu, 22 Aug 2024, Armin Wolf wrote:
> The BIOS can choose to return no event data in response to a
> WMI event, so the ACPI object passed to the WMI notify handler
> can be NULL.
>
> Check for such a situation and ignore the event in such a case.
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---
> drivers/hwmon/hp-wmi-sensors.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/hwmon/hp-wmi-sensors.c b/drivers/hwmon/hp-wmi-sensors.c
> index 6892518d537c..d6bdad26feb1 100644
> --- a/drivers/hwmon/hp-wmi-sensors.c
> +++ b/drivers/hwmon/hp-wmi-sensors.c
> @@ -1628,6 +1628,9 @@ static void hp_wmi_notify(union acpi_object *wobj, void *context)
> * HPBIOS_BIOSEvent instance.
> */
>
> + if (!wobj)
> + return;
> +
I'm left to wonder why is this patch is not placed first? Can't this
happen regardless who gets the wobj? And in that case, should this have
a Fixes tag?
--
i.
next prev parent reply other threads:[~2024-08-27 8:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 17:38 [PATCH 0/5] platform/x86: wmi: Pass event data directly to legacy notify handlers Armin Wolf
2024-08-22 17:38 ` [PATCH 1/5] " Armin Wolf
2024-08-27 8:32 ` Ilpo Järvinen
2024-08-22 17:38 ` [PATCH 2/5] hwmon: (hp-wmi-sensors) Check if WMI event data exists Armin Wolf
2024-08-23 5:57 ` James Seo
2024-08-23 6:03 ` Guenter Roeck
2024-08-27 8:20 ` Ilpo Järvinen [this message]
2024-08-27 22:11 ` Armin Wolf
2024-08-22 17:38 ` [PATCH 3/5] platform/x86: wmi: Remove wmi_get_event_data() Armin Wolf
2024-08-27 8:33 ` Ilpo Järvinen
2024-08-22 17:38 ` [PATCH 4/5] platform/x86: wmi: Merge get_event_data() with wmi_get_notify_data() Armin Wolf
2024-08-27 8:36 ` Ilpo Järvinen
2024-08-22 17:38 ` [PATCH 5/5] platform/x86: wmi: Call both legacy and WMI driver notify handlers Armin Wolf
2024-08-22 18:04 ` [PATCH 0/5] platform/x86: wmi: Pass event data directly to legacy " Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e791f8ed-f6af-d433-5c9b-a68fc9598dcc@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=W_Armin@gmx.de \
--cc=coproscefalo@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=james@equiv.tech \
--cc=jlee@suse.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=matan@svgalib.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox