Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Alexis Cezar Torreno <alexisczezar.torreno@analog.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
	"Radu Sabau" <radu.sabau@analog.com>,
	"Jean Delvare" <jdelvare@suse.com>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: (pmbus/adp1050): Support adp1051 and adp1055: add bindings.
Date: Wed, 6 Nov 2024 15:48:55 +0000	[thread overview]
Message-ID: <20241106-linoleum-kebab-decf14f54f76@spud> (raw)
In-Reply-To: <20241106090311.17536-2-alexisczezar.torreno@analog.com>

[-- Attachment #1: Type: text/plain, Size: 1827 bytes --]

On Wed, Nov 06, 2024 at 05:03:10PM +0800, Alexis Cezar Torreno wrote:
> Add dt-bindings for adp1051 and adp1055 pmbus.
> ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature
> ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature
> 
> Signed-off-by: Alexis Cezar Torreno <alexisczezar.torreno@analog.com>
> ---
>  .../devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml
> index 10c2204bc3df..88aaa29b3bd1 100644
> --- a/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml
> @@ -10,16 +10,24 @@ maintainers:
>    - Radu Sabau <radu.sabau@analog.com>
>  
>  description: |
> -   The ADP1050 is used to monitor system voltages, currents and temperatures.
> +   The ADP1050 and similar devices are used to monitor system voltages,
> +   currents, power, and temperatures.
> +
>     Through the PMBus interface, the ADP1050 targets isolated power supplies
>     and has four individual monitors for input/output voltage, input current
>     and temperature.
>     Datasheet:
>       https://www.analog.com/en/products/adp1050.html
> +     https://www.analog.com/en/products/adp1051.html
> +     https://www.analog.com/en/products/adp1055.html
>  
>  properties:
> +

That's an abnormal newline, leave it alone if you respin.

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

>    compatible:
> -    const: adi,adp1050
> +    enum:
> +      - adi,adp1050
> +      - adi,adp1051
> +      - adi,adp1055
>  
>    reg:
>      maxItems: 1
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2024-11-06 15:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-06  9:03 [PATCH 0/2] Add support for ADP1051 and ADP1055 Alexis Cezar Torreno
2024-11-06  9:03 ` [PATCH 1/2] dt-bindings: hwmon: (pmbus/adp1050): Support adp1051 and adp1055: add bindings Alexis Cezar Torreno
2024-11-06 15:48   ` Conor Dooley [this message]
2024-11-07  0:49     ` Torreno, Alexis Czezar
2024-11-06  9:03 ` [PATCH 2/2] hwmon: (pmbus/adp1050): Support adp1051 and adp1055 Alexis Cezar Torreno
2024-11-06 11:24   ` Andy Shevchenko
2024-11-06 15:55     ` Guenter Roeck
2024-11-06 16:01       ` Andy Shevchenko
2024-11-07  1:17         ` Torreno, Alexis Czezar
2024-11-07  8:05           ` Andy Shevchenko
2024-11-07  8:34             ` Torreno, Alexis Czezar
2024-11-07  2:06       ` Torreno, Alexis Czezar
2024-11-06 16:40   ` kernel test robot
2024-11-06 16:50   ` kernel test robot
2024-11-06 21:11   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241106-linoleum-kebab-decf14f54f76@spud \
    --to=conor@kernel.org \
    --cc=alexisczezar.torreno@analog.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=radu.sabau@analog.com \
    --cc=robh@kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox