* [PATCH v1 1/1] hwmon: (qnap-mcu) Remove (explicitly) unused header
@ 2025-03-31 7:06 Andy Shevchenko
2025-03-31 13:53 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2025-03-31 7:06 UTC (permalink / raw)
To: Heiko Stuebner, Andy Shevchenko, linux-hwmon, linux-kernel
Cc: Jean Delvare, Guenter Roeck
The fwnode.h is not supposed to be used by the drivers as it
has the definitions for the core parts for different device
property provider implementations. Drop it.
Note, that fwnode API for drivers is provided in property.h
which is included here.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/hwmon/qnap-mcu-hwmon.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hwmon/qnap-mcu-hwmon.c b/drivers/hwmon/qnap-mcu-hwmon.c
index 29057514739c..e86e64c4d391 100644
--- a/drivers/hwmon/qnap-mcu-hwmon.c
+++ b/drivers/hwmon/qnap-mcu-hwmon.c
@@ -6,7 +6,6 @@
* Copyright (C) 2024 Heiko Stuebner <heiko@sntech.de>
*/
-#include <linux/fwnode.h>
#include <linux/hwmon.h>
#include <linux/mfd/qnap-mcu.h>
#include <linux/module.h>
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] hwmon: (qnap-mcu) Remove (explicitly) unused header
2025-03-31 7:06 [PATCH v1 1/1] hwmon: (qnap-mcu) Remove (explicitly) unused header Andy Shevchenko
@ 2025-03-31 13:53 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2025-03-31 13:53 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Heiko Stuebner, linux-hwmon, linux-kernel, Jean Delvare
On Mon, Mar 31, 2025 at 10:06:00AM +0300, Andy Shevchenko wrote:
> The fwnode.h is not supposed to be used by the drivers as it
> has the definitions for the core parts for different device
> property provider implementations. Drop it.
>
> Note, that fwnode API for drivers is provided in property.h
> which is included here.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/qnap-mcu-hwmon.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hwmon/qnap-mcu-hwmon.c b/drivers/hwmon/qnap-mcu-hwmon.c
> index 29057514739c..e86e64c4d391 100644
> --- a/drivers/hwmon/qnap-mcu-hwmon.c
> +++ b/drivers/hwmon/qnap-mcu-hwmon.c
> @@ -6,7 +6,6 @@
> * Copyright (C) 2024 Heiko Stuebner <heiko@sntech.de>
> */
>
> -#include <linux/fwnode.h>
> #include <linux/hwmon.h>
> #include <linux/mfd/qnap-mcu.h>
> #include <linux/module.h>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-31 13:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-31 7:06 [PATCH v1 1/1] hwmon: (qnap-mcu) Remove (explicitly) unused header Andy Shevchenko
2025-03-31 13:53 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox