From: sashiko-bot@kernel.org
To: "Zaixiang Xu" <zaixiang.xu.dev@gmail.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v6 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series
Date: Tue, 28 Apr 2026 21:52:03 +0000 [thread overview]
Message-ID: <20260428215204.7CBE6C2BCAF@smtp.kernel.org> (raw)
In-Reply-To: <1777374569-59233-3-git-send-email-zaixiang.xu.dev@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message fails to document the addition of the `reset-gpios` property.
--
commit 525f467a79c77fd6f91d6d35fc10f95495902569
Author: Zaixiang Xu <zaixiang.xu.dev@gmail.com>
dt-bindings: hwmon: Add Sensirion SHT30 series
This commit adds the YAML devicetree binding schema for the Sensirion SHT30
series and GXCAS GXHT30 sensors. It establishes fallback compatibles and
introduces several optional properties for the devices.
> Use fallback compatibles for compatible chips and add optional
> interrupts and vdd-supply properties.
This isn't a bug, but the commit message states that interrupts and
vdd-supply are added as optional properties, while the actual schema also
introduces a reset-gpios property.
Could the commit message be updated to also mention the addition of the
reset-gpios property so it matches the changes in the schema?
--
Sashiko AI review · https://sashiko.dev/#/patchset/1777374569-59233-1-git-send-email-zaixiang.xu.dev@gmail.com?part=2
next prev parent reply other threads:[~2026-04-28 21:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 11:09 [PATCH v6 0/4] hwmon: (sht3x) Add support for GXCAS GXHT30 Zaixiang Xu
2026-04-28 11:09 ` [PATCH v6 1/4] dt-bindings: vendor-prefixes: Add GXCAS Technology Zaixiang Xu
2026-04-28 11:09 ` [PATCH v6 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series Zaixiang Xu
2026-04-28 21:52 ` sashiko-bot [this message]
2026-04-29 6:27 ` Krzysztof Kozlowski
2026-04-29 6:28 ` Krzysztof Kozlowski
2026-04-28 11:09 ` [PATCH v6 3/4] hwmon: (sht3x) Add devicetree support Zaixiang Xu
2026-04-28 22:09 ` sashiko-bot
2026-04-28 11:09 ` [PATCH v6 4/4] hwmon: (sht3x) Add support for GXCAS GXHT30 Zaixiang Xu
2026-04-28 22:16 ` sashiko-bot
2026-04-29 6:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260428215204.7CBE6C2BCAF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko@lists.linux.dev \
--cc=zaixiang.xu.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox